Retropex/dolphin
1
0
Fork 0
mirror of https://github.com/Retropex/dolphin.git synced 2025-05-28 04:52:35 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
24,339 Commits 11 Branches 32 Tags 698 MiB
7b70fce79b
Commit Graph

8337 Commits

Author SHA1 Message Date
Léo Lam
dd31a403db Merge pull request #5285 from spycrab/fr_9952 
Make title column toggleable (Issue #9952)
 2017-04-24 23:12:39 +02:00
Léo Lam
286e9b74ee Merge pull request #5309 from leoetlino/ios-uid-gid 
IOS: Implement UID/GID changes for the PPC
 2017-04-24 22:50:03 +02:00
Michael Maltese
4c5e283e75 WiimoteReal: init and destroy ScannerBackends in same thread 
This fixes an error condition on macOS when HIDAPI calls
IOHIDManagerCreate and IOHIDManagerClose on different threads. The
error behavior is non-deterministic, but can cause EXC_BAD_ACCES and
kill the program.
 2017-04-23 17:11:27 -07:00
Léo Lam
dae950ff90 IOS: Implement UID/GID changes for the PPC 
This will be required for permission checks in the future.

Note that this is only for the PPC as we do not have actual processes.
Keeping track of other modules' UIDs/GIDs is virtually useless anyway.

UID/GID changes are implemented in the following functions:

* ES_Launch
* ES_DIVerify

ES_SetUid is not implemented yet because it'd need further changes.
 2017-04-23 23:09:44 +02:00
MerryMage
bd4cfaaed7 Jit_Integer: Use constant pool in GenerateOverflow 2017-04-22 10:15:04 +01:00
Léo Lam
b09561ece2 IOS/ES: Implement GetSharedContents (+ count) 
Used by the system menu when importing a title from SD.

These are probably the last two ioctlvs used by a major title.
 2017-04-21 19:30:20 +02:00
Markus Wick
207a95f4dc Merge pull request #5267 from leoetlino/more-es-ioctlvs 
IOS/ES: Implement ES_DIGetTMD and ES_DIGetTMDSize
 2017-04-21 11:08:05 +02:00
Mat M
4517231a1a Merge pull request #5287 from sepalani/rso 
Generate Symbols From RSO Modules added
 2017-04-20 20:06:03 -04:00
Sepalani
694b10da11 Generate Symbols From RSO Modules added 2017-04-21 00:32:06 +01:00
Markus Wick
936910163a Merge pull request #5286 from lioncash/mmu 
MMU: Get rid of pointer casts
 2017-04-18 12:35:42 +02:00
Lioncash
a58d5fa8ee MMU: Get rid of pointer casts 
These sort of casts invoke undefined behavior (u8, u16, u32, and u64 all have
completely different alignment requirements).
 2017-04-17 20:52:57 -04:00
Lioncash
9cfc671c69 MMU: Get rid of unnecessary temporaries in HostRead_[8|16|32] functions 2017-04-17 19:13:47 -04:00
spycrab
72e92add8a Make title column toggleable (Issue #9952) 2017-04-17 19:34:14 +02:00
JosJuice
9cd9ae902a x86-64 support on Android 
We can do this now that the x86-64 JIT supports PIE.

JITIL is deliberately excluded from the GUI because it
doesn't support PIE yet. (JITIL will be used if it's
set in the INI, though.)
 2017-04-16 11:53:33 +02:00
Dwayne Slater
ec9579ebcd Boot: When loading an FST for a Wii game, update IOS_MEM1_ARENA_END 
Without doing this, Wii games loaded as an ELF will zero out the FST.
This mirrors the behavior of the actual apploader.
 2017-04-15 14:03:38 -04:00
Markus Wick
a389ae0711 Merge pull request #5260 from MerryMage/CheckIfSafeAddress 
EmuCodeBlock: Make CheckIfSafeAddress PIE-compliant
 2017-04-15 13:26:05 +02:00
MerryMage
cb900106c6 IR_X86: Prefer static_cast to C-style casts 2017-04-15 10:35:40 +01:00
MerryMage
860ac52a79 IR_X86: Use PtrOffset instead of casting pointers 2017-04-15 10:35:24 +01:00
MerryMage
6d8738e6e4 IR_X86: Simplify trinary expressions 2017-04-15 10:35:01 +01:00
Markus Wick
8d4be36963 Merge pull request #5259 from MerryMage/quantload 
Jit64: Make psq_lXX PIE-compliant
 2017-04-15 11:20:09 +02:00
Markus Wick
fb805e3acb Merge pull request #5263 from MerryMage/dcbz 
Jit_LoadStore: Fix dbat memory access
 2017-04-15 11:19:24 +02:00
MerryMage
03d07c36ae JitArm64: Reserve W30 in SafeStoreFromReg and stfXX 
Bug introduced in c45028a708.

EmitBackpatchRoutine assumes that X30 is available as a temporary.
 2017-04-15 08:23:14 +01:00
MerryMage
3fb886141d JitArm64_LoadStore: Fix bug in writing byte to gather pipe 
Introduced by c45028a708.
 2017-04-15 07:26:27 +01:00
Léo Lam
183193e6ed IOS/ES: Implement ES_DIGetTMD and ES_DIGetTMDSize 
Used by Metroid Prime.
 2017-04-15 00:39:34 +02:00
MerryMage
b792299ef1 Jit_LoadStore: Fix dbat memory access 
Was broken by e10b715666
 2017-04-14 14:06:13 +01:00
MerryMage
daa03cd106 EmuCodeBlock: Make CheckIfSafeAddress PIE-compliant 2017-04-14 12:39:12 +01:00
MerryMage
e10b715666 Jit_LoadStore: Make dcbz PIE-compliant 2017-04-14 12:33:25 +01:00
MerryMage
cac77527e9 Jit64: Make psq_lXX PIE-compliant 2017-04-14 11:52:33 +01:00
Markus Wick
05fec44ff5 Merge pull request #5257 from MerryMage/gpfifo2 
GPFifo: Use a pointer instead of an index
 2017-04-14 12:27:51 +02:00
MerryMage
c45028a708 GPFifo: Use a pointer instead of an index 
This simplifies code generated by the jits.
x86_64 jit now emits PIC.
 2017-04-14 10:37:47 +01:00
Markus Wick
45e4a048ea Merge pull request #4708 from degasus/PIE 
Jit64: Use a temporary register for memory references.
 2017-04-14 09:42:45 +02:00
MerryMage
f2e323de9c ConfigManager: Increase default latency for OpenAL backend to 5 2017-04-13 10:41:18 +01:00
Lioncash
8811937756 JitArm64_RegCache: Use std::array where applicable 
There's no need to use std::vector for fixed enum values.
 2017-04-12 22:34:34 -04:00
degasus
64ccf803bd Jit64: Use a temporary register for memory references. Part 4. 2017-04-12 20:53:17 +02:00
degasus
0ddd90b539 Jit64: Use a temporary register for memory references. Part 3. 2017-04-12 20:53:17 +02:00
degasus
78b36921d2 Jit64: Use a temporary register for memory references. Part 1. 2017-04-12 20:53:17 +02:00
Markus Wick
60d8ee4916 Merge pull request #5250 from MerryMage/psq_st 
Jit_LoadStorePaired: Make psq_st PIE-compliant
 2017-04-12 20:52:59 +02:00
MerryMage
265f0da256 Jit_LoadStorePaired: Make psq_st PIE-compliant 2017-04-12 19:30:42 +01:00
Markus Wick
2151858fb1 Merge pull request #5241 from MerryMage/stretch 
Pitch-Preserving Audio Stretching
 2017-04-12 20:27:26 +02:00
MerryMage
26514358f4 Add audio stretching as a configuration option 2017-04-12 13:56:29 +01:00
Mat M
21544f8661 Merge pull request #5228 from JosJuice/why-did-this-exist 
Get rid of some nonsense related to booting DOL/ELF files
 2017-04-12 08:07:54 -04:00
Mat M
8ecc5e9b7a Merge pull request #5246 from MerryMage/math-util 
Jit64AsmCommon: Make frsqrte and fres PIE-compliant
 2017-04-11 16:11:19 -04:00
MerryMage
f7ed979e30 Jit64AsmCommon: Make frsqrte and fres PIE-compliant 2017-04-11 20:25:18 +01:00
MerryMage
433999d60f ConstantPool: Return a pointer instead of an OpArg 
This allows for greater flexibility.
 2017-04-11 20:25:18 +01:00
Anthony
464df471ff Merge pull request #5081 from lioncash/sd 
IOS/SDIOSlot0: Separate IOCtl/IOCtlV behavior into individual functions
 2017-04-11 10:38:49 -07:00
Mat M
ae80a7541d Merge pull request #5239 from sepalani/is-valid-instruction 
PPCTables: Do not consider OPTYPE_UNKNOWN as valid instruction
 2017-04-10 16:50:22 -04:00
Markus Wick
34ac749b8b Merge pull request #5144 from MerryMage/mfspr 
Jit_SystemRegisters: Make mfspr PIE-compliant
 2017-04-10 22:30:56 +02:00
Sepalani
27dcf92faa PPCTables: Do not consider OPTYPE_UNKNOWN as valid instruction 2017-04-10 18:31:24 +01:00
Scott Mansell
e6476b805e Merge pull request #5008 from ligfx/aspectheuristic 
VideoCommon: rework anamorphic widescreen heuristic
 2017-04-10 11:30:34 +12:00
Sepalani
5a1ebe232e HLE: Add Reload() function 2017-04-09 14:02:34 +01:00
Sepalani
20a9c5b12d HLE: Add PatchFixedFunctions() function 2017-04-09 14:02:34 +01:00
Sepalani
61b36d1f9a PatchEngine: Add Reload() function 2017-04-09 14:02:33 +01:00
Matthew Parlane
394b847b6c Merge pull request #5229 from lioncash/si-id 
SI_Devices: Get rid of pointer casts for ID assignment in RunBuffer
 2017-04-09 20:09:44 +12:00
Mat M
59d93f3a0d Merge pull request #5219 from lioncash/common 
FileSearch: Namespace functions under the Common namespace
 2017-04-08 17:19:00 -04:00
Mat M
579b7538e7 Merge pull request #5224 from ligfx/cachedinterpreterhle 
CachedInterpreter: fix HLEFunction argument
 2017-04-08 17:17:28 -04:00
Mat M
ab18eba9de Merge pull request #5105 from lioncash/namespace 
EXI: Namespace device classes
 2017-04-08 17:12:56 -04:00
Mat M
11d1124fa5 Merge pull request #5209 from leoetlino/block-es-diverify 
IOS/ES: Block ES_DIVerify from the IPC interface
 2017-04-08 16:57:40 -04:00
Mat M
d55d9f93a7 Merge pull request #5212 from leoetlino/es-unknown-ioctlvs 
IOS/ES: Return IPC_EINVAL for unknown ioctlvs
 2017-04-08 16:56:50 -04:00
Lioncash
069b70b2b4 SI_Devices: Get rid of pointer casts for ID assignment in RunBuffer 
This is actually undefined behavior (pointer casting to a non-char type and
dereferencing it).
 2017-04-08 16:36:14 -04:00
JosJuice
9d73196e4f Boot: Make default ISO code for DOLs consistent with ELFs 2017-04-08 18:52:39 +02:00
JosJuice
0b78386044 Boot: Allow setting a default ISO for Wii DOLs 
I have no idea why there was a special case preventing this...
 2017-04-08 18:52:33 +02:00
JosJuice
6263830d6d Boot: Always emulate BS2 once when booting a DOL 
The old code could do it 0, 1 or 2 times.
 2017-04-08 18:52:12 +02:00
JosJuice
31eec8c75b Boot: Remove useless check 
No disc is inserted at this point, so IsDiscInside is always false.
 2017-04-08 18:45:01 +02:00
Pierre Bourdon
e7d632d1af Merge pull request #5226 from JosJuice/ir-18n-comments 
Add i18n comments for the acronym IR
 2017-04-08 18:00:12 +02:00
MerryMage
8ad6f2cecc AX: Add support for UCodes without LPF 2017-04-08 16:04:09 +01:00
JosJuice
254df247b1 Add i18n comments for the acronym IR 2017-04-08 16:00:09 +02:00
Michael Maltese
1bd87f5a79 CachedInterpreter: fix HLEFunction argument 2017-04-07 17:54:59 -07:00
Sepalani
eb45ea5f7f Boot: Prevent ELF to be considered as a disc 2017-04-08 00:04:50 +01:00
MerryMage
8f8e7681b2 AX: Implement loop counter 
Required for Rogue Squadron.
 2017-04-07 20:54:34 +01:00
Lioncash
f7a2f6ad01 FileSearch: Namespace functions under the Common namespace 2017-04-07 01:02:14 -04:00
Léo Lam
60d47eaeff IOS/ES: Return IPC_EINVAL for unknown ioctlvs 
Instead of allowing unknown ioctlvs and faking success for both unknown
and unimplemented ioctlvs, which can possibly result in nasty, hard to
debug bugs (if the emulated software behaves unexpectedly), we should
reject unknown ioctlvs and log known, but unimplemented ioctlvs.
 2017-04-06 15:18:23 +02:00
Léo Lam
98dea421ba IOS/ES: Block ES_DIVerify from the IPC interface 
Simple accuracy change.

DIVerify is an internal ioctlv in unpatched, up-to-date IOSes,
where calling it from the PPC just returns -1017.
 2017-04-06 10:38:06 +02:00
Michael Maltese
d10d09ccc1 VideoCommon: rework anamorphic widescreen heuristic 
Some widescreen hacks (see below) properly force anamorphic output, but
don't make the last projection in a frame 16:9, so Dolphin doesn't
display it correctly.

This changes the heuristic code to assume a frame is anamorphic based on
the total number of vertex flushes in 4:3 and 16:9 projections that
frame. It also adds a bit of "aspect ratio inertia" by making it harder
to switch aspect ratios, which takes care of aspect ratio flickering
that some games / widescreen hacks would be susceptible with the new
logic.

I've tested this on SSX Tricky's native anamorphic support, Tom Clancy's
Splinter Cell (it stayed in 4:3 the whole time), and on the following
widescreen hacks for which the heuristic doesn't currently work:

Paper Mario: The Thousand-Year Door (Gecko widescreen code from Nintendont)
C202F310 00000003
3DC08042 3DE03FD8
91EEF6D8 4E800020
60000000 00000000
04199598 4E800020
C200F500 00000004
3DE08082 3DC0402B
61CE12A2 91CFA1BC
60000000 387D015C
60000000 00000000
C200F508 00000004
3DE08082 3DC04063
61CEE8D3 91CFA1BC
60000000 7FC3F378
60000000 00000000

The Simpsons: Hit & Run (AR widescreen code from the wiki)
04004600 C002A604
04004604 C09F0014
04004608 FC002040
0400460C 4082000C
04004610 C002A608
04004614 EC630032
04004618 48220508
04041A5C 38600001
04224344 C002A60C
04224B1C 4BDDFAE4
044786B0 3FAAAAAB
04479F28 3FA33333
 2017-04-05 17:23:16 -07:00
MerryMage
19eb09b086 Jit_SystemRegisters: Make mfspr PIE-compliant 2017-04-05 10:22:48 +01:00
MerryMage
38917a151d CoreTiming: Pull globals into a single struct 2017-04-05 10:22:48 +01:00
Lioncash
14c81764df ControllerEmu: Replace includes with forward declarations 
Replaces includes with forward declarations where applicable, and moves
includes to where they're actually needed.
 2017-04-04 20:38:30 -04:00
Léo Lam
cf0492468d IOS/WFS: Fix logging message 2017-04-04 17:37:08 +02:00
Léo Lam
6f8c30c863 IOS/ES: Fix GetTMDView 
We had missing checks *and* were checking for the out vector size
improperly.

Rewritten based on the actual behaviour in IOS.
 2017-04-04 16:04:24 +02:00
Lioncash
0c1d56c16f Core: Hide determinism global 
This is only ever queried and not set outside of the Core.cpp, so this
should just be hidden internally and just have a function exposed that
allows querying it.
 2017-04-03 14:56:12 -04:00
Lioncash
ad1a899a7c Core: Make EmuThread internally linked 2017-04-03 13:27:35 -04:00
Lioncash
ed2e9e9e41 Core: Remove unnecessary forward declaration 2017-04-03 13:26:15 -04:00
Markus Wick
9d1ae76d0d Merge pull request #5200 from lioncash/frame 
Frame: Remove callback function prototypes from header.
 2017-04-03 13:35:35 +02:00
Lioncash
b67968c3d8 Core: Remove unimplemented function prototype SetBlockStart 2017-04-03 06:34:49 -04:00
Lioncash
c457ee4995 Frame: Remove callback function prototypes from header 
Gets rid of more direct usages of the main_frame global, keeping the
callbacks internal to the frame itself.
 2017-04-03 06:34:36 -04:00
Léo Lam
0dbad29bf4 IOS: Don't expose HLE::Reset() 
This is an implementation detail that does not have to be exposed.

It was used in WII_IPC whenever the IPC gets reset, but that does not
make much sense to me: the only time when IOS loses state and the IPC
registers are set up again is when it's reloaded. And reloading IOS
already calls Reset() indirectly.

Also, an IPC reset from the PPC definitely should not close all opened
devices!

This also gets rid of a special case for clear_devices, which is now
completely unneeded.
 2017-04-02 18:00:32 +02:00
Markus Wick
fd7f7c5541 Merge pull request #5159 from ligfx/arm64warnings 
Arm64: a slew of warning fixes
 2017-04-02 17:07:17 +02:00
Markus Wick
40cfa708a8 Merge pull request #5180 from lioncash/enum 
CPU: Convert state enum to an enum class
 2017-04-02 17:01:25 +02:00
Markus Wick
86e48fc1ca Merge pull request #5194 from lioncash/dialog 
Frame: Make TAS dialogs private
 2017-04-02 16:53:31 +02:00
Léo Lam
64b1a4d308 IOS/IPC: Remove unneeded forward declaration 
CoreTiming.h is already included.
 2017-04-02 12:41:47 +02:00
Lioncash
678905764a Movie/Frame: Amend variable naming 
Amends variable naming related to translation unit locals and TAS input
dialogs that were modified in the previous commit.
 2017-04-02 04:11:58 -04:00
Lioncash
7f0203a5b0 Frame: Make TAS dialogs private 
Amends the TAS callbacks to internally store functions using
std::function instead of raw function pointers. This allows binding
extra contextual state via lambda functions, as well as keeping the
dialogs internal to the main frame (on top of being a more flexible
interface).
 2017-04-02 04:11:47 -04:00
Lioncash
5620f78b5c Core: Amend VS filter tag 2017-04-02 00:30:26 -04:00
Jussi Virtanen
92ad1b9c4d Use pointers inside ini loop to retain references to ini files 2017-04-01 17:52:25 +03:00
Michael Maltese
af63235dc4 Remove libao sound backend 
A single person uses it[0], and it sometimes messes up the Linux
buildbots ("ninja: error: 'ao', needed by 'Binaries/dolphin-emu', missing
and no known rule to make it").

[0]: https://analytics.dolphin-emu.org/stats/popular-audio-backends.txt
 2017-03-31 14:59:57 -07:00
JosJuice
020618a427 Move DVDInterface's pure (stateless) math code to a new file 2017-03-31 17:27:23 +02:00
JosJuice
f106ba70d4 Move DVD code to a new directory 2017-03-31 17:27:23 +02:00
Mat M
6b198679bc Merge pull request #5129 from ligfx/breakpointprintf 
Breakpoints.cpp: fix format string warnings
 2017-03-31 00:13:06 -04:00
Matthew Parlane
de6c9404fc Merge pull request #5182 from leoetlino/ios-enums 
IOS: Move ES return codes
 2017-03-30 14:57:03 +13:00
Lioncash
5637bbd1cf MEGASignatureDB: Remove unused variable in Apply 2017-03-28 16:19:19 -04:00
Lioncash
eec4b705d5 MEGASignatureDB: Move objects where applicable 
Signatures during loading and strings during reference retrieval can be
moved.
 2017-03-28 16:18:31 -04:00
Lioncash
c0171975ea MEGASignatureDB: Move implementation details into the cpp file 
These functions aren't dependent on any database state and can be hidden.
 2017-03-28 15:43:21 -04:00
Anthony
fee2577e25 Merge pull request #5088 from sepalani/mega_signature 
SignatureDB: Support for WiiTools MEGA files added
 2017-03-28 12:28:21 -07:00
Sepalani
4cb84d06f0 SignatureDB: Support for WiiTools MEGA files added 2017-03-28 20:16:09 +01:00
Léo Lam
68cd8fc910 IOS: Move ES return codes 
This keeps all of the return codes in the same place and exposed
publicly (as they are not internal to ES).

I have also added proper IOSC error codes and renamed some codes
for more consistency. (Unix ones have an E prefix, others do not.)
 2017-03-28 20:02:26 +02:00
Anthony
bcb1729dc9 Merge pull request #5124 from leoetlino/more-accurate-import 
IOS/ES: Handle imports more accurately
 2017-03-28 09:20:28 -07:00
Lioncash
8d98ac6509 CPU: Convert state enum to an enum class 
Gets enum constants out of the immediate namespace. Also makes it
strongly typed like the other state enums.
 2017-03-28 11:48:28 -04:00
Matthew Parlane
85d74a506f Merge pull request #4951 from waddlesplash/haiku-2 
Initial support for Haiku.
 2017-03-28 17:19:35 +13:00
Augustin Cavalier
0831dad467 Initial support for Haiku. 2017-03-27 23:46:19 -04:00
Matthew Parlane
8c23888968 Merge pull request #5174 from lioncash/vi 
VideoInterface: Minor changes
 2017-03-28 16:15:59 +13:00
Matthew Parlane
22256d1bd8 Merge pull request #5170 from leoetlino/bt-fix 
libusb fixes (mostly for IOS)
 2017-03-28 13:47:47 +13:00
Matthew Parlane
dc2d11c1a7 Merge pull request #5172 from lioncash/dsp 
DSPIntMultiplier: Place translation unit local functions in an anonymous namespace
 2017-03-27 16:06:39 +13:00
Lioncash
adbffc24e9 VideoInterface: Make clock frequency array constexpr 
This is only ever read from.
 2017-03-26 19:30:44 -04:00
Lioncash
ec5637fe46 VideoInterface: Utilize std::array where applicable 2017-03-26 19:28:56 -04:00
Lioncash
ae29cd042e VideoInterface: Initialize union members directly where applicable 2017-03-26 18:42:09 -04:00
Lioncash
0a7a6142eb GCMemcardDirectory: Move flush interval constant into the cpp file 
This isn't necessary to be within the header.
 2017-03-26 17:55:30 -04:00
Lioncash
a5c5645bed DSPIntMultiplier: Place translation unit local functions in an anonymous namespace 
Unlike inline, this makes the functions internally linked.
 2017-03-26 16:42:35 -04:00
Léo Lam
69705e3a41 IOS/ES: Handle imports more accurately 
A set of small changes to handle title imports more accurately.

* Clean up the import directory after an import, exactly like IOS.
  This should prevent the title directory from having useless leftover
  contents, which could confuse the emulated software.

* More robust failsafe in case an import does not complete normally.
  IOS checks for stale imports and handles them appropriately on boot.
  We now do the same.

* Create all directories as IOS does. This includes the data directory.
 2017-03-26 22:17:31 +02:00
Matthew Parlane
76cece8157 Merge pull request #5115 from leoetlino/proper-location-for-es-stuff 
IOS/ES: Move shared content map, uid.sys code
 2017-03-27 08:53:14 +13:00
Léo Lam
9aaaa2b924 IOS/USB: Unref libusb devices manually 2017-03-26 15:58:30 +02:00
Léo Lam
32a1b5068a Revert "Use a single libusb context" 
This reverts commit c8a6dc6c23.

libusb on Windows isn't really safe to use from different threads
with a single context.
 2017-03-26 15:58:30 +02:00
BhaaL
a9afd5b243 fix incomplete end-tag 2017-03-26 14:44:42 +02:00
Léo Lam
6c62cfb1aa IOS/BTReal: Properly check for libusb failures 2017-03-26 12:22:29 +02:00
Léo Lam
7b17163a7a IOS/ES: Move shared content map, uid.sys code 
These are all specific to ES and belong there.

The SharedContentMap and UIDSys classes were also modernised.
 2017-03-26 12:16:28 +02:00
Léo Lam
3cfd9ea9b2 IOS/BTReal: Always use config descriptor 0 
This may fix LIBUSB_ERROR_NOT_FOUND whenever devices end up being in
an unconfigured state. We don't need anything more than the first
config descriptor anyway.
 2017-03-26 12:08:53 +02:00
Markus Wick
0b6170cc33 Merge pull request #5167 from stenzek/jit64-crash 
Jit64: Fix crash at startup
 2017-03-26 09:17:21 +02:00
Anthony
fbfb94ec79 Merge pull request #5157 from sepalani/sym-name 
Fix wrong address in zz_ symbol name
 2017-03-25 19:38:16 -07:00
Matthew Parlane
5d40daa507 Merge pull request #5123 from ligfx/fixwiimoteemu 
WiimoteEmu: refer to settings by name, not index
 2017-03-26 14:56:44 +13:00
Matthew Parlane
9dd9573ec0 Merge pull request #5148 from ligfx/iptopwarning 
IP/Top: rename private methods à la HandleXRequest
 2017-03-26 14:54:31 +13:00
Stenzek
724a8437eb Jit64: Fix crash at startup 
This was a regression introduced by 4d8d045. stored_stack_pointer within
PPCSTATE was being accessed before the PPCSTATE (RBP) register was
initialized.
 2017-03-26 11:37:55 +10:00
Markus Wick
86e6b44271 Merge pull request #5146 from ligfx/mmuwarning 
MMU: rewrite loop to avoid warning
 2017-03-25 23:18:56 +01:00
Michael Maltese
9afe3946d1 JitArm64_Integer: fix signedness comparison warning 
Fixes warning:

```
dolphin/Source/Core/Core/PowerPC/JitArm64/JitArm64_Integer.cpp:1139:64: warning: comparison of integers of different signs: 'u32' (aka 'unsigned int') and 'int' [-Wsign-compare]
  else if (gpr.IsImm(b) && gpr.GetImm(b) != 0 && gpr.GetImm(b) != -1)
                                                 ~~~~~~~~~~~~~ ^  ~~
```
 2017-03-25 14:51:10 -07:00
Michael Maltese
428bac6e32 JitArm64_Integer: remove unused imm_neg 2017-03-25 14:51:10 -07:00
Michael Maltese
5892ef1792 JitArm64_Integer: extract bit operation lambdas 
Fixes warnings like:

```
dolphin/Source/Core/Core/PowerPC/JitArm64/JitArm64_Integer.cpp:132:37: warning: declaration shadows a local variable [-Wshadow]
    reg_imm(a, s, inst.UIMM, [](u32 a, u32 b) { return a | b; }, &ARM64XEmitter::ORRI2R);
                                    ^
/Users/michaelmaltese/Downloads/dolphin/Source/Core/Core/PowerPC/JitArm64/JitArm64_Integer.cpp:122:7: note: previous declaration is here
  u32 a = inst.RA, s = inst.RS;
      ^
```
 2017-03-25 14:51:09 -07:00
Michael Maltese
c58ba93503 Arm64: Use PRIi64/PRIx64 for printf 2017-03-25 14:20:44 -07:00
Markus Wick
4d8d0451e3 Merge pull request #5142 from MerryMage/stored_stack_pointer 
JitAsm: Use stored_stack_pointer instead of s_saved_rsp
 2017-03-25 17:37:48 +01:00
Markus Wick
3898707ef9 Merge pull request #5141 from MerryMage/ConvertDoubleToSingle 
EmuCodeBlock: Place ConvertDoubleToSingle temporaries on the stack
 2017-03-25 17:37:29 +01:00
Sepalani
6eca605284 Fix wrong address in zz_ symbol name 2017-03-25 01:21:13 +00:00
JosJuice
f5469878ba DVDInterface: Update comment about buffer speed 
The actual code was changed based on mmastrac's hardware
tests, but it seems like we forgot to edit this comment.
 2017-03-24 20:04:26 +01:00
Michael Maltese
a098fe57c5 IP/Top: rename private methods à la HandleXRequest 
Fixes this warning everytime Top.h is included:

```
../Source/Core/Core/IOS/Network/IP/Top.h:76:20: warning: 'IOS::HLE::Device::NetIPTop::Close' hides overloaded virtual function [-Woverloaded-virtual]
  IPCCommandResult Close(const IOCtlRequest& request);
                   ^
../Source/Core/Core/IOS/Device.h:158:16: note: hidden overloaded virtual function 'IOS::HLE::Device::Device::Close' declared here: different number of parameters (0 vs 1)
  virtual void Close();
               ^
```
 2017-03-24 11:52:39 -07:00
Michael Maltese
8387b00f42 MMU: rewrite loop to avoid warning 
Fixes warning:

```
dolphin/Source/Core/Core/PowerPC/MMU.cpp:278:43: warning: shift count >= width of type [-Wshift-count-overflow]
           addr++, addr_translated++, val >>= 8)
```
 2017-03-24 11:45:21 -07:00
MerryMage
61198199cd JitAsm: Use stored_stack_pointer instead of s_saved_rsp 2017-03-24 11:31:40 +00:00
MerryMage
918d7fa3d1 EmuCodeBlock: Place ConvertDoubleToSingle temporaries on the stack 2017-03-24 10:59:55 +00:00
Lioncash
1d6d85963f ARDecrypt: const correctness 2017-03-22 20:35:00 -04:00
Markus Wick
9ea59133b3 Merge pull request #5121 from MerryMage/children-happen 
Jit64: Merge memory allocations into a single allocation
 2017-03-22 22:42:46 +01:00
Matthew Parlane
8804f759b9 Merge pull request #5127 from lioncash/gcode 
GeckoCodeConfig: Minor changes
 2017-03-23 07:13:45 +13:00
Markus Wick
09f4d494ef Merge pull request #5132 from ligfx/commentoutpagetagshift 
MMU: comment-out unused var HW_PAGE_TAG_SHIFT
 2017-03-22 09:43:45 +01:00
Michael Maltese
da6a1daef6 MMU: remove unused var HW_PAGE_TAG_SHIFT 
It's not used, so produces a warning during compilation.
 2017-03-21 23:47:10 -07:00
Michael Maltese
9e430cbdd6 Breakpoints.cpp: fix format string warnings 
Fixes warnings:

```
dolphin/Source/Core/Core/PowerPC/BreakPoints.cpp:246:89: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
                 debug_interface->GetDescription(pc).c_str(), write ? "Write" : "Read", size * 8,
                                                                                        ^~~~~~~~
dolphin/Source/Core/Core/PowerPC/BreakPoints.cpp:245:50: warning: field width should have type 'int', but argument has type 'unsigned long' [-Wformat]
      NOTICE_LOG(MEMMAP, "MBP %08x (%s) %s%zu %0*x at %08x (%s)", pc,
                                              ~~~^
```
 2017-03-21 23:25:17 -07:00
Lioncash
2f52d04e30 GeckoCodeConfig: Use compare instead of substr for comparing substrings 
Gets rid of an unnecessary string construction.
 2017-03-21 18:12:40 -04:00
Lioncash
0d0e9f626d GeckoCodeConfig: Amend unnecessary string literals to char literals 
Also gets rid of an unnecessary std::string construction in a loop.
std::string already has an operator+ overload to prepend characters.
 2017-03-21 18:03:06 -04:00
Lioncash
28235b5cb6 GeckoCodeConfig: Remove unused commented out code 2017-03-21 18:03:06 -04:00
Lioncash
f0fa692457 GeckoCodeConfig: Move gecko code title building to its own function 
Keeps it separate from the rest of the saving code and also allows for
easy rvalue-reference moving into the lines vector as a side-benefit.
 2017-03-21 18:03:02 -04:00
Lioncash
f91292eff2 GeckoCodeConfig: Return vector by value for LoadCodes() 
Using an out-param is a leftover from C++03. Action Replay codes already
return the vector of codes by value as well.
 2017-03-21 16:58:13 -04:00
Michael Maltese
7c52b8f838 WiimoteEmu: refer to settings by name, not index 
Fixes https://bugs.dolphin-emu.org/issues/10159 "Emulated Wii remote
options not working correctly," which was introduced by PR #4856: "Move
'Background Input' out of individual controller configurations."
 2017-03-21 13:31:42 -07:00
MerryMage
cb7d9556bf Jit64: Merge memory allocations into a single allocation 
Instead of each component allocating their own memory, we instead allocate
the memory once and divvy that up among the components as required. This
ensures that relative memory offsets remain within architecture limits.
 2017-03-21 20:16:12 +00:00
MerryMage
da434e1a1c ConstantPool: Externalize memory allocation 2017-03-21 20:16:12 +00:00
Lioncash
780dffcb13 FifoDataFile: In-class initialize member variables where applicable 2017-03-21 15:41:05 -04:00
Lioncash
4e5e7cff0a FifoRecorder: In-class initialize member variables where applicable 2017-03-21 15:41:05 -04:00
Lioncash
eda27ee397 FifoPlayer: In-class initialize member variables where applicable 2017-03-21 15:40:56 -04:00
Lioncash
0d1bc53e55 JitBase: Rename MergeAllowedNextInstructions to CanMergeNextInstructions 
This is more indicative that it's checking for something
 2017-03-21 13:50:03 -04:00
Lioncash
f98211bfcf JitBase: Make MergeAllowedNextInstructions a const member function 2017-03-21 13:45:18 -04:00
Markus Wick
f03fa54bcb Merge pull request #5116 from degasus/ArmRegCache 
JitArm64: Fix usages in conditional code.
 2017-03-21 18:14:16 +01:00
MerryMage
8a788ebdd9 JitAsm: Add missing forward declaration of X64CodeBlock 2017-03-21 16:56:43 +00:00
Anthony
d2690568f9 Merge pull request #5110 from MerryMage/const-pool 
Jit64: Implement a constant pool
 2017-03-20 13:29:57 -07:00
MerryMage
4491e9b829 Jit_SystemRegisters: Add missing sizes to constant arrays 2017-03-20 20:21:43 +00:00
MerryMage
9058ccea3f IR_X86: Use MConst for constants 2017-03-20 20:21:43 +00:00
MerryMage
3dccc369d3 Jit64AsmCommon: Use MConst for constants 2017-03-20 20:21:43 +00:00
MerryMage
4814c4ac5a EmuCodeBlock: Use MConst for constants 2017-03-20 20:21:43 +00:00
MerryMage
8b93baefb7 Jit_SystemRegisters: Use MConst for constants 2017-03-20 20:21:43 +00:00
MerryMage
0fe234ec9b Jit_FloatingPoint: Use MConst for constants 2017-03-20 20:21:42 +00:00
MerryMage
ff441efc26 EmuCodeBlock: Use ConstantPool 2017-03-20 20:21:42 +00:00
MerryMage
9951961338 ConstantPool: Implement a constant pool 
Constants are copied into this pool so that they live at a memory
location that is close to the code that references it. The pool allocates
memory from a provided X64CodeBlock to use.

The purpose of the pool is to overcome the 32-bit offset limitation that
RIP-relative addressing has.`
 2017-03-20 20:21:42 +00:00
MerryMage
b0d6c29073 JitAsmCommon: Add missing sizes to constant arrays 
This allows generic code to determine the size of these arrays.
 2017-03-20 20:21:41 +00:00
degasus
c5b9c740c9 JitArm64: Fix gpr.R() usages in conditional code. 2017-03-20 21:18:13 +01:00
degasus
f7a52c0c35 JitArm64: Fix gpr.GetReg usages in conditional code. 2017-03-20 21:18:13 +01:00
Anthony
26bb26fe54 Merge pull request #4901 from JosJuice/filemonitor-redesign 
FileMonitor redesign
 2017-03-20 12:46:19 -07:00
Anthony
50faffc9c2 Merge pull request #5009 from aldelaro5/memcheck-fix 
Fix memory breakpoint when checking the middle of the data
 2017-03-20 12:41:02 -07:00
Anthony
b35bbdfb58 Merge pull request #4856 from ligfx/backgroundinput 
Move "Background Input" out of individual controller configurations
 2017-03-19 22:31:30 -07:00
Matthew Parlane
8eb26d298e Merge pull request #5099 from JosJuice/wii-menu-strings 
Display nicer version strings for the Wii Menu
 2017-03-20 14:03:04 +13:00
Matthew Parlane
9da35edd15 Merge pull request #5093 from JosJuice/six-char-game-ids 
Use 6-char game IDs for NAND tiles (if they are printable)
 2017-03-20 13:38:35 +13:00
Matthew Parlane
910360f7e7 Merge pull request #5085 from leoetlino/es-nandutils 
IOS: Add NandUtils
 2017-03-20 13:27:17 +13:00
Matthew Parlane
a20b73cfb4 Merge pull request #5112 from MerryMage/quantize 
Jit64AsmCommon: Use correct quantization table
 2017-03-20 13:26:38 +13:00
MerryMage
5f59755d15 Jit64AsmCommon: Use correct quantization table 
Stores quantize, loads dequantize.
 2017-03-19 14:49:24 +00:00
Lioncash
35c230a418 NetPlayServer: const correctness 2017-03-19 09:36:40 -04:00
Lioncash
025eac9062 NetPlayClient: const correctness 2017-03-19 09:32:58 -04:00
Léo Lam
98e27ad9cb IOS/ES: Use FindInstalledTMD instead of content loader 
Proper semantics.

IOS only cares about the TMD and nothing else, so we should use
FindInstalledTMD, instead of reading/parsing/decrypting a bunch of
useless stuff, which is slow *and* causes issues because of the cache.
 2017-03-19 11:27:34 +01:00
Léo Lam
8984112501 IOS/ES: Move GetStoredContentsFromTMD to NandUtils 2017-03-19 11:10:45 +01:00
Léo Lam
0ed8d68192 IOS/ES: Add functions to get TMDs 2017-03-19 11:10:45 +01:00
Léo Lam
194b0ae36d IOS: Add NandUtils 
This keeps the ES specific NAND code in a single place and makes it
reusable. Eventually, other ES specific code will be moved to it.
 2017-03-19 11:10:45 +01:00
Anthony
9604a06921 Merge pull request #5102 from leoetlino/channel-title-type 
Check whether WAD is a channel before reading names
 2017-03-18 23:30:27 -07:00
Matthew Parlane
cb87b25ac6 Merge pull request #5106 from lioncash/constant 
Memmap: Replace '0' constant with nullptr
 2017-03-19 16:42:36 +13:00
Matthew Parlane
036d676230 Merge pull request #5107 from lioncash/unused 
ES: Remove unused string format argument in LaunchPPCTitle
 2017-03-19 16:41:28 +13:00
Lioncash
8e999b209a NetPlayClient: Eliminate variable shadowing 
Gets rid of two -Wshadow warnings
 2017-03-18 22:58:07 -04:00
aldelaro5
8bf27cf42f Fix memory breakpoint when checking the middle of the data 
If the delimiters of a memory aren't exactly the same as an address, but their size includes the memory breakpoint delimiter, the break will not go through.  This makes it so that you can specify a search for a memory breakpoint with a data size and will check if the data fits with that size on all memory breakpoints so the breaks go through.
 2017-03-18 22:48:57 -04:00
Lioncash
3404057732 ES: Remove unused string format argument in LaunchPPCTitle 
Gets rid of a -Wformat-extra-args warning.
 2017-03-18 22:44:46 -04:00
Lioncash
2b8abddadf Memmap: Replace '0' constant with nullptr 2017-03-18 22:35:35 -04:00
Lioncash
44fb429e7e EXI: Namespace device classes 2017-03-18 21:13:12 -04:00
Léo Lam
c987f58319 Check whether WAD is a channel before reading names 
Dolphin assumes that content 0 is opening.bnr, without checking
whether content 0 exists or if it is even supposed to be there (it's
only there for channels). This results in sometimes reading garbage.

This adds a check to only try to read names from content 0's header
if the title is a channel (channel, system channel or game channel).
 2017-03-18 19:07:11 +01:00
Matthew Parlane
ce034a8186 Merge pull request #5101 from JosJuice/es-launch-wii-menu 
Display a different error message when failing to ES_Launch the Wii Menu
 2017-03-19 01:00:59 +13:00
JosJuice
998a215a0d Display a different error message when failing to ES_Launch the Wii Menu 
Trying to return to the Wii Menu from a game is the easiest
way to trigger this error. Just saying 0000000100000002
when that happens doesn't mean much to most users.
 2017-03-18 12:13:17 +01:00
JosJuice
9d54e4a9de Return a more meaningful type from GetSysMenuRegion 2017-03-18 10:13:36 +01:00
Matthew Parlane
8669426b0b Merge pull request #5092 from lioncash/namespace 
SI: Namespace device classes
 2017-03-18 19:30:38 +13:00
Markus Wick
b7f605e88e Merge pull request #5097 from MerryMage/pic 
PIE support for the DSP JIT
 2017-03-17 22:24:03 +01:00
MerryMage
5e7d01dea4 DSPJitRegCache: Remove ebp_store 
Restoring RBP before function calls is a no-op.
 2017-03-17 17:10:25 +00:00
MerryMage
14739c55c3 DSP/Jit: PIE support 2017-03-17 17:10:24 +00:00
Markus Wick
b7ba391041 Merge pull request #5084 from MerryMage/Update_SR_Register 
DSP/Jit: Explicitly specify scratch register for Update_SR_Register
 2017-03-17 17:21:21 +01:00
Matthew Parlane
47fe78a76a Merge pull request #5094 from lioncash/magic 
SI: Convert SI buffer from a C array to std::array
 2017-03-17 20:49:26 +13:00
Markus Wick
a0acdfc070 Merge pull request #5029 from ligfx/bboximagemask 
OGL: implement Bounding Box on systems w/o SSBO
 2017-03-16 21:39:17 +01:00
aldelaro5
4738e3195c Fix memory breakpoints not triggering on Windows 
For some reasons, they worked on Linux even though it was incorrect, this commit does it correctly and so it fixes that on Windows.
 2017-03-16 16:31:20 -04:00
BhaaL
1470c346b6 change parameter names to match our coding style while we're at it 2017-03-16 18:22:51 +01:00
BhaaL
d0d91f2530 add the hash for the PAL v1.1 BIOS 
reported on the forums by user hackintoshftw1
 2017-03-16 18:22:51 +01:00
BhaaL
70a25bef4c put the source reference onto its own line to avoid the awkward formatting 
also, make them constexpr, because i guess it makes sense...
 2017-03-16 18:22:51 +01:00
Markus Wick
907e73a1fc Merge pull request #5012 from degasus/BAT 
MMU: Create constants for our BAT flags.
 2017-03-16 16:02:16 +01:00
JosJuice
ff7425214a Use 6-char game IDs for NAND tiles (if they are printable) 
5.0-2712 made ES's code for setting the game ID use the
title ID converted to hex (except for disc titles) instead
of using a 6-char game ID like before. Then, 5.0-2830 made
us use that code even when loading game INIs. This breaks the
expectations of both users and the game INIs we ship with.

This commit makes Dolphin use 6-char game IDs for all
titles (unless the 6-char ID would contain unprintable
characters, which is the case with e.g. the Wii Menu).

I'm also putting unprintability checks in VolumeWad
for consistency.
 2017-03-16 11:21:31 +01:00
Lioncash
6cf3c2262c SI: Convert SI buffer from a C array to std::array 
Stronger typing (no implicit pointer decay), nicer aggregate
initialization.

Also gets rid of magic constants where applicable.
 2017-03-16 05:37:03 -04:00
Markus Wick
bb708397db Merge pull request #5090 from lioncash/si 
SI: Minor cleanup
 2017-03-16 09:57:04 +01:00
Lioncash
f0eeb3c63a SI: Namespace device classes 
Places all of the SI code under the SerialInterface namespace instead of
only the main source file. This keeps all SI code under a common name,
as well as out of the global namespace
 2017-03-16 04:41:39 -04:00
Lioncash
9c3b35fccb EXI: Move enum constants into the ExpansionInterface namespace 
Given these are related to EXI itself, these should be within the
namespace itself.
 2017-03-16 02:06:29 -04:00
Lioncash
a728d858b3 SI: Move MAX_SI_CHANNELS into the SerialInterface namespace 
Given this constant is related to the serial interface, it shouldn't be
outside of the namespace.
 2017-03-16 01:57:57 -04:00
Lioncash
46991e2bdd SI: Amend variable naming 2017-03-16 01:37:50 -04:00
Michael Maltese
de940a5fd6 VideoConfig: add bSupportsFragmentStoresAndAtomics 2017-03-15 17:20:47 -07:00
Anthony
8e6d256722 Merge pull request #5080 from leoetlino/ssl-verify 
Default to SSL verify on
 2017-03-15 13:56:56 -07:00
Markus Wick
1e7dd1ed2d Merge pull request #5086 from lioncash/si 
SI_Devices: Minor cleanup
 2017-03-15 10:07:27 +01:00
degasus
5152c997a4 MMU: Create constants for our BAT flags. 
This avoids a few hard-coded constants in several files.
 2017-03-15 09:20:40 +01:00
Lioncash
4df8ac7820 GCMemcardRaw: Amend variable naming 2017-03-15 00:16:45 -04:00
Lioncash
79246d9642 GCMemcardDirectory: Amend variable naming 2017-03-14 23:58:31 -04:00
Lioncash
647bec4c17 GCMemcard: Amend variable naming for MemoryCardBase 2017-03-14 23:58:27 -04:00
Lioncash
09d4871067 GCMemcard: Move memcard source files to their own directory 
GCMemcard.h has quite a bit of different classes implemented within it
that could likely be split up into other files to make it a little
easier to read. However, they should be moved into their own folder
first so that they don't clutter up the base HW directory.
 2017-03-14 21:55:25 -04:00
Lioncash
8b8a1f3b35 SI_DeviceKeyboard: Amend variable naming 2017-03-14 18:15:25 -04:00
Lioncash
4478b9bc9a SI_DeviceKeyboard: In-class initialize variables 2017-03-14 18:03:36 -04:00
Lioncash
c45f8e2e3c SI_DeviceGCSteeringWheel: Amend variable naming 2017-03-14 17:54:18 -04:00
Lioncash
89f5b3b5d9 SI_DeviceGCAdapter: Amend variable naming 2017-03-14 17:47:56 -04:00
Lioncash
e68e99ef71 SI_DeviceDanceMat: Amend variable naming 2017-03-14 17:46:09 -04:00
Léo Lam
834a3bf857 Default to SSL verify on 
Defaulting to SSL verification off, *and* forcing it to be off even
when the emulated software asks us to enable it is very bad behaviour,
inaccurate and insecure.

Because the old option defaulted to off, we have to change the INI
option name to force the new default to be used. Unfortunate,
but without this we cannot ensure our users' security.
 2017-03-14 20:57:49 +01:00
MerryMage
1020a3cb8e DSP/Jit: Explicitly specify scratch register for Update_SR_Register 
There were cases when the value register was RDX and thus was being
clobbered as RDX was implictly used as a scratch register.
 2017-03-14 19:18:56 +00:00
Markus Wick
3aa5b8fbf6 Merge pull request #5079 from JosJuice/move-loadpatches 
Move LoadPatches calls
 2017-03-14 10:44:38 +01:00
Markus Wick
884d3973e4 Merge pull request #5083 from lioncash/si 
SI_DeviceGCController: Minor cleanup
 2017-03-14 10:37:28 +01:00
Markus Wick
d05f59e31d Merge pull request #4876 from ligfx/netplay_move_semantics 
NetPlay: use move semantics instead of unique_ptrs
 2017-03-14 10:20:47 +01:00
Lioncash
46fd06b956 SI_DeviceGCController: Amend variable names 2017-03-14 05:15:48 -04:00
Lioncash
890f799fdd SI_DeviceGCController: In-class initialize variables 2017-03-14 03:34:52 -04:00
Jules Blok
0a2b58c896 OGL: Remove support for NV_depth_buffer_float. 
We can't clamp the depth values to the 24-bit range while this extension is active.
 2017-03-14 01:02:13 +01:00
Lioncash
225ac37f21 SDIOSlot0: Separate IOCtl/IOCtlV behavior into individual functions 
Keeps the individual behaviors separate from one another.
 2017-03-13 18:43:04 -04:00
JosJuice
09682cfaa4 Move LoadPatches calls 
LoadPatches was apparently never being called when booting
Wii discs. Maybe this will fix the recent regression with
cheat codes not getting loaded? I don't know how this
managed to work to begin with, though...

(The call was also moved for WADs, just for consistency.)
 2017-03-13 22:29:55 +01:00
Michael Maltese
24a5411af5 Move 'Background Input' to controller config dialog 2017-03-13 13:43:20 -07:00
Michael Maltese
8adad0729e Implement hotkey options group in HotkeyInputConfigDiag 2017-03-13 13:39:52 -07:00
Markus Wick
f0c2bae778 Merge pull request #5078 from lioncash/si 
SI_DeviceGBA: Minor cleanup
 2017-03-13 21:00:36 +01:00
Markus Wick
13d23c21b7 Merge pull request #5071 from leoetlino/reorganise-es 
IOS/ES: Split the ES code
 2017-03-13 20:51:22 +01:00
Markus Wick
3df19c6643 Merge pull request #5075 from lioncash/cruft 
DSPLLE: Remove commented out code
 2017-03-13 20:47:27 +01:00
Lioncash
deda29d7ff SI_DeviceGBA: Amend printf formatting specifier for size_t 
%zu is the correct specifier for printing size_t.
 2017-03-13 15:28:07 -04:00
Lioncash
8d2078de2d SI_DeviceGBA: Amend variable naming 2017-03-13 15:27:36 -04:00