Retropex/dolphin
1
0
Fork 0
mirror of https://github.com/Retropex/dolphin.git synced 2025-05-28 04:52:35 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
a4ec3ddef1
dolphin/Source/Core/Core
History
Léo Lam a4ec3ddef1 Don't switch to blank NAND in the middle of emulation 
Switching to blank NAND when emulation is running is an extremely bad
idea. It's akin to opening up a Wii and replacing the NAND chip while
you're playing a game on it.

Except we're not even replacing it with a NAND that has the same
contents. The blank NAND has nothing in it except the save file for
the current game, which is likely to result in the emulated software
getting inconsistent results and possibly even crashing depending on
how it caches title information.

An example of games that check the saves for other games is
Mario Kart Wii -- it checks the filesystem for Super Mario Galaxy saves
to decide whether to unlock characters. With this 'switch NAND
while emulation is active' misfeature, this will likely break.
And that's the main problem: it encourages sloppy emulation and no one
really knows how many things it can break.

Just don't let the user do horrible things like that during emulation.
If they want to use a blank NAND, they can do so by starting input
recording before launching a game. It's likely they will want to do
this if they plan to share their DTM anyway.
2018-05-29 15:41:11 +02:00
..
Boot CDUtils: Amend function names 2018-05-27 18:48:09 -04:00
Config Port FS, SD and dump path to onion config 2018-05-23 16:07:18 +02:00
ConfigLoaders Config: Fix path settings not being saved 2018-05-27 21:03:01 +02:00
Debugger SymbolDB: Namespace code under the Common namespace 2018-05-27 18:01:40 -04:00
DSP Common/Hash: Namespace code under the Common namespace 2018-05-16 15:39:23 -04:00
FifoPlayer Common: Move host communication enum to Host.h 2018-05-28 14:34:59 -04:00
HLE Common: Move host communication enum to Host.h 2018-05-28 14:34:59 -04:00
HW Merge pull request #7000 from lioncash/wii-extension 2018-05-28 12:39:01 +02:00
IOS Move ECCSignature to Common::ec and give it a less confusing name 2018-05-27 14:01:38 +02:00
PowerPC Merge pull request #6993 from lioncash/nan 2018-05-28 18:49:13 +02:00
ActionReplay.cpp PowerPC: Move MMU-specifics from PowerPC.h to MMU.h 2018-05-17 19:18:55 -04:00
ActionReplay.h CheatManager/ISOProperties: Refactor ActionReplay tabs as a class 2016-08-31 14:32:12 +10:00
Analytics.cpp Implement "Skip" ubershader mode 2018-03-26 01:57:41 +10:00
Analytics.h ControllerEmu: Separate ControlGroup from ControllerEmu 2017-02-09 18:18:52 -05:00
ARDecrypt.cpp CommonFuncs: Generify rotation functions and move them to BitUtils.h 2018-03-31 18:09:45 -04:00
ARDecrypt.h Common: Move byte swapping utilities into their own header 2017-03-03 17:18:18 -05:00
BootManager.cpp Remove useless BootManager::Stop 2018-05-26 11:33:13 +02:00
BootManager.h Remove useless BootManager::Stop 2018-05-26 11:33:13 +02:00
CMakeLists.txt Rename CWiiSaveCrypted to WiiSave 2018-05-13 17:42:55 +02:00
CommonTitles.h CommonTitles: Add a named constant for IOS TIDs 2017-10-24 11:41:55 +02:00
ConfigManager.cpp AudioCommon: Implement WASAPI 2018-05-26 13:08:10 +02:00
ConfigManager.h AudioCommon: Implement WASAPI 2018-05-26 13:08:10 +02:00
Core.cpp Don't switch to blank NAND in the middle of emulation 2018-05-29 15:41:11 +02:00
Core.h Common: Move host communication enum to Host.h 2018-05-28 14:34:59 -04:00
Core.vcxproj Interpreter: Move common exception functions to ExceptionUtils.h 2018-05-20 18:25:32 -04:00
Core.vcxproj.filters Interpreter: Move common exception functions to ExceptionUtils.h 2018-05-20 18:25:32 -04:00
CoreTiming.cpp Reformat all the things! 2018-04-12 21:28:39 +02:00
CoreTiming.h JitArm64: Implement timer SPRs 2017-04-25 09:20:09 +01:00
DSPEmulator.cpp DSPEmulator: Default destructor in the cpp file 2018-05-29 07:54:39 -04:00
DSPEmulator.h DSPEmulator: Default destructor in the cpp file 2018-05-29 07:54:39 -04:00
GeckoCode.cpp PowerPC: Move MMU-specifics from PowerPC.h to MMU.h 2018-05-17 19:18:55 -04:00
GeckoCode.h GeckoCode: Provide operator== and operator!= overloads 2016-10-03 02:32:43 -04:00
GeckoCodeConfig.cpp Core/GeckoCodeConfig: Circumvent DDOS protection 2018-05-29 03:56:28 +02:00
GeckoCodeConfig.h Move GeckoCodeDiag download logic to GeckoCodeConfig 2017-04-05 12:48:35 -07:00
Host.h Common: Move host communication enum to Host.h 2018-05-28 14:34:59 -04:00
HotkeyManager.cpp ControllerEmu: Use enum instead of bool for translatability 2018-04-13 13:04:26 +02:00
HotkeyManager.h Add 'immediate xfb' which reduces xfb latency at the cost of graphical errors 2017-11-17 22:11:30 -06:00
MachineContext.h Initial support for Haiku. 2017-03-27 23:46:19 -04:00
MemoryWatcher.cpp Don't use wrong encoding for paths when opening streams on Windows 2017-12-05 21:23:35 +01:00
MemoryWatcher.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
MemTools.cpp Common/MemTools: Make handler function internally linked on Windows 2018-04-28 12:55:38 -04:00
MemTools.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
Movie.cpp Common/Hash: Namespace code under the Common namespace 2018-05-16 15:39:23 -04:00
Movie.h Movie: Replace some C style arrays with std::array 2018-05-05 23:40:23 +02:00
NetPlayClient.cpp Qt/NetPlayDialog: Improve player list 2018-05-12 18:25:38 +02:00
NetPlayClient.h Qt/NetPlayDialog: Improve player list 2018-05-12 18:25:38 +02:00
NetPlayProto.h NetPlayClient/Server: apply Parameter Object pattern to traversal parameters 2017-08-13 18:50:52 -07:00
NetPlayServer.cpp TraversalClient: Make data externally read-only members private 2018-04-16 16:46:44 -04:00
NetPlayServer.h Add Quality of Service (QoS) support 2018-03-09 00:11:18 +01:00
PatchEngine.cpp PowerPC: Move MMU-specifics from PowerPC.h to MMU.h 2018-05-17 19:18:55 -04:00
PatchEngine.h PatchEngine: Make PatchType an enum class 2018-05-13 15:46:51 -04:00
State.cpp IOSC: Fix hardcoded MS and CA IDs 2018-05-21 15:11:25 +02:00
State.h State: Remove unused Verify functions 2018-03-16 22:56:54 +01:00
SysConf.cpp Move all UID constants to a single file 2018-05-09 21:08:24 +02:00
SysConf.h Move SysConf to Core 2018-04-12 22:16:37 +02:00
TitleDatabase.cpp DiscIO: Don't use all uppercase for enum values 2018-03-31 14:11:32 +02:00
TitleDatabase.h When NAND is damaged, show title names from save files 2017-11-03 23:17:36 +01:00
WiiRoot.cpp WiiRoot: Copy initial NAND files with proper metadata 2018-05-12 22:54:34 +02:00
WiiRoot.h WiiRoot: Move content manipulation to separate functions 2018-05-12 17:06:31 +02:00
WiiUtils.cpp WiiUtils: Migrate to new filesystem interface 2018-05-05 19:21:56 +02:00
WiiUtils.h Unify ISOFile (wx) with GameFile (Qt) and put it in UICommon 2018-03-09 13:08:38 +01:00