Retropex/dolphin
1
0
Fork 0
mirror of https://github.com/Retropex/dolphin.git synced 2025-08-05 22:44:49 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
22,941 Commits 11 Branches 32 Tags 698 MiB
6f272b3a4c
Commit Graph

7696 Commits

Author SHA1 Message Date
JosJuice
e4d20647d4 Merge pull request #4824 from lioncash/coremode 
PowerPC: Convert CoreMode enum into an enum class
 2017-02-05 08:25:12 +01:00
Florent Castelli
9ebfaa9324 AudioCommon: Move logic for default sound backend there from ConfigManager 
This way, we don't have to leak the HAVE_ALSA define there.
 2017-02-05 02:55:04 +01:00
Lioncash
f7b9db9846 PowerPC: Convert CoreMode enum into an enum class 
Prevents constants from polluting the namespace.
 2017-02-04 19:34:56 -05:00
Lioncash
4b091f5872 MMU: Use references to TLBEntry instances instead of pointers 
Same behavior, less verbosity.
 2017-02-04 19:03:22 -05:00
Lioncash
52b45a3933 PowerPC: Rename tlb_entry struct to TLBEntry 
Makes it consistent with our naming style.
 2017-02-04 18:58:45 -05:00
Markus Wick
3be364073d Merge pull request #4713 from JosJuice/core-init-gameini 
Don't load game INIs in Core::Init
 2017-02-04 08:32:03 +01:00
Markus Wick
2ad62bf5df Merge pull request #4777 from lioncash/dspstack 
DSPCore: Convert DSP stack register enum into an enum class
 2017-02-04 08:27:11 +01:00
Sepalani
e280f5615a Handle another case with HLE_GeneralDebugPrint 2017-02-03 23:30:37 +00:00
Matthew Parlane
e2b0197ff6 Merge pull request #4807 from leoetlino/ios-version-for-wads 
Remove unneeded write to 0x3140/0x3188 for WADs
 2017-02-04 10:08:29 +13:00
JosJuice
edcf6819e2 Don't load game INIs in Core::Init 
The game INIs are already loaded in BootManager::BootCore,
which is executed right before. Let's put the g_aspect_wide
code there instead.
 2017-02-03 21:56:45 +01:00
JosJuice
c847a5258f BootManager: Use local SConfig reference when possible 2017-02-03 21:55:02 +01:00
JosJuice
e572fb102f Move ES_DIVerify's Movie-related code to a more logical place 2017-02-03 19:53:35 +01:00
JosJuice
6aa41ebc55 Movie: Put Wii s_bClearSave handling in a more logical place 2017-02-03 19:53:23 +01:00
JosJuice
88e0a5e418 Don't call Movie::SetTitleId from ES 
Movie basically just wants to get the title ID of
the initally booted game, so let's set the title ID in
ConfigManager at boot like we do with the regular game ID.

Aside from being cleaner, this should make the approach to
title IDs compatible with booting non-disc software (WADs).
 2017-02-03 19:52:25 +01:00
Lioncash
c67d095787 PowerPC: Move page #define constants to MMU.cpp 
These are only ever used here.

This also converts them into typed constants.
 2017-02-03 11:48:42 -05:00
Léo Lam
767cbcafb1 Remove unneeded write to 0x3140/0x3188 for WADs 
This is unnecessary now that IOS::HLE is responsible for writing the
values to memory; removing the writes also prevents the IOS minor
version from being mangled (by the write to 0x3142).
 2017-02-02 22:05:36 +01:00
degasus
384efb0cb2 JitArm64: Initial implementation of the BLR optimization. 2017-02-02 09:06:34 +01:00
Markus Wick
f558ae4dd1 Merge pull request #4790 from lioncash/sram 
Sram: Make SRAM dumps const
 2017-02-01 13:27:03 +01:00
Markus Wick
094a75f3cb Merge pull request #4791 from degasus/temp 
DSPLLE: Only enable the DSP JIT on x64.
 2017-02-01 13:04:18 +01:00
Mat M
6fd0e96ea3 Merge pull request #4785 from lioncash/ios-fs 
IOS FS: Move behavior to separate functions
 2017-01-31 22:28:42 -05:00
Mat M
84d81a4b7a Merge pull request #4792 from sepalani/fix_isctype_assert 
Fixes std::isprint undefined behavior
 2017-01-31 21:53:12 -05:00
Sepalani
44196f6a55 Fixes std::isprint undefined behavior 2017-02-01 02:30:29 +00:00
Mat M
5b782b9f2d Merge pull request #4795 from sepalani/fix_sock 
Fixes a crash when closing a socket
 2017-01-31 20:30:26 -05:00
Sepalani
3fd08b6cee Fixes a crash when closing a socket 2017-02-01 00:11:19 +00:00
Markus Wick
24951fde2b Merge pull request #4793 from lioncash/asm-disasm 
DSPAssembler/DSPDisassembler: Make constructors explicit
 2017-01-31 00:25:27 +01:00
Lioncash
a9db9fd217 DSPDisassembler: Make constructor explicit 2017-01-30 18:17:48 -05:00
Lioncash
546cd5d4be DSPAssembler: Make constructor explicit 2017-01-30 18:16:59 -05:00
degasus
2c69e976d0 DSPLLE: Only enable the DSP JIT on x64. 
The x64 JIT is hardcoded right now, and it seems unlikely that we'll support another arch here soon.
So let's just disable the DSP JIT.
 2017-01-30 23:53:58 +01:00
Lioncash
093b61139b Sram: Make SRAM dumps const 
This is only used internally, and isn't written to.
 2017-01-30 17:44:03 -05:00
Matthew Parlane
1603191145 Merge pull request #4786 from lioncash/fwd 
IOS STM: Get rid of forward declarations in the cpp file
 2017-01-30 22:20:58 +13:00
Markus Wick
2020928fd8 Merge pull request #4783 from degasus/temp 
JitArm64: Fix immediate versions of cmpl.
 2017-01-30 09:22:56 +01:00
booto
9c4621d2b5 Forgot to add to JitArm64. 
Also adds DCBZOFF to JitArm64.
 2017-01-29 22:05:07 -05:00
Mat M
548e2d6353 Merge pull request #4709 from lioncash/exi-device 
EXI_Device: Minor cleanup
 2017-01-29 19:50:42 -05:00
Lioncash
1801180a30 IOS STM: Get rid of forward declarations in the cpp file 
Forward declaring functions from a completely different header inside a cpp
file can lead to linker errors. Forward declaring also doesn't really
provide any benefit within cpp files unless it's to bring an internally
linked function within the same file into scope.
 2017-01-29 19:30:56 -05:00
Lioncash
d2da1897e7 IOS FS: Move behavior to separate functions 2017-01-29 18:32:59 -05:00
degasus
89cefe3103 JitArm64: Fix immediate versions of cmpl. 2017-01-29 18:38:43 +01:00
Matthew Parlane
e823a9d80c Merge pull request #4779 from lioncash/fileio 
IOS FileIO: Move GetFileStats code to its own function
 2017-01-29 21:53:11 +13:00
Matthew Parlane
a8c51d99f1 Merge pull request #4780 from booto/dcbz_hack 
Hack to stop dcbz/dcbi over low MEM1 trashing memory.
 2017-01-29 21:51:15 +13:00
Lioncash
5fd41716ae ec_wii: Make default data constexpr 
None of these are modified anywhere.
 2017-01-28 18:46:15 -05:00
Lioncash
926c9f995a ec_wii: Amend function casing 2017-01-28 18:46:14 -05:00
Lioncash
650071c3e4 ec_wii: Make getter functions const member functions 2017-01-28 18:45:56 -05:00
Lioncash
5b998ee9b0 ec_wii: Move implementation details into cpp file 
Gets rid of the need for an include in the header file.
 2017-01-28 18:45:04 -05:00
booto
2fbdf2a3ce Hack to stop dcbz/dcbi over low MEM1 trashing memory. 2017-01-28 18:04:44 -05:00
Lioncash
4c31bfef76 FileIO: Correct printf specifier in GetFileStats 2017-01-28 17:43:19 -05:00
Lioncash
6f0cabb1c5 FileIO: Move GetFileStats code to its own function 2017-01-28 17:41:40 -05:00
Mat M
66160c2781 Merge pull request #4743 from lioncash/es 
ES: Separate IOCtlV code out into constituent functions
 2017-01-28 15:33:34 -05:00
Markus Wick
69c4e6de41 Merge pull request #4767 from lioncash/mmio 
MMIO: Get rid of a TODO regarding tuples
 2017-01-28 15:38:49 +01:00
Lioncash
10d73988e7 DSPCore: Convert DSP stack register enum into an enum class 
Makes it more self-documenting which stack is being loaded or stored to,
as C, D, and magic numbers are extremely vague. It also enforces a
strongly-typed API instead of accepting arbitrary integral values.

It also adds the two other missing stack register names -- loop address
and loop counter.
 2017-01-28 09:17:27 -05:00
Lioncash
7959f900ed DSPEmitter: Remove unused class member variable 2017-01-28 06:36:54 -05:00
Markus Wick
04c3db8bfa Merge pull request #4771 from lioncash/dspemitter 
DSPCore: Move emitter cycle code into DSPEmitter itself
 2017-01-28 12:25:34 +01:00
Lioncash
be3f9f7431 DSPEmitter: Fix -Wreorder warnings 2017-01-28 06:07:25 -05:00
Lioncash
f5fe387a20 DSPEmitter: Make emitter dispatcher pointers private 2017-01-28 03:55:56 -05:00
Lioncash
0d42cbc923 DSPCore: Move JIT cycle code to DSPEmitter 
Moves x86-specific emitter code out of DSPCore.
 2017-01-28 03:55:40 -05:00
degasus
ca10cf5afe PPCAnalyst: Update comments 2017-01-28 03:03:04 +01:00
degasus
4855764345 JitArm64: Implement leaf inlining. 
There is no BLR stack, so this is quite trivial.
 2017-01-28 02:48:56 +01:00
degasus
f31b25fe39 Jit64: Enable branch following. 2017-01-28 02:48:56 +01:00
Lioncash
c748158182 SettingsHandler: Make GenerateSerialNumber static 
This doesn't depend on class internals.
 2017-01-27 10:29:57 -05:00
Lioncash
98291cd843 SettingsHandler: Add Open and Save member functions 2017-01-27 10:29:49 -05:00
Lioncash
d680d1f81e MMIO: Get rid of a TODO regarding tuples 2017-01-27 02:54:07 -05:00
Lioncash
4003360bcb DSPCore: Move CompileCurrent to the DSPEmitter 
This is only ever used here.
 2017-01-27 01:36:29 -05:00
Matthew Parlane
3d5821a9a7 Merge pull request #4745 from JosJuice/always-valid-region 
ConfigManager: Always set a valid m_region
 2017-01-27 18:18:37 +13:00
Matthew Parlane
06728ad687 Merge pull request #4757 from lioncash/dsptables 
DSPTables: Hide remaining opcode tables
 2017-01-27 18:17:36 +13:00
Matthew Parlane
a0e598be10 Merge pull request #4763 from lioncash/dspemitter 
DSPEmitter: Make most public variables private
 2017-01-27 18:10:02 +13:00
Matthew Parlane
64b0773fc0 Merge pull request #4651 from leoetlino/bt-pass-savestates 
Fix savestates in Bluetooth passthrough mode
 2017-01-27 18:07:33 +13:00
Lioncash
be52fcf651 DSPEmitter: Make most public variables private 
Dispatchers and m_unresolved_jumps is utilized in code outside of the
emitter, so these are left as is for the time being.
 2017-01-26 20:32:57 -05:00
Lioncash
970d969f63 DSPEmitter: Make conditional JIT functions in DSPJitBranch part of the emitter 
These quite clearly have a dependency on the emitter itself, so these
should be a part of the emitter itself.

The template function can be modified to just simply take functions as a
parameter.
 2017-01-26 20:32:34 -05:00
Lioncash
16aac00b8a DSPEmitter: Move private variables below function declarations 2017-01-26 19:25:49 -05:00
Lioncash
ef52451954 DSPJitRegCache: Convert DSPJitSignExtend into an enum class 
Prevents general names like SIGN, ZERO, and NONE from polluting the
surrounding namespace.
 2017-01-26 18:33:50 -05:00
Lioncash
bdd7034fcb DSPJitRegCache: Move allocation order array to the cpp file 
As it's a private static implementation detail that doesn't rely on any
other internals of DSPJitRegCache, it can be hidden.
 2017-01-26 17:12:55 -05:00
Lioncash
8f5ce50a25 DSPAssembler: Migrate VerifyParams over to an OpcodeType param instead of bool 2017-01-26 05:17:05 -05:00
Lioncash
6cb6707a4e DSPTables: Hide remaining exposed opcode tables 
All opcode tables are now internal.
 2017-01-26 05:17:01 -05:00
Markus Wick
0a07df13d2 Merge pull request #4753 from lioncash/dspjit 
DSPEmitter: Amend member variable naming
 2017-01-26 10:33:03 +01:00
Lioncash
ac973e61bb ES: Separate behavior of IOCtlV into separate functions 
This function is exceptionally large. Everything within a switch like this
also makes it quite error prone. Separating the functions out makes it
easier to change a certain request implementation as well as improving
code locality.
 2017-01-25 19:39:22 -05:00
Lioncash
3c88c248dd ES: Convert typedef into a using alias 2017-01-25 19:31:13 -05:00
Lioncash
3cf3b50ab0 ES: Minor header reorganization 
Places elements in the order:
- Structs/Enums definitions
- Functions
- Member variables
 2017-01-25 19:31:13 -05:00
Lioncash
f4415dd99c DSPEmitter: Amend member variable naming 
Amends the variable names to follow our coding style.
 2017-01-25 19:26:57 -05:00
Lioncash
c2e3bd8d2f DSPAssembler: Amend printf specifiers in ShowError 
code_line is a u32.
 2017-01-25 17:20:25 -05:00
Lioncash
992b7f7ac0 DSPAssembler: Replace char buffer + sprintf with StringFromFormat 2017-01-25 17:20:21 -05:00
booto
c889c81d8f 58 is 0x3a in hex, not 0x31 2017-01-26 01:52:10 +08:00
Léo Lam
0df2ca702b IOS: Get rid of static state in BT passthrough 2017-01-25 15:31:28 +01:00
Léo Lam
18957bdb0a IOS: Fix savestates for Bluetooth passthrough 
This fixes savestates when using Bluetooth passthrough by keeping track
of pending transfer commands and discarding them on state load, so that
the emulated software receives a reply to IOS requests as expected.

With this change, savestates in BT passthrough should work as long as
no Wiimote is connected when creating the savestate and when
restoring it. Yes, I know this is an important limitation -- but
that is probably the best we can do, and it's still better than
completely broken savestates.
 2017-01-25 15:31:28 +01:00
Florent Castelli
87380c1c2c cmake: Change endif(.*) to endif() 2017-01-25 15:07:32 +01:00
Markus Wick
3c184dcf8d Merge pull request #4742 from lioncash/dspasm 
DSPAssembler: Replace malloced output buffer with std::vector
 2017-01-25 14:49:36 +01:00
JosJuice
188d36ff26 ConfigManager: Refactor setting the region into a new function 2017-01-25 14:42:11 +01:00
Pierre Bourdon
18968abbd7 Merge pull request #4723 from booto/ios-init 
Set up IOS RAM information area with real values.
 2017-01-25 11:41:26 +01:00
Matthew Parlane
54e7d4a3dd Merge pull request #4748 from lioncash/dspregcache 
DSPJitRegCache: Make GetReg return by value
 2017-01-25 22:49:16 +13:00
booto
d16ca2e5c8 Load IOS from TMD when launching non-IOS title. 2017-01-25 01:11:48 -05:00
Lioncash
3734d6f16c DSPJitRegCache: Make GetReg return by value 
Using out-references for this sort of thing is a C++03-ism.
 2017-01-24 23:10:34 -05:00
degasus
d3aee2de08 JitCache: Split off JIT call from dispatcher. 
This avoid flushing the BLR optimization stack on fast_block_cache misses.
 2017-01-25 01:51:19 +01:00
JosJuice
8475b03bd8 ConfigManager: Always set a valid m_region 
Fixes a regression from f85266d that made WADs
with no detectable region not boot correctly.
The non-WAD code was already handling this correctly.
 2017-01-24 16:34:08 +01:00
booto
3ba388138d Set up IOS RAM information area with real values. 2017-01-24 09:48:21 -05:00
Lioncash
ed627a8cff DSPAssembler: Replace malloced output buffer with std::vector 
Same thing, less manual memory management.
 2017-01-23 22:03:40 -05:00
Florent Castelli
a7bf9271b5 Fix missing includes 2017-01-24 03:31:51 +01:00
Matthew Parlane
f70a1a27fa Merge pull request #4726 from ligfx/addingwindowsheaders 
Fix building without PCH on Windows
 2017-01-24 13:47:36 +13:00
Michael Maltese
0bc40cacda No longer need to //clang-format off for Windows headers 2017-01-23 16:23:37 -08:00
EmptyChaos
49873b1287 MMU/PatchEngine: Fix potential crash during stack probe 
TryReadInstruction doesn't validate the address it resolves, that
can result in Memory::GetPointer failing and returning nullptr
which then leads to a nullptr dereference and a crash.

Created PowerPC::HostIsInstructionRAMAddress which works the same
way as PowerPC::HostIsRAMAddress for the IBAT.
 2017-01-24 08:05:11 +11:00
degasus
7f6b8e3555 JitCache: Extract ErasePhysicalRange as function. 2017-01-23 20:33:44 +01:00
degasus
70caf447b9 JitCache: Get physical addresses from PPCAnalyst. 
So we support all kind of degenerated blocks now, not just range+length based ones.
 2017-01-23 20:33:44 +01:00
degasus
3529af61c4 JitAnalyzer: Remove jit block cache workaround. 2017-01-23 20:33:44 +01:00
degasus
f3ed993747 JitCache: Use a map with macro blocks for the occupied memory regions. 
This also allow fast invalidation, without any restritions on the blocks itself.
So we can now implement inlining.
 2017-01-23 20:33:44 +01:00
degasus
dc0fbc15f0 JitCache: Drop block_map. 
It is only used for invalidation, and in a bad way. Just scan over all elements,
as it is still in O(n), this shouldn't matter much.
 2017-01-23 20:33:44 +01:00
Léo Lam
0d8ddfb7d9 TMDReader: Add a way to get the required IOS version 2017-01-23 17:44:24 +01:00
Markus Wick
1c854f2daa Merge pull request #4727 from lioncash/enum-class 
VideoBackendBase: Convert EFBAccessType and FieldType into enum classes
 2017-01-23 17:14:06 +01:00
Lioncash
fd772f6726 ES: Move the key table into the cpp file 
This is a static implementation detail, so there's no need to bind it to the class directly.

This also makes the tables read-only.
 2017-01-23 08:16:28 -05:00
Markus Wick
c0e8280240 Merge pull request #4706 from lioncash/dspasm 
DSPAssembler: Minor cleanup
 2017-01-23 12:12:01 +01:00
Markus Wick
4436011c50 Merge pull request #4725 from lioncash/attachments 
Attachments: Minor cleanup
 2017-01-23 10:55:04 +01:00
Lioncash
34768617d2 Attachment: Make constructors explicit where applicable 2017-01-23 04:42:27 -05:00
Lioncash
34262ee3d8 Attachment: Move implementation details into the cpp file 2017-01-23 04:42:26 -05:00
Lioncash
c87ee2a00e Attachment: Use std::array over C arrays 2017-01-23 04:42:21 -05:00
Michael Maltese
713ec5ffd5 Add includes for building on Windows without PCH 2017-01-23 01:37:41 -08:00
Lioncash
940aa6f32d VideoBackendBase: Convert FieldType into an enum class 2017-01-23 03:54:01 -05:00
Lioncash
5b461f50af VideoBackendBase: Convert EFBAccessType into an enum class 2017-01-23 03:53:38 -05:00
Matthew Parlane
836f43038a Merge pull request #4722 from lioncash/si-device 
SI_Device: Minor cleanup
 2017-01-23 21:28:58 +13:00
degasus
819ebfb213 JitCache: Freeing hotfix. 
Sorry, I'm too stupid to test my code.
 2017-01-23 06:58:02 +01:00
Markus Wick
9cd34c7985 Merge pull request #4717 from degasus/arm 
JitArm64: Fix dcbz.
 2017-01-23 06:32:11 +01:00
Lioncash
4b2f40a634 Attachment: Make class members non-public 2017-01-22 23:53:13 -05:00
Lioncash
fbcf86870d SI_Device: Remove const specifiers from SIDevice_Create declaration's parameters 
These are only relevant on the definition of the function.
 2017-01-22 22:34:23 -05:00
Lioncash
0adb0dfeef SI_Device: Move implementation details into the cpp file 
Any changes to the base class' default behavior now won't require
all SI device source files to be recompiled.
 2017-01-22 22:33:27 -05:00
Lioncash
fb8f19f553 SI_Device: Amend variable naming 2017-01-22 22:20:16 -05:00
Lioncash
f41e5eac2e SI_Device: Move protected interface below public interface 2017-01-22 22:10:43 -05:00
Lioncash
7f4ef74542 SI_Device: Move the null device implementation to its own source files 2017-01-22 21:18:51 -05:00
degasus
a19993c2a0 JitArm64: Fix dcbz. 
This fixes the hidden wall in xenoblade.
 2017-01-23 00:26:38 +01:00
Matthew Parlane
ba5c3f4c46 Merge pull request #4582 from iwubcode/per_game_wii_lang 
Add support for specifying the GC/Wii system language per-game
 2017-01-23 11:51:37 +13:00
Matthew Parlane
ef7a809fad Merge pull request #4678 from degasus/jitcache 
JitCache: Store the JIT blocks in the std::map.
 2017-01-23 11:49:46 +13:00
iwubcode
a7a8e35823 Add support for specifying the GC/Wii system language per-game 2017-01-22 12:00:45 -06:00
Léo Lam
6291cd0bce IOS: STM: Save event hook to savestates 
This allows a STM event hook to be saved and restored correctly and
fixes the power/reset button after loading a state in some cases.
 2017-01-22 17:29:39 +01:00
degasus
8e00c411a3 JitCache::Rename iCache to fast_block_map. 
iCache sounds too much like emulation.
 2017-01-22 17:10:28 +01:00
degasus
830ae6a2c1 JitCache: Store the JitBlock in the std::map. 2017-01-22 16:50:46 +01:00
degasus
43cdbab515 Jit64: Add a switch for easier fallback to the C++ dispatcher. 2017-01-22 16:50:46 +01:00
degasus
9b77a39767 JitCache: Only call DestroyBlock on valid blocks. 2017-01-22 16:50:46 +01:00
degasus
113d6b3b84 JitCache: Use a multimap for block_map and start_block_map. 
We may have duplicated entries here because of MSR mismatch. Just
store both and validate the matching one on cache access.
 2017-01-22 16:50:46 +01:00
degasus
9d58127dec JitCache: Move JitBlock config variable. 2017-01-22 16:50:46 +01:00
degasus
352909fc4c JitCache: Track the ICache entry of jit blocks. 
This guarantees that no invalidated jit block is still in the icache.
 2017-01-22 16:50:14 +01:00
Lioncash
a97aef2e94 Jit: Eliminate JIT global usages 2017-01-22 06:01:30 -05:00
Lioncash
a18ab5e154 JitArm64_LoadStore: Eliminate JIT global usages 2017-01-22 05:59:38 -05:00
Lioncash
4601499179 JitArm64_LoadStoreFloating: Eliminate JIT global usages 2017-01-22 05:57:44 -05:00
Lioncash
b4e00115c5 JitArm64_Tables: Eliminate usages of the JIT global 2017-01-22 05:54:33 -05:00
Lioncash
b0605c24d3 JitIL_Tables: Eliminate usages of the JIT global 2017-01-22 05:43:40 -05:00
Lioncash
3ee31890d3 Jit64_Tables: Eliminate usages of the JIT global 2017-01-22 05:43:34 -05:00
degasus
c9c5437cb8 JitCache: Fix links_to updates on destroying blocks. 2017-01-22 11:37:22 +01:00
Lioncash
6cddc1be95 EXI_Device: Get rid of an unnecesary cast 2017-01-22 04:28:49 -05:00
Lioncash
2e85ddef60 EXI_Device: Remove unnecessary const on EXIDevice_Create declaration parameters 
These are only relevant on its definition.
 2017-01-22 04:28:48 -05:00
Lioncash
07a61b0d15 EXI_Device: Move implementation details into the cpp file 
Any change to the default behavior of any device methods now won't require
the recompilation of all EXI devices.
 2017-01-22 04:28:44 -05:00
Lioncash
e41a6ac9a3 EXI_Device: Amend variable naming 2017-01-22 04:08:49 -05:00
Lioncash
4115d93c71 EXI_Device: Move destructor to beginning of public section 
Constructors and destructors should be the first thing shown in a public
interface.
 2017-01-22 02:35:20 -05:00
Lioncash
a5c0409050 EXI_Device: Move private details below the public interface 2017-01-22 02:30:10 -05:00
Lioncash
7c0b96f638 EXI_Device: Move the dummy implementation to its own source files 2017-01-22 02:15:36 -05:00
Lioncash
d6bdbfe90e DSPAssembler: Use std::string instead of malloced char buffers in AssembleFile 2017-01-22 01:15:36 -05:00
Lioncash
cbe1ec51df DSPAssembler: Make AssembleFile take a std::string 
File paths passed to it would have been implicitly converted to std::strings
prior to this function being reached, so it gets rid of some string churn.
It also makes it safer since nullptr can't be passed in.
 2017-01-22 01:15:31 -05:00
Matthew Parlane
d9c873bc8b Merge pull request #4704 from lioncash/exi-channel 
EXI_Channel: Minor cleanup
 2017-01-22 16:53:09 +13:00