Retropex/bitcoin
1
0
Fork 0
mirror of https://github.com/Retropex/bitcoin.git synced 2025-05-12 19:20:42 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
fb2b05b125
bitcoin/cmake
History
merge-script d61a847af0
Merge bitcoin/bitcoin#32019: cmake: Check for makensis and zip tools before using them for optional deploy targets 
1f9b2e150c cmake: Require `zip` only for `deploy` target (Hennadii Stepanov)
0aeff29951 cmake: Check for `makensis` tool before using it (Hennadii Stepanov)

Pull request description:

  For `x86_64-w64-mingw32` and `*-apple-darwin` targets, the optional `deploy` target requires dedicated tools: `makensis` and `zip`, respectively.

  This PR introduces a uniform checks for those tools when attempting to build the `deploy` target, ensuring they are not required for configuring and building any other targets.

  Here is an example of workflow for `x86_64-w64-mingw32`:
  ```
  $ # `nsis` is not installed
  $ cmake -B build -G "GNU Makefiles" --toolchain depends/x86_64-w64-mingw32/toolchain.cmake
  $ cmake --build build -j $(nproc)
  $ cmake --build build -t deploy

  Error: NSIS not found.
  Please install NSIS and/or ensure that its executable is accessible to the find_program() command—
  for example, by setting the MAKENSIS_EXECUTABLE variable or another relevant CMake variable.
  Then re-run cmake to regenerate the build system.

  Built target deploy
  $ sudo apt install nsis
  $ cmake -B build
  $ cmake --build build -t deploy
  ...
  [100%] Generating bitcoin-win64-setup.exe
  [100%] Built target deploy
  ```

  Fixes https://github.com/bitcoin/bitcoin/issues/32018.

ACKs for top commit:
  hodlinator:
    re-ACK 1f9b2e150c
  fanquake:
    ACK 1f9b2e150c

Tree-SHA512: 5e2bd28a13bd8fa7c4ba8cf1756d200a4651afe83c463d76ece10027cca343e124eff97012a5368028f761df60f420ab891106b4e33b50045051d57c7464ff98
2025-03-18 17:10:40 +08:00
..
module Merge bitcoin/bitcoin#32019: cmake: Check for makensis and zip tools before using them for optional deploy targets 2025-03-18 17:10:40 +08:00
script cmake: Copy cov_tool_wrapper.sh.in to the build tree 2025-01-23 10:00:58 +00:00
bitcoin-build-config.h.in build: require sqlite when building the wallet 2025-03-12 15:42:38 +01:00
ccache.cmake build: don't use ccache with MSVC 2025-03-04 14:53:06 +00:00
crc32c.cmake Merge bitcoin/bitcoin#31662: cmake: Do not modify CMAKE_TRY_COMPILE_TARGET_TYPE globally 2025-02-20 15:07:03 -05:00
introspection.cmake scripted-diff: Rename CMake helper module 2025-02-20 12:39:20 +00:00
leveldb.cmake Merge bitcoin/bitcoin#31366: cmake: Check -Wno-* compiler options for leveldb target 2025-02-20 12:22:20 -05:00
minisketch.cmake Merge bitcoin/bitcoin#31880: cmake: Add optional sources to minisketch library directly 2025-02-25 14:11:58 -05:00
tests.cmake cmake: Add Python-based tests 2024-08-16 19:27:41 +01:00