mirror of https://github.com/Retropex/bitcoin.git synced 2025-06-04 00:12:33 +02:00

Node of Bitcoin network

Go to file

laanwj 489b587669 Merge bitcoin/bitcoin#25215 : [kernel 2d/n] Reduce CTxMemPool constructor call sites `d273e53b6e` bench/rpc_mempool: Create ChainTestingSetup, use its CTxMemPool (Carl Dong) `020caba3df` bench: Use existing CTxMemPool in TestingSetup (Carl Dong) `86e732def3` scripted-diff: test: Use CTxMemPool in TestingSetup (Carl Dong) `213457e170` test/policyestimator: Use ChainTestingSetup's CTxMemPool (Carl Dong) `319f0ceeeb` rest/getutxos: Don't construct empty mempool (Carl Dong) `03574b956a` tree-wide: clang-format CTxMemPool references (Carl Dong) Pull request description: This is part of the `libbitcoinkernel` project: #24303, https://github.com/bitcoin/bitcoin/projects/18 This PR reduces the number of call sites where we explicitly construct CTxMemPool. This is done in preparation for later PRs which decouple the mempool module from `ArgsManager`, eventually all of libbitcoinkernel will be decoupled from `ArgsManager`. The changes in this PR: - Allows us to have less code churn as we modify `CTxMemPool`'s constructor in later PRs - In many cases, we can make use of existing `CTxMemPool` instances, getting rid of extraneous constructions - In other cases, we construct a `ChainTestingSetup` and use the `CTxMemPool` there, so that we can rely on the logic in `setup_common` to set things up correctly ## Notes for Reviewers ### A note on using existing mempools When evaluating whether or not it's appropriate to use an existing mempool in a `TestingSetup` struct, the key is to make sure that the mempool has the same lifetime as the `TestingSetup` struct. Example 1: In [`src/fuzz/tx_pool.cpp`](`b4f686952a/src/test/fuzz/tx_pool.cpp`), the `TestingSetup` is initialized in `initialize_tx_pool` and lives as a static global, while the `CTxMemPool` is in the `tx_pool_standard` fuzz target, meaning that each time the `tx_pool_standard` fuzz target gets run, a new `CTxMemPool` is created. If we were to use the static global `TestingSetup`'s CTxMemPool we might run into problems since its `CTxMemPool` will carry state between subsequent runs. This is why we don't modify `src/fuzz/tx_pool.cpp` in this PR. Example 2: In [`src/bench/mempool_eviction.cpp`](`b4f686952a/src/bench/mempool_eviction.cpp`), we see that the `TestingSetup` is in the same scope as the constructed `CTxMemPool`, so it is safe to use its `CTxMemPool`. ### A note on checking `CTxMemPool` ctor call sites After the "tree-wide: clang-format CTxMemPool references" commit, you can find all `CTxMemPool` ctor call sites with the following command: ```sh git grep -E -e 'make_unique<CTxMemPool>' \ -e '\bCTxMemPool\s+[^({;]+[({]' \ -e '\bCTxMemPool\s+[^;]+;' \ -e '\bnew\s+CTxMemPool\b' ``` At the end of the PR, you will find that there are still quite a few call sites that we can seemingly get rid of: ```sh $ git grep -E -e 'make_unique<CTxMemPool>' -e '\bCTxMemPool\s+[^({;]+[({]' -e '\bCTxMemPool\s+[^;]+;' -e '\bnew\s+CTxMemPool\b' # rearranged for easier explication src/init.cpp: node.mempool = std::make_unique<CTxMemPool>(node.fee_estimator.get(), mempool_check_ratio); src/test/util/setup_common.cpp: m_node.mempool = std::make_unique<CTxMemPool>(m_node.fee_estimator.get(), 1); src/rpc/mining.cpp: CTxMemPool empty_mempool; src/test/util/setup_common.cpp: CTxMemPool empty_pool; src/bench/mempool_stress.cpp: CTxMemPool pool; src/bench/mempool_stress.cpp: CTxMemPool pool; src/test/fuzz/rbf.cpp: CTxMemPool pool; src/test/fuzz/tx_pool.cpp: CTxMemPool tx_pool_{/estimator=/nullptr, /check_ratio=/1}; src/test/fuzz/tx_pool.cpp: CTxMemPool tx_pool_{/estimator=/nullptr, /check_ratio=/1}; src/test/fuzz/validation_load_mempool.cpp: CTxMemPool pool{}; src/txmempool.h: /** Create a new CTxMemPool. ``` Let's break them down one by one: ``` src/init.cpp: node.mempool = std::make_unique<CTxMemPool>(node.fee_estimator.get(), mempool_check_ratio); src/test/util/setup_common.cpp: m_node.mempool = std::make_unique<CTxMemPool>(m_node.fee_estimator.get(), 1); ``` Necessary ----- ``` src/rpc/mining.cpp: CTxMemPool empty_mempool; src/test/util/setup_common.cpp: CTxMemPool empty_pool; ``` These are fixed in #25223 where we stop requiring the `BlockAssembler` to have a `CTxMemPool` if it's not going to consult it anyway (as is the case in these two call sites) ----- ``` src/bench/mempool_stress.cpp: CTxMemPool pool; src/bench/mempool_stress.cpp: CTxMemPool pool; ``` Fixed in #24927. ----- ``` src/test/fuzz/rbf.cpp: CTxMemPool pool; src/test/fuzz/tx_pool.cpp: CTxMemPool tx_pool_{/estimator=/nullptr, /check_ratio=/1}; src/test/fuzz/tx_pool.cpp: CTxMemPool tx_pool_{/estimator=/nullptr, /check_ratio=/1}; src/test/fuzz/validation_load_mempool.cpp: CTxMemPool pool{}; ``` These are all cases where we don't want the `CTxMemPool` state to persist between runs, see the previous section "A note on using existing mempools" ----- ``` src/txmempool.h: /** Create a new CTxMemPool. ``` It's a comment (someone link me to a grep that understands syntax plz thx) ACKs for top commit: laanwj: Code review ACK `d273e53b6e` Tree-SHA512: c4ff3d23217a7cc4a7145defc7b901725073ef73bcac3a252ed75f672c87e98ca0368d1d8c3f606b5b49f641e7d8387d26ef802141b650b215876f191fb6d5f9		2022-06-16 19:49:34 +02:00
.github	doc: Remove label from good first issue template	2020-08-24 09:31:24 +02:00
.tx	qt: Update transifex resource blob to 23.0	2022-02-03 13:18:28 +01:00
build_msvc	qt, refactor: Add `transactionoverviewwidget.cpp` source file	2022-06-14 16:55:22 +02:00
build-aux/m4	build: stop overriding user CXXFLAGS	2022-04-03 19:36:17 +01:00
ci	refactor: cleanups post unsubtree'ing univalue	2022-06-15 12:56:44 +01:00
contrib	refactor: cleanups post unsubtree'ing univalue	2022-06-15 12:56:44 +01:00
depends	build: support LTO in depends	2022-06-14 12:08:27 +01:00
doc	Merge bitcoin/bitcoin#25369 : Unsubtree Univalue	2022-06-16 13:47:01 +02:00
share	doc: replace bitcoin.conf with placeholder file	2022-05-02 15:38:07 +02:00
src	Merge bitcoin/bitcoin#25215 : [kernel 2d/n] Reduce CTxMemPool constructor call sites	2022-06-16 19:49:34 +02:00
test	Merge bitcoin/bitcoin#25369 : Unsubtree Univalue	2022-06-16 13:47:01 +02:00
.cirrus.yml	ci, android: Update NDK up to r23c	2022-05-31 18:45:13 +02:00
.editorconfig	ci: Drop AppVeyor CI integration	2021-09-07 06:12:53 +03:00
.gitattributes	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
.gitignore	refactor: cleanups post unsubtree'ing univalue	2022-06-15 12:56:44 +01:00
.python-version	Bump minimum python version to 3.6	2020-11-09 17:53:47 +10:00
.style.yapf	test: .style.yapf: Set column_limit=160	2019-03-04 18:28:13 -05:00
autogen.sh	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
configure.ac	Merge bitcoin/bitcoin#25282 : Bugfix: configure: Define default for use_libevent	2022-06-16 18:19:49 +02:00
CONTRIBUTING.md	doc: Explain squashing with merge commits	2022-05-24 08:17:41 +02:00
COPYING	doc: Update license year range to 2022	2022-01-03 04:48:41 +08:00
INSTALL.md	doc: Added hyperlink for doc/build	2021-09-09 19:53:12 +05:30
libbitcoinconsensus.pc.in	build: remove libcrypto as internal dependency in libbitcoinconsensus.pc	2019-11-19 15:03:44 +01:00
Makefile.am	refactor: cleanups post unsubtree'ing univalue	2022-06-15 12:56:44 +01:00
README.md	doc: Explain Bitcoin Core in README.md	2022-05-10 07:49:09 +02:00
REVIEWERS	test: port 'lint-shell.sh' to python	2022-05-05 08:44:08 -05:00
SECURITY.md	doc: Suggest `keys.openpgp.org` as keyserver in SECURITY.md	2021-11-08 12:22:04 +01:00

README.md

Bitcoin Core integration/staging tree

https://bitcoincore.org

For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.

What is Bitcoin Core?

Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.

Further information about Bitcoin Core is available in the doc folder.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be completely stable. Tags are created regularly from release branches to indicate new official, stable release versions of Bitcoin Core.

The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.