bitcoin/src/kernel
fanquake 214f8f18b3
Merge bitcoin/bitcoin#27774: refactor: Add [[nodiscard]] where ignoring a Result return type is an error
fa5680b752 fix includes for touched header files (iwyu) (MarcoFalke)
dddde27f6f Add [[nodiscard]] where ignoring a Result return type is an error (MarcoFalke)

Pull request description:

  Only add it for those where it is an error to ignore. Also, fix the gcc compile warning https://github.com/bitcoin/bitcoin/pull/25977#issuecomment-1564350880. Also, fix iwyu for touched header files.

ACKs for top commit:
  TheCharlatan:
    ACK fa5680b752
  stickies-v:
    ACK fa5680b752

Tree-SHA512: c3509103bfeae246e2cf565bc561fcd68d8118515bac5431ba5304c3a63c8254b9c4f40e268b6f6d6b79405675c5a960db9b4eb3bdd14aedca333dc1c9e76415
2023-05-30 15:32:19 +01:00
..
bitcoinkernel.cpp b-cs: Define G_TRANSLATION_FUN in bitcoinkernel.cpp 2022-04-26 16:30:53 -04:00
blockmanager_opts.h refactor, blockstorage: Replace stopafterblockimport arg 2023-05-10 19:07:46 +02:00
chain.cpp wallet: skip block scan if block was created before wallet birthday 2023-05-25 10:45:38 -03:00
chain.h interfaces, refactor: Add more block information to block connected notifications 2022-07-18 13:39:55 -05:00
chainparams.cpp scripted-diff: Remove unused chainparamsbase includes 2023-05-09 15:49:19 +02:00
chainparams.h refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
chainstatemanager_opts.h kernel: Add notification interface 2023-05-20 12:03:22 +02:00
checks.cpp refactor: Replace std::optional<bilingual_str> with util::Result 2023-05-24 08:55:47 -04:00
checks.h fix includes for touched header files (iwyu) 2023-05-29 13:26:31 +02:00
coinstats.cpp Avoid dereferencing interruption_point if it is nullptr 2023-05-02 20:19:28 +02:00
coinstats.h Use DataStream where possible 2023-01-26 10:44:05 +01:00
context.cpp Adapt to libsecp256k1 API changes 2022-12-13 15:08:24 -05:00
context.h Adapt to libsecp256k1 API changes 2022-12-13 15:08:24 -05:00
cs_main.cpp kernel: add missing include 2023-02-22 15:46:21 +00:00
cs_main.h refactor: add kernel/cs_main.* 2023-01-05 09:05:14 +00:00
mempool_entry.h refactor: Move txmempool_entry.h --> kernel/mempool_entry.h 2022-11-30 10:37:57 +00:00
mempool_limits.h refactor: mempool: add MemPoolLimits::NoLimits() 2022-10-05 13:07:11 +01:00
mempool_options.h doc: Fix comment syntax error 2023-01-30 10:26:02 +00:00
mempool_persist.cpp refactor: Move fs.* to util/fs.* 2023-03-23 12:55:18 +01:00
mempool_persist.h refactor: Move fs.* to util/fs.* 2023-03-23 12:55:18 +01:00
notifications_interface.h kernel: Add warning method to notifications 2023-05-20 12:03:28 +02:00
validation_cache_sizes.h validationcaches: Use size_t for sizes 2022-08-03 12:03:28 -04:00