Antoine Poinsot
ae9a2ed40a
sign: don't assume we are parsing a sane Miniscript
...
The script provided for signature might be externally provided, for
instance by way of 'finalizepsbt'. Therefore the script might be
ill-crafted, so don't assume pubkeys are always 32 bytes.
Thanks to Niklas for finding this.
Github-Pull: #29853
Rebased-From: 4d8d21320e
2024-04-24 21:16:47 +08:00
MarcoFalke
a6a59cfebc
rpc: Reword SighashFromStr error message
...
Github-Pull: #29870
Rebased-From: fa6ab0d020
2024-04-24 20:57:09 +08:00
Luke Dashjr
3dde40d756
Diff-minimise (revert doc update)
2024-04-24 02:40:03 +00:00
Luke Dashjr
f90a84d615
Bugfix: JSON-RPC request Content-Type is application/json
2024-04-24 02:38:39 +00:00
Matthew Zipkin
99a5703b2b
test: cover unix sockets in zmq interface
...
Github-Pull: #27679
Rebased-From: 791dea204e
2024-04-24 02:09:26 +00:00
Matthew Zipkin
dabf896ea8
zmq: accept unix domain socket address for notifier
...
Based on Github-Pull: #27679
Based on: c87b0a0ff4
2024-04-24 02:09:26 +00:00
Matthew Zipkin
584f254413
QA/netutil: Add test_unix_socket
...
Part of "test: cover UNIX sockets in feature_proxy.py"
Github-Pull: #27375
Commit: bfe5192891
2024-04-24 02:09:26 +00:00
Matthew Zipkin
8300cf27f5
netbase: define ADDR_PREFIX_UNIX
...
Part of "extend Proxy class to wrap UNIX socket as well as TCP"
Github-Pull: #27375
Commit: a89c3f59dc
2024-04-24 02:09:26 +00:00
Luke Dashjr
fd5c5cfe7d
Merge remote-tracking branch 'origin-pull/28020/head' into HEAD
2024-04-24 02:09:19 +00:00
Luke Dashjr
d15b753382
Diff-minimise
2024-04-23 20:56:03 +00:00
Matthew Zipkin
f9e091fc85
blockstorage: do not flush block to disk if it is already there
...
test: ensure we can reindex from read-only block files now
Github-Pull: #27039
Rebased-From: dfcef536d0
2024-04-23 20:56:03 +00:00
Ava Chow
5204a1a601
psbt: Check non witness utxo outpoint early
...
A common issue that our fuzzers keep finding is that outpoints don't
exist in the non witness utxos. Instead of trying to track this down and
checking in various individual places, do the check early during
deserialization.
Github-Pull: #29855
Rebased-From: 9e13ccc50e
2024-04-21 19:17:38 +00:00
laanwj
7af5125276
net: Decrease nMaxIPs when learning from DNS seeds
...
Limit number of IPs learned from a single DNS seed to 32, to prevent the results from
one DNS seed from dominating AddrMan. Note that the number of results from a UDP DNS query is
bounded to 33 already, but it is possible for it to use TCP where a potentially enormous
number of results can be returned.
Closes #16070 .
Github-Pull: #29850
Rebased-From: f2e3662e57
2024-04-21 19:08:22 +00:00
Luke Dashjr
c155102244
Bugfix: RPC: Return all warnings in get{blockchain,mining,network}info
2024-04-21 19:03:29 +00:00
Hennadii Stepanov
364bf01ff2
build: Fix false positive CHECK_ATOMIC test for clang-15
...
Github-Pull: #29859
Rebased-From: dd3e0fa125
2024-04-17 14:05:09 +01:00
MarcoFalke
9277793b4e
test: Fix failing univalue float test
...
Github-Pull: #29892
Rebased-From: fa4c69669e
2024-04-17 14:05:00 +01:00
fanquake
5c097910e0
doc: archive 27.0 release notes
...
Github-Pull: #29886
Rebased-From: c08754971d
2024-04-17 14:04:34 +01:00
dergoegge
897e5af58a
[rpc, bugfix] Enforce maximum value for setmocktime
...
Github-Pull: #29869
Rebased-From: c2e0489b71
2024-04-16 09:28:23 +01:00
MarcoFalke
602cfd580a
ci: Bump s390x to ubuntu:24.04
...
Re-enable feature_init
Github-Pull: #29856
Rebased-From: fadf7e90dc
2024-04-16 09:28:22 +01:00
Luke Dashjr
20e6e8dc80
Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us
...
To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed.
Github-Pull: #29691
Rebased-From: 4f273ab436
2024-04-16 09:28:22 +01:00
fanquake
a6862c50c5
depends: fix mingw-w64 Qt DEBUG=1 build
...
The issue is that compilation is done with `x86_64-w64-mingw32-g++-posix`,
but then linking is done with `x86_64-w64-mingw32-g++`.
I'm guessing this has been broken since #24131
(01d1845a80Fixes #29734 .
Unblocks #29527 (now DEBUG=1 builds can be tested).
Github-Pull: #29747
Rebased-From: b7e7e727ab
2024-04-16 09:12:39 +01:00
merge-script
d82283950f
Merge bitcoin/bitcoin#29780 : [27.x] More backports and finalize
...
910e3e87282d2a0a369e9442ea82dafe51aceecabde54b7627753c68dc0fc4da61b323https://github.com/bitcoin/bitcoin/pull/29740
* https://github.com/bitcoin/bitcoin/pull/29764
* https://github.com/bitcoin/bitcoin/pull/29782
Pulls release notes: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/27.0-Release-Notes-Draft .
Finalizes `v27.0`.
ACKs for top commit:
achow101:
ACK 910e3e8728910e3e8728
2024-04-15 17:28:32 +01:00
fanquake
910e3e8728
doc: update manual pages for v27.0
2024-04-15 09:49:20 +01:00
fanquake
2d2a0a369e
build: bump version to v27.0 final
2024-04-15 09:49:19 +01:00
fanquake
9442ea82da
doc: import release notes from devwiki
...
https://github.com/bitcoin-core/bitcoin-devwiki/wiki/27.0-Release-Notes-Draft .
2024-04-15 09:49:14 +01:00
Edil Medeiros
fe51aceeca
Update the developer mailing list address.
...
The developer mailing list was migrated to Google Groups in February 2024
as announced in https://groups.google.com/g/bitcoindev/c/aewBuV6k-LI .
The archives maintained by the Linux Foundation stopped updating in December
2024. Thus, we point to the new archive maintained by gnusha.org.
The codebase refers to old discussions linked to the Linux Foundation archives.
Since all links are still active to this date, we keep them as they are.
See #29782 .
Github-Pull: #29782
Rebased-From: 0ead466a0c
2024-04-04 14:39:42 +01:00
MarcoFalke
bde54b7627
ci: Print tsan errors to stderr
...
Github-Pull: #29740
Rebased-From: fa22a438fa
2024-04-03 09:57:11 +01:00
laanwj
753c68dc0f
ci: Pull in qtbase5-dev instead of seperate low-level libraries
...
Fix CI build for t64 migration.
Github-Pull: #29764
Rebased-From: 6c2990416e
2024-04-01 16:03:26 +02:00
laanwj
c4da61b323
doc: Suggest installing dev packages for debian/ubuntu qt5 build
...
Pretty much all library packages were renamed in the 64-bit time_t
migration to add `t64` (even on 64-bit platforms).
Instead of complicating the doc with conditional package names, suggest
installing the `-dev` packages which still have the same name, and
besides that, are the right way to go about it as they contain the
"user facing" C++ headers needed to build against Qt5.
For Fedora, devel packages are already suggested.
This affects Ubuntu 24.04 and Debian Testing.
Github-Pull: #29764
Rebased-From: a3c6a13cb2
2024-04-01 16:02:23 +02:00
fanquake
b3cd952495
Merge bitcoin/bitcoin#29693 : [27.x] Further Backports
...
a7116c8feb05f69b36d1603f0368a55d381cfb6ff4be4d7447https://github.com/bitcoin/bitcoin/pull/29192
* https://github.com/bitcoin/bitcoin/pull/29610
* https://github.com/bitcoin/bitcoin/pull/29676
ACKs for top commit:
stickies-v:
ACK a7116c8feb
2024-03-26 09:59:43 +00:00
MarcoFalke
a7116c8feb
ci: Bump msan to llvm-18
...
Github-Pull: #29676
Rebased-From: faecf3a7e6
2024-03-21 17:19:44 +00:00
Hennadii Stepanov
05f69b36d1
ci, macos: Use --break-system-packages with Homebrew's python
...
Homebrew's python@3.12 is marked as externally managed (PEP 668),
necessitating different approaches for installing Python packages.
For more details, please refer to https://github.com/orgs/Homebrew/discussions/3404 .
Github-Pull: #29610
Rebased-From: acc06bc91f
2024-03-21 17:19:44 +00:00
Hennadii Stepanov
603f0368a5
ci: Add workaround for Homebrew's python link error
...
Promoting Homebrew's python@3.12 to the default python3 breaks symbolic
links on macOS x86_64.
This change adds a workaround for that issue.
Also see: https://github.com/actions/runner-images/issues/9471 etc.
Github-Pull: #29610
Rebased-From: acc06bc91f
2024-03-21 17:19:40 +00:00
Pieter Wuille
5d381cfb6f
serfloat: improve/simplify tests
...
Github-Pull: #29192
Rebased-From: 6e873df347
2024-03-21 16:42:41 +00:00
Pieter Wuille
f4be4d7447
serfloat: do not test encode(bits)=bits anymore
...
Github-Pull: #29192
Rebased-From: b45f1f5658
2024-03-21 16:42:15 +00:00
Luke Dashjr
279c4ee734
doc/release-process: Correct m_assumed_*_size to GB
2024-03-19 16:34:00 +00:00
Luke Dashjr
87471d26bf
Bugfix: init: For first-run disk space check, advise user of correct pruned size rather than full blockchain size
2024-03-19 15:47:51 +00:00
Luke Dashjr
99632e59cd
Bugfix: init: Correct conversion of AssumedBlockchainSize to use GB
2024-03-19 15:47:26 +00:00
Luke Dashjr
581215006e
CI: Extend macOS native timeout to 6 hours
...
Actual run took 3h31m, largely due to wallet_notifications fuzzer which ran for 2h28m
2024-03-17 12:40:44 +00:00
Luke Dashjr
d1ed09a764
Bugfix: GUI: Help messages already have a trailing newline, so don't add an extra one
2024-03-15 00:38:33 +00:00
Luke Dashjr
90bbe65ebc
CI: Disable libbitcoinkernel build (not supported for now)
2024-03-15 00:38:01 +00:00
Lőrinc
2435c39a6c
Reserve memory for ToLower/ToUpper conversions
...
Github-Pull: #29606
Rebased-From: 6f2f4a4d09
2024-03-14 22:57:13 +00:00
Luke Dashjr
8d738f9101
CI: Disable MSVC task (MSVC is not supported)
2024-03-14 22:47:58 +00:00
Luke Dashjr
58de91d9fe
Bugfix: Move common/url to libbitcoin_util.a for now
2024-03-14 22:46:21 +00:00
Luke Dashjr
df57f56ad9
GUI: Intro: Have user choose assumevalid
2024-03-14 21:56:16 +00:00
Luke Dashjr
cda83e8ae1
GUI: Intro: Output a std::unique_ptr<Intro> from Intro::showIfNeeded
2024-03-14 18:25:23 +00:00
Luke Dashjr
9f35a5bd12
RPC/Blockchain: Demote loadtxoutset to hidden/debug-only for now (not supported on mainnet)
2024-03-14 00:26:34 +00:00
Luke Dashjr
29961a9421
RPC/Mempool: Avoid extra decrement of unsigned below 0 when building fee histogram
2024-03-10 19:04:47 +00:00
Luke Dashjr
dab9589e2d
wallet: let ListWalletDir do not iterate trough our blocksdata.
...
When WalletDir == DataDir we would have iterate trough our own node files
to find wallets, that consumes time and could cause an unresponsive node.
Github-Pull: #19419
Rebased-From: c730c7a6b6eb9f2e5138e2874ca7c5c269086bf3
2024-03-10 19:03:12 +00:00
Luke Dashjr
b83763a4d9
QA: Allow test_runner to pass without full RPC coverage
2024-03-10 18:59:23 +00:00
