Luke Dashjr
78c7a7d1f6
Merge fix_keep_notmy_cookie
2024-06-21 19:28:12 +00:00
Luke Dashjr
7750cf2b3f
Merge 28345 via fix_bytespersigop_checks-mini
2024-06-21 19:28:12 +00:00
Luke Dashjr
d4d76cedc3
Merge 29946 via jsonrpc_content_type-26+mini
2024-06-21 19:28:12 +00:00
Luke Dashjr
a82dedb8c2
Merge 28055 via fix_getblockfrompeer_rereq_err
2024-06-21 19:28:12 +00:00
Luke Dashjr
3a62f731f7
Merge 28029 via fix_zmq_errhandling_202307-mini
2024-06-21 19:28:12 +00:00
Luke Dashjr
a1c1504ab8
Merge qt_ambig_uri_refs
2024-06-21 19:28:12 +00:00
Luke Dashjr
fd0205141f
Merge zmq_unix_uri_compat-25
2024-06-21 19:28:12 +00:00
Luke Dashjr
8dc4bee04f
Merge 28020 via origin-pull/28020/head
2024-06-21 19:28:12 +00:00
Luke Dashjr
5eee4dce8b
Merge 27815 via origin-pull/27815/head
2024-06-21 19:28:12 +00:00
Luke Dashjr
b1d6a4dc5f
Merge 27814 via origin-pull/27814/head
2024-06-21 19:28:12 +00:00
Luke Dashjr
52cf69fd00
Merge acceptstalefeeestimates_mainnet_opt
2024-06-21 19:28:12 +00:00
Luke Dashjr
72a9decfa9
Merge 27039 via fix_reindex_readonly_blkfiles-26
2024-06-21 19:28:12 +00:00
Luke Dashjr
3870249e45
Merge g684 via qt_reqs_multiselect_pr684-25+knots
2024-06-21 19:28:12 +00:00
Luke Dashjr
90c568f524
Merge g677 via fix_qt_peers_na
2024-06-21 19:28:12 +00:00
Luke Dashjr
51c432cfeb
Merge g662 via qt_fix_txview_202209
2024-06-21 19:28:12 +00:00
Luke Dashjr
90ee1f3470
Merge g633 via origin-pull-g/633/head
2024-06-21 19:28:12 +00:00
Luke Dashjr
4d1566dadc
Merge hww_windows-27
2024-06-21 19:28:12 +00:00
Luke Dashjr
460baed096
Merge boost_171_177_workarounds
2024-06-21 19:28:12 +00:00
Luke Dashjr
c0730223ad
Merge g599 via ts_20220515-partial-25
2024-06-21 19:28:12 +00:00
Luke Dashjr
5fa873a82f
Merge g595 via qt_handle_autostart_errors-0.15
2024-06-21 19:28:12 +00:00
Luke Dashjr
9c15a9c4bf
Merge 24718 via fix_rpc_docs_pr24718-25+knots
2024-06-21 19:28:12 +00:00
Luke Dashjr
bf5509eb89
Merge 24479 via bugfix_settings_numberval
2024-06-21 19:28:12 +00:00
Luke Dashjr
43f1fa075d
Merge g506 via qt_qrcode_sizefixes
2024-06-21 19:28:12 +00:00
Luke Dashjr
040857352f
Merge 22417 via bpchild_closefds
2024-06-21 19:28:12 +00:00
Luke Dashjr
a061fd5e53
Merge rpc_addconnection_mainnet
2024-06-21 19:28:12 +00:00
Luke Dashjr
9cd373e067
Merge g236 via gui_init_walleterror_cont
2024-06-21 19:28:12 +00:00
Luke Dashjr
8362aefd8d
Merge bugfix_gui_drop_abc_confusing_hack
2024-06-21 19:28:12 +00:00
Luke Dashjr
1af4338b08
Merge g152 via gui_notify_setup_bg
2024-06-21 19:28:12 +00:00
Luke Dashjr
fa39da2f81
Merge 19419 via listwalletdir_skip_data
2024-06-21 19:28:12 +00:00
Luke Dashjr
b669f389b3
Merge 18194 via bugfix_gui_edit_sendaddr-mini
2024-06-21 19:28:12 +00:00
Luke Dashjr
19584338c3
Merge bugfix_rpc_getbalance_hacky
2024-06-21 19:28:12 +00:00
Luke Dashjr
33dc061ece
Merge rpcarg_type_per_name
2024-06-21 19:28:12 +00:00
Luke Dashjr
acf739dbe0
Merge 14485 via fadvise-27+knots
2024-06-21 19:28:12 +00:00
Luke Dashjr
a8accd7c82
Merge 29614 via bufferedfile_fclose
2024-06-21 19:28:12 +00:00
Luke Dashjr
7df97cf7ce
Merge 10731 via log_more_uacomment
2024-06-21 19:28:12 +00:00
Luke Dashjr
c4e125636c
Merge 9524 via rpc_pruneblkchain0
2024-06-21 19:28:12 +00:00
Luke Dashjr
17bff6beab
Merge http_bind_error+extra
2024-06-21 19:28:12 +00:00
Luke Dashjr
eb5ff377cf
Merge 14968 via http_bind_error
2024-06-21 19:28:12 +00:00
Luke Dashjr
2dc1722f60
Merge 13789 via bugfix_asm_pragmas
2024-06-21 19:28:12 +00:00
Luke Dashjr
5bb4fd232d
Merge 5416 via sys_libsecp256k1
2024-06-21 19:28:12 +00:00
Luke Dashjr
97b8727d34
Merge 2241 via sys_leveldb
2024-06-21 19:28:12 +00:00
Luke Dashjr
2d213fc7c8
Merge 30283 via upnp_228_compat-22
2024-06-21 19:28:12 +00:00
Cory Fields
6430144243
upnp: add compatibility for miniupnpc 2.2.8
...
See: c0a50ce33e#30283
Rebased-From: 8acdf66540
2024-06-21 20:54:10 +00:00
Luke Dashjr
23e0821ee7
Merge fix_evhttp_util_nodep-25
2024-06-21 19:28:12 +00:00
Luke Dashjr
990080d6c6
Merge 29577 via fix_objcxxflags_pr29577-27
2024-06-21 19:28:12 +00:00
Luke Dashjr
52ed096953
Sanity check to detect LLVM bug 96267
2024-06-21 18:43:58 +00:00
Luke Dashjr
56c1c4bd3e
Merge branch 'sys_leveldb' into HEAD
2024-06-21 18:43:07 +00:00
Luke Dashjr
46a8ac09a1
QA/sanity_tests: Run dbwrapper_SanityCheck
2024-06-21 18:35:52 +00:00
MarcoFalke
9691293934
refactor: performance-for-range-copy in psbt.h
...
Github-Pull: #30253
Rebased-From: fab01b5220
2024-06-12 20:50:06 +00:00
Luke Dashjr
5f111fde36
Bugfix: Restore <string> include in rest.cpp
2024-06-10 14:36:41 +00:00
Andrew Toth
793e8f5f87
rest: read raw block in rest_block and deserialize for json
...
Note that for speed this commit also removes the proof of work and
signet signature checks before returning the block in getblock.
It is assumed if a block is stored it will be valid.
Github-Pull: #26415
Rebased-From: e710cefd57
2024-06-10 14:05:11 +00:00
Andrew Toth
5417597c6c
rpc: read raw block in getblock and deserialize for verbosity > 0
...
Note that for speed this commit also removes the proof of work and
signet signature checks before returning the block in getblock.
It is assumed if a block is stored it will be valid.
Github-Pull: #26415
Rebased-From: 95ce0783a6
2024-06-10 14:05:11 +00:00
Andrew Toth
bbbcf92de2
zmq: read raw block with ReadRawBlockFromDisk
...
Github-Pull: #26415
Rebased-From: 38265cc14e
2024-06-10 14:05:11 +00:00
Andrew Toth
18aa12fb5c
blockstorage: check nPos in ReadRawBlockFromDisk before seeking back
...
ReadRawBlockFromDisk assumes a non-null pos that has an nPos >= 8.
This simple check makes the function safer to call in the future,
so callers don't need to worry about causing UB if the pos is null.
Github-Pull: #26415
Rebased-From: da338aada7
2024-06-10 14:05:11 +00:00
Hennadii Stepanov
cafe533fef
build: Add missed definition for AM_OBJCXXFLAGS
...
Github-Pull: #29577
Rebased-From: bd8f0354ba
2024-06-08 01:56:49 +00:00
Hennadii Stepanov
ba35920542
build: Fix building fuzz binary on on SunOS / illumos
...
Github-Pull: #30216
Rebased-From: 3299abce94
2024-06-04 11:17:16 +01:00
Luke Dashjr
fe21e5bc03
GUI: setWalletActionsEnabled: Keep historyAction disabled if privacy mode is already on
2024-05-28 20:52:06 +00:00
Hennadii Stepanov
80032d6917
qt: 27.1rc1 translations update
2024-05-28 10:18:55 +01:00
Cory Fields
2ae23d32c7
rpc: avoid copying into UniValue
...
These are simple (and hopefully obviously correct) copies that can be moves
instead.
Github-Pull: #30115
Rebased-From: d7707d9843
2024-05-23 19:40:02 +00:00
Jon Atack
31adcfa171
test: add GetAddedNodeInfo() CJDNS regression unit test
...
Github-Pull: #30085
Rebased-From: d0b047494c
2024-05-23 09:44:19 +01:00
Jon Atack
9cdb9edfb8
p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo()
...
Addnode (manual) peers connected to us via the cjdns network are currently not
detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false.
This causes the following issues:
- RPC `getaddednodeinfo` incorrectly shows them as not connected
- CConnman::ThreadOpenAddedConnections() continually retries to connect them
Github-Pull: #30085
Rebased-From: 684da97070
2024-05-22 09:49:00 +01:00
Cory Fields
3c26058da2
crypto: disable asan for sha256_sse4 with clang and -O0
...
Clang is unable to compile the Transform function for that combination of
options.
Github-Pull: #30097
Rebased-From: 141df0a288
2024-05-16 08:41:52 +08:00
Jon Atack
eda384078d
wallet: introduce setfeerate, an improved settxfee in sat/vB
...
Github-Pull: #20391
Rebased-From: 8e863e3d3ce457c9ca26a12e8fd6beac2f50aa7d (diff-minimised)
2024-05-15 23:06:59 +00:00
Jon Atack
01e51a3976
test: add ValueFromFeeRate/CFeeRate unit tests
...
(partial: CFeeRate in 0.21 doesn't take FeeEstimateMode)
2024-05-15 23:06:59 +00:00
Luke Dashjr
8baf00e0c4
core_io: Add ValueFromFeeRate helper
2024-05-15 23:06:59 +00:00
Jon Atack
09c51e7f7d
policy: add CFeeRate::SatsToString helper without units
2024-05-15 23:06:59 +00:00
Luke Dashjr
318c798852
Disable lowmem flushing in test that needs determinism
2024-05-15 23:01:19 +00:00
Luke Dashjr
1a01c95586
Make lowmem threshold configurable
2024-05-15 23:01:18 +00:00
Luke Dashjr
71eae9faab
util: Log reasoning when returning true from SystemNeedsMemoryReleased
2024-05-15 23:00:40 +00:00
Luke Dashjr
aed813cc1b
Flush dbcache early if system is under memory pressure
...
No point forcing memory to get pushed out to swap just to cache db changes when we can write the db changes out instead
2024-05-15 23:00:40 +00:00
Luke Dashjr
ea8bfa036c
Diff-minimise
2024-05-15 22:58:12 +00:00
w0xlt
ce9524f0b5
rpc: allow dumptxoutset to dump human-readable data
...
Co-authored-by: Shashwat Vangani <shaavan.github@gmail.com>
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
2024-05-15 22:58:11 +00:00
Luke Dashjr
21a3dd4198
Diff-minimise
2024-05-15 22:52:48 +00:00
Elichai Turkel
8463aef09f
Optimized siphash implementation
...
Github-Pull: #18014
Rebased-From: 409c2e345225716a29c856b24e1c232a643a52ef
2024-05-15 22:52:41 +00:00
Luke Dashjr
25ea55c25d
GUI: Add a warning prompt when sending to an already-used address
2024-05-15 22:40:50 +00:00
Luke Dashjr
668e18bf70
GUI: Use warning indicator for send coins entries with reused addresses
2024-05-15 22:40:50 +00:00
Luke Dashjr
bde17b6138
GUI: Implement BitcoinAddressUnusedInWalletValidator
2024-05-15 22:40:50 +00:00
Luke Dashjr
4b943c42fd
GUI: QValidatedLineEdit: Add support for a warning-but-valid state
2024-05-15 22:40:50 +00:00
Luke Dashjr
42e4f13246
GUI: WalletModel: Wrap checkAddressForUsage and findAddressUsage
2024-05-15 22:40:50 +00:00
Luke Dashjr
0ba948aa4f
GUI: SendConfirmationDialog: Enable changing the actual buttons used
...
Both buttons can be replaced with other standard buttons
2024-05-15 22:40:49 +00:00
Luke Dashjr
08ce9ecf45
GUI: SendConfirmationDialog: Defer button setup until exec
2024-05-15 22:40:49 +00:00
Luke Dashjr
86c5b4f00a
GUI: Add GUIUtil::dateStr
2024-05-15 22:40:49 +00:00
Luke Dashjr
82908e28a5
interfaces/wallet: Add checkAddressForUsage and findAddressUsage
2024-05-15 22:40:49 +00:00
Luke Dashjr
9378ceaac6
Merge branch 'getaddressinfo_txids' into HEAD
2024-05-15 22:40:39 +00:00
Evan Klitzke
79e4722e62
Try to use posix_fadvise with CBufferedFile
...
This primarily affects blocks when bitcoin is launched with -reindex, as
that causes the block files to be loaded as CBufferedFile objects one at
a time as the reindex progresses.
Co-Authored-By: Luke Dashjr <luke-jr+git@utopios.org>
Github-Pull: #14485
Rebased-From: 289e88b3133107f8a54184d8316559c7cf8ddb12
2024-05-15 21:46:18 +00:00
furszy
6e24242027
wallet: default wallet migration, modify inconvenient backup filename
...
On default legacy wallets, the backup filename starts with an "-" due
to the wallet name being empty. This is inconvenient for systems who
treat what follows the initial "-" character as flags.
Github-Pull: #29586
Rebased-From: a951dba3a9
2024-05-15 21:09:13 +00:00
Jon Atack
9f05a705fc
test: AddNode() CJDNS regression unit tests
...
Rebased-From: be4541abe5
2024-05-15 19:54:45 +00:00
Jon Atack
b5efac03db
p2p, bugfix: correctly detect CJDNS addnode entries in AddNode()
...
Rebased-From: 28823f30dc
2024-05-15 19:54:44 +00:00
Jon Atack
ac5c317924
test: add GetAddedNodeInfo() CJDNS regression unit test
...
Github-Pull: #30085
Rebased-From: d0b047494c
2024-05-15 19:50:16 +00:00
Jon Atack
4421251d7d
p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo()
...
Addnode (manual) peers connected to us via the cjdns network are currently not
detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false.
This causes the following issues:
- RPC `getaddednodeinfo` incorrectly shows them as not connected
- CConnman::ThreadOpenAddedConnections() continually retries to connect them
Github-Pull: #30085
Rebased-From: 684da97070
2024-05-15 19:50:16 +00:00
Martin Zumsande
6ec27a6673
init, validation: Fix -reindex option with an existing snapshot
...
This didn't work for two reasons:
1.) GetSnapshotCoinsDBPath() was used to retrieve the path.
This requires coins_views to exist, but the initialisation only happens later
(in CompleteChainstateInitialization) so the node hits an assert in
CCoinsViewDB& CoinsDB() and crashes.
2.) The snapshot was already activated, so it has the mempool attached.
Therefore, the mempool needs to be transferred back to the ibd
chainstate before deleting the snapshot chainstate.
Github-Pull: #29726
Rebased-From: e57f951805
2024-05-15 19:36:12 +00:00
Roman Zeyde
4842324b7d
RPC: Keep .cookie if it was replaced after being generated
...
Github-Pull: #28784
Rebased-From: d95dde9441fb791046394ed3784a840a54ef2ab9
2024-05-15 17:56:41 +00:00
Luke Dashjr
4fcbd58ba5
GUI: Avoid unnecessary BIP 21 references (Knots supports BIP 20 also)
2024-05-15 17:07:59 +00:00
Luke Dashjr
e310e17cad
Diff-minimise
2024-05-15 16:47:00 +00:00
Luke Dashjr
27d2a53e5f
Revert "test: Remove Windows-specific code from system_tests/run_command"
...
This reverts commit 51bc1c7126
2024-05-15 16:47:00 +00:00
Luke Dashjr
88fe778d9d
BufferedFile: fclose at destruction
...
This is currently indirectly implied by src/bench/load_external.cpp:LoadExternalBlockFile
"The file will be closed by LoadExternalBlockFile()."
2024-05-15 16:14:59 +00:00
Luke Dashjr
7c70b396b1
configure: Add unsupported --with-system-libsecp256k1 configure flag
2024-05-15 00:06:03 +00:00
willcl-ark
0ba11cf908
rpc: move UniValue in blockToJSON
...
Without explicitly declaring the move, these UniValues get copied,
causing increased memory usage. Fix this by explicitly moving the
UniValue objects.
Used by `rest_block` and `getblock` RPC.
Github-Pull: #30094
Rebased-From: b77bad309e
2024-05-14 08:14:33 +08:00
willcl-ark
dedf319b08
gui: don't permit port in proxy IP option
...
Fixes : #809
Previously it was possible through the GUI to enter an IP address:port
into the "Proxy IP" configuration box. After the node was restarted the
errant setting would prevent the node starting back up until manually
removed from settings.json.
Github-Pull: https://github.com/bitcoin-core/gui/pull/813
Rebased-From: 10c5275ba4
2024-05-13 11:58:00 +08:00
furszy
d1289a1300
gui: fix create unsigned transaction fee bump
...
Github-Pull: https://github.com/bitcoin-core/gui/pull/812
Rebased-From: 671b7a3251
2024-05-13 11:57:12 +08:00
