Luke Dashjr
4be2187282
Merge 29614 via bufferedfile_fclose
2025-03-05 03:27:08 +00:00
Luke Dashjr
cbfa6e5b9b
Merge 10731 via log_more_uacomment
2025-03-05 03:27:08 +00:00
Luke Dashjr
85dc1e1fc3
Merge 9524 via rpc_pruneblkchain0
2025-03-05 03:27:08 +00:00
Luke Dashjr
d0f65e2f2e
Merge http_bind_error+extra
2025-03-05 03:27:08 +00:00
Luke Dashjr
def0d7f8f8
Merge 14968 via http_bind_error
2025-03-05 03:27:08 +00:00
Luke Dashjr
d2d3b434b0
Merge 18490 via bugfix_symcheck_pe_case
2025-03-05 03:27:08 +00:00
Luke Dashjr
da1e5f9ffa
Merge 18427 via 2020mingwthrd-mini
2025-03-05 03:27:08 +00:00
Luke Dashjr
506a39d893
Merge 18902 via fix_gitdir_again
2025-03-05 03:27:08 +00:00
Luke Dashjr
5bd6cb2eb0
Merge 18818 via guix_reltar_autogen_distclean
2025-03-05 03:27:08 +00:00
Luke Dashjr
8d7611a7ec
Merge 31408 via qafix_framework_pr31408-27
2025-03-05 03:27:08 +00:00
Luke Dashjr
45a2e5951c
Merge nowarn_unused-function
2025-03-05 03:27:08 +00:00
Luke Dashjr
ad6a12d7bb
Merge nowarn_unreachable-code
2025-03-05 03:27:08 +00:00
Luke Dashjr
efeece9f03
Merge lint_relaxer-28+knots
2025-03-05 03:27:08 +00:00
Luke Dashjr
7d6366b565
Merge 15155 via test_external_bcli
2025-03-05 03:27:08 +00:00
Luke Dashjr
22df203e4c
Merge 13789 via bugfix_asm_pragmas
2025-03-05 03:27:08 +00:00
Luke Dashjr
3d44110252
Merge 5416 via sys_libsecp256k1
2025-03-05 03:27:08 +00:00
Luke Dashjr
91af8d0c4e
Merge 2241 via sys_leveldb
2025-03-05 03:27:08 +00:00
Luke Dashjr
b7dd579993
Merge 5872 via subdir_incl_compat
2025-03-05 03:27:08 +00:00
Luke Dashjr
eb4575a9de
CI: Disable libbitcoinkernel (not supported by Knots)
2025-02-28 04:55:33 +00:00
Luke Dashjr
5faa5027fa
QA: Allow test_runner to pass without full RPC coverage
2025-02-25 19:38:14 +00:00
Luke Dashjr
b24c622edf
lint: Allow including bitcoin-config.h without IWYU pragma
2025-02-25 19:38:14 +00:00
Luke Dashjr
eed7bb6496
lint-python: Allow for some style differences
2025-02-25 19:38:14 +00:00
Luke Dashjr
8a4e129845
Diff-minimise
2025-02-25 18:40:17 +00:00
Luke Dashjr
0706589391
QA: system_tests: Avoid unnecessary WINE detection
2025-02-25 18:40:17 +00:00
Hennadii Stepanov
54570647ca
test: Drop --enable-external-signer
configure option
...
This option is enabled by default.
Github-Pull: #29868
Rebased-From: 13c012f81f3bba4a1dc806c253c77d3daa16ae7c
2025-02-25 18:40:17 +00:00
Hennadii Stepanov
8c8249b545
build: Re-enable external signer support for Windows
...
Github-Pull: #29868
Rebased-From: 944717a08a99b750f27a0a81512b3cac92d39923
2025-02-25 18:40:17 +00:00
Luke Dashjr
ad3dedaacb
test: Reintroduce Windows support in system_tests/run_command
test
...
Github-Pull: #29868
Rebased-From: b083581226c5d1b0cf027f84ed9b1596221dd8c0
2025-02-25 18:40:17 +00:00
Hennadii Stepanov
36f3c2f5c9
subprocess, refactor: Replace custom __USING_WINDOWS__
with WIN32
...
The `WIN32` macro is used across the entire code base to designate
building for Windows.
Github-Pull: #29868
Rebased-From: 847d10e38a97f3b874af868e0fdcc3bdaab7342b
2025-02-25 18:40:17 +00:00
Hennadii Stepanov
e2d768731e
subprocess: Fix quote issue on Windows
...
Github-Pull: #29868
Rebased-From: 7d0fcb2fa68a24ef0db133e0d7929e897478dca4
2025-02-25 18:40:17 +00:00
Hennadii Stepanov
1a2cefdb80
subprocess: Make Popen::wait()
return process exit code on Windows
...
This behavior is expected and consistent with the non-Windows
implementation.
The code is borrowed from `Popen::poll()`.
Github-Pull: #29868
Rebased-From: 47d49ea90fcdf9ff79857c741fd5eb4db1b93124
2025-02-25 18:40:17 +00:00
Luke Dashjr
c5f919a88c
Bugfix: subprocess: Avoid breaking open/close/fileno names elsewhere
2025-02-25 18:40:17 +00:00
Luke Dashjr
ab4b68fff3
bitcoin-tidy: Disable bitcoin-unterminated-logprintf
2025-02-24 20:02:23 +00:00
Luke Dashjr
3c618efb42
fs_helpers: Guard _POSIX_C_SOURCE check within #ifdef
2025-02-24 20:01:00 +00:00
furszy
f56b53cc49
test: add coverage for migrating standalone imported keys
...
Github-Pull: #31374
Rebased-From: cdd207c0e4
2025-02-24 20:00:08 +00:00
furszy
02e5d9485c
test: add coverage for migrating watch-only script
...
Github-Pull: #31374
Rebased-From: 297a876c98
2025-02-24 20:00:06 +00:00
furszy
3eead328db
wallet: migration, avoid loading wallet after failure when it wasn't loaded before
...
During migration failure, only load wallet back into memory when the
wallet was loaded prior to migration. This fixes the case where BDB
is not supported, which implies that no legacy wallet can be loaded
into memory due to the lack of db writing functionality.
This commit also improves migration backup related comments to better
document the current workflow.
Co-authored-by: Ava Chow <github@achow101.com>
Github-Pull: #31451
Rebased-From: 589ed1a8ea
2025-02-24 19:57:55 +00:00
Luke Dashjr
3abda6a001
Bugfix: QA: test_node: Ensure debug.log exists at start of assert_debug_log
2025-02-24 19:48:11 +00:00
Luke Dashjr
14b872b852
Bugfix: QA: mempool_fee_histogram: Compare to actual vsize/fee rather than hard-coding a particular constant
2025-02-21 23:31:39 +00:00
Luke Dashjr
514352ba26
RPC/Mempool: Avoid extra decrement of unsigned below 0 when building fee histogram
2025-02-21 23:31:39 +00:00
Luke Dashjr
0aa11b9842
QA: interface_rest: Check /mempool/info/with_fee_histogram matches RPC
2025-02-21 23:31:39 +00:00
Luke Dashjr
9ebe86025c
Bugfix: RPC/blockchain: Actually round feerates down for getmempoolinfo fee histograms
2025-02-21 23:31:39 +00:00
Luke Dashjr
d10e35ab13
Bugfix: QA: Ensure mempool_fee_histogram expected feerates rounded down
...
As of #22949 , fees are rounded up based on feerate, but going the opposite direction from fee to feerate still must round down.
2025-02-21 23:31:39 +00:00
Luke Dashjr
40f27a5e7b
RPC/mempool: Skip result type checks for fee_histogram in getmempoolinfo
...
fee_histogram contains both dynamic-named group objects as well as a numeric total_fees, which the check cannot handle
Long-term, the result is expected to change to avoid this, so just skip it for now
2025-02-21 23:31:39 +00:00
Luke Dashjr
446ba48045
Bugfix: RPC/blockchain: Correct type of "to_feerate" result in getmempoolinfo fee histogram
2025-02-21 23:31:39 +00:00
Luke Dashjr
68f7f13ad0
RPC/blockchain: getmempoolinfo: Return fee_histogram in older format (only)
2025-02-21 23:31:39 +00:00
Kiminuo
521f921d83
RPC/mempool: Add "to" (end of range) field to fee histogram
...
Co-authored-by: Jonas Schnelli <dev@jonasschnelli.ch>
Co-authored-by: Jon Atack <jon@atack.com>
Github-Pull: #21422
Rebased-From: 0b87ba9bc3a2ada2839af0e1af868fcd5ddb9155
2025-02-21 23:31:39 +00:00
Luke Dashjr
64e50cbb7d
Add mempool/fee_histogram option to rest API
2025-02-21 23:31:39 +00:00
Luke Dashjr
b9b320c02a
RPC/blockchain: getmempoolinfo: Enable specifying with_fee_histogram as a boolean to use a sensible default set of fee rate levels
2025-02-21 23:31:39 +00:00
Luke Dashjr
eb93c8bf4b
Bugfix: QA: Ensure mempool_fee_histogram can adapt to feerate rounding correctly
...
Caution: This implementation is for a post-#22949 codebase
2025-02-21 23:31:39 +00:00
Jonas Schnelli
ecd567ae63
RPC/blockchain: Consider ancestor, descendant, and combined fee rates for histogram in getmempoolinfo
...
Test changes from: 0b6ba66238
Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
Co-authored-by: Jon Atack <jon@atack.com>
2025-02-21 23:31:39 +00:00