fee_histogram contains both dynamic-named group objects as well as a numeric total_fees, which the check cannot handle
Long-term, the result is expected to change to avoid this, so just skip it for now
Original commit: 0b6ba66238
Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
Co-authored-by: Jon Atack <jon@atack.com>
Github-Pull: #21422
Rebased-From: c5e53d0d21
It is UB to exceed the bounds of the buffer when doing pointer
arithemetic. That means the following is not a valid bounds check:
if (start + 4 <= limit)
Because if we were at the end of the buffer, we wouldn't be
allowed to add 4 anyway. Instead, this must be written as:
if (limit - start >= 4)
Basic forms of this issue are flagged by UBSan. If building with
-fsanitize=undefined, the following test trips an error:
[ RUN ] HASH.SignedUnsignedIssue
.../leveldb/util/hash.cc:30:15: runtime error: applying non-zero offset 4 to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /usr/local/google/home/davidben/leveldb/util/hash.cc:30:15 in
[ OK ] HASH.SignedUnsignedIssue (1 ms)
(cherry picked from commit 578eeb702ec0fbb6b9780f3d4147b1076630d633)
Github-Pull: #31671
Rebased-From: a8844b23ab02a48a05940987f70bf23d4fa76f58
exFAT is known to cause corruption on macOS. See #28552.
Therefore we should warn when using this fs format for either the blocks
or data directories.
Github-Pull: #31453
Rebased-From: df1ba101419729aafa382d970ee605e2a6273e26
`p2p_dns_seeds.py` would try to connect to the DNS server configured on
the machine and resolve `dummySeed.invalid`.
To block that configure an unavailable proxy which will be used also to
connect to the name server. The test needs 2 successful connections to
other peers (two Python `P2PInterface`s) and they work in spite of the
unavailable proxy because they are on `127.0.0.1` (`NET_UNROUTABLE`) and
the proxy is not used for that.
Github-Pull: #31646
Rebased-From: 2ed161c5ce
`feature_config_args.py` uses a proxy address of `1.2.3.4`. This results
in actually trying to open TCP connections over the internet to
`1.2.3.4:9050`.
The test does not need those to succeed so use `127.0.0.1:1` instead.
Also avoid `-noconnect=0` because that is interpreted as `-connect=1`
which is interpreted as `-connect=0.0.0.1` and a connection to
`0.0.0.1:18444` is attempted.
Github-Pull: #31646
Rebased-From: a5746dc559
Create a separate status for transactions that are confirmed in
a block that is assumed valid pending background validation.
Use the same icon as for transactions with a single confirmation.
Github-Pull: #28616
Rebased-From: 3e281590c7dfa6d97191c41792d3b9604632d1a7
