fanquake
dd73c22976
Merge bitcoin/bitcoin#28486 : test, bench: Initialize and terminate use of Winsock properly
...
fd4c6a10f2459272d639/src/bench/addrman.cpp (L124)https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsacleanup ) that `WSAStartup` and `WSACleanup` must be balanced:
> There must be a call to `WSACleanup` for each successful call to `WSAStartup`. Only the final `WSACleanup` function call performs the actual cleanup. The preceding calls simply decrement an internal reference count in the WS2_32.DLL.
That is not the case for our unit tests because the `SetupNetworking()` call is a part of the `BasicTestingSetup` fixture and is invoked multiple times, while `~CNetCleanup()` is invoked once only, at the end of the test binary execution.
This PR fixes Winsock DLL initialization and termination.
More docs:
- https://learn.microsoft.com/en-us/windows/win32/winsock/initializing-winsock
- https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsastartup
- https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsacleanup
Fix https://github.com/bitcoin/bitcoin/issues/28940 .
ACKs for top commit:
maflcko:
lgtm ACK fd4c6a10f2
2023-11-29 17:14:34 +00:00
