1332 Commits

Author	SHA1	Message	Date
fanquake	7b701fef58	Merge #17049: contrib: Bump gitian descriptors for 0.20 ... fa1ad8f06e build: Bump gitian descriptor versions (MarcoFalke) Pull request description: Bump the gitian descriptor versions as a follow-up to #17007. Also fixes #17027 with a cherry-pick, and bump the manpages. ACKs for top commit: fanquake: ACK fa1ad8f06e Tree-SHA512: c3b669c3797e5febb51a8dd01e2621a7544a291e080d73c47a2a12ea9da84ff904533e68792e2e869ebbdc2226b2fee7517214549e6cc7e988f175098f7c412c	2019-10-04 14:39:59 -04:00
gchuf	dffae5a5ad	scripts: update copyright_header script to include additional files ... Includes .sh and .bash-completion files in the script as well	2019-10-04 17:47:55 +02:00
MarcoFalke	fa1ad8f06e	build: Bump gitian descriptor versions	2019-10-04 09:17:57 -04:00
Brian Solon	0b1dcd32bf	contrib: fix minor typos in makeseeds.py ... See #17020	2019-10-03 14:50:08 -04:00
Carl Dong	93cb974980	gitian: Use split-debug.sh for Win builds ... Debug splitting was first introduced in 7e7eb2724, then gitian-linux.yml changed to using split-debug.sh in 9d2536208. Here we change gitian-win.yml to use split-debug.sh as well.	2019-10-02 16:21:22 -04:00
Wladimir J. van der Laan	0218171a24	contrib: Remove invalid nodes from seeds list	2019-10-02 08:51:12 +02:00
Wladimir J. van der Laan	3b09f2b9d9	net: 0.19 hardcoded seeds update	2019-10-01 11:38:48 +02:00
Wladimir J. van der Laan	801d341f3a	contrib: makeseeds: More fancy output	2019-10-01 11:39:41 +02:00
Wladimir J. van der Laan	ed76299bea	contrib: makeseeds: Limit per network, instead of total	2019-10-01 11:39:35 +02:00
Wladimir J. van der Laan	c254a9ef69	contrib: makeseeds: dedup by ip,port ... Handle the multiple ports per IP case (as that's a criterion later).	2019-10-01 11:39:29 +02:00
Wladimir J. van der Laan	3314d87966	contrib: makeseeds: Factor out ASN lookup	2019-10-01 11:39:14 +02:00
Wladimir J. van der Laan	301c2b1ab5	contrib: makeseeds: Improve logging and filtering ... - Change regular expression to cover recent versions, as well as subversions with custom uacomment, and improve readability. - Vary uptime requirements per network (onions are allowed to have less uptime, to make sure we get enough of them) - Add deduplication step (to allow simple concatentation of multiple seeds files). - Log of number of nodes (per network) after every step.	2019-10-01 11:38:48 +02:00
Tim Akinbo	3284e6c09a	scripts: search for next position of magic bytes rather than fail ... document seek method for next position of magic bytes	2019-09-30 18:10:47 +00:00
fanquake	bd3f5a90ec	build: remove mingw linker workaround from win gitian descriptor ... This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (#6900). However, it should no longer be required, as we have switched to Bionic (#13171), and that has a far newer version of binutils. binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192	2019-09-23 08:38:42 +08:00
Jon Layton	6aab7649d3	doc: Fix whitespace errs in .md files, bitcoin.conf, Info.plist.in, and find_bdb48.m4	2019-09-17 03:21:22 -04:00
fanquake	59681beb89	Merge #16477: build: skip deploying plugins we dont use in macdeployqtplus ... 1ac7b7f66b scripts: filter more qt plugins we don't use in macdeployqtplus (fanquake) 57cdd0697d scripts: misc cleanups in macdeployqtplus (fanquake) 51729a4dfa scripts: use format() in macdeployqtplus (fanquake) 1c37e81694 scripts: add type annotations to macdeployqtplus (fanquake) Pull request description: I frequently run `make deploy` while testing on macOS to get a properly light themed .app. With a brew installed Qt, this currently results in a pretty bloated executable: | branch | .app size | .dmg size | `make deploy` time | | ------- | --------- | --------- | --------------------- | | master (febf3a856b) | 235mb | 86mb | 38s | | This PR (da98f6d470d236c027b7eb8b5f5552fdca04e803) | 51mb | 21mb | 22s | Similar change to dd367ff8c9. ```diff 'QtGui.framework'], 'pluginPath': '/usr/local/opt/qt/plugins', 'qtPath': '/usr/local/opt/qt'} -[('platforminputcontexts', 'libqtvirtualkeyboardplugin.dylib'), - ('geoservices', 'libqtgeoservices_esri.dylib'), - ('geoservices', 'libqtgeoservices_mapboxgl.dylib'), - ('geoservices', 'libqtgeoservices_nokia.dylib'), - ('geoservices', 'libqtgeoservices_itemsoverlay.dylib'), - ('geoservices', 'libqtgeoservices_osm.dylib'), - ('geoservices', 'libqtgeoservices_mapbox.dylib'), - ('sceneparsers', 'libgltfsceneexport.dylib'), - ('sceneparsers', 'libgltfsceneimport.dylib'), - ('platforms', 'libqwebgl.dylib'), +[('platforms', 'libqwebgl.dylib'), ('platforms', 'libqoffscreen.dylib'), ('platforms', 'libqminimal.dylib'), ('platforms', 'libqcocoa.dylib'), ('platformthemes', 'libqxdgdesktopportal.dylib'), - ('printsupport', 'libcocoaprintersupport.dylib'), - ('webview', 'libqtwebview_webengine.dylib'), - ('webview', 'libqtwebview_darwin.dylib'), - ('geometryloaders', 'libdefaultgeometryloader.dylib'), - ('geometryloaders', 'libgltfgeometryloader.dylib'), ('styles', 'libqmacstyle.dylib'), - ('canbus', 'libqttinycanbus.dylib'), - ('canbus', 'libqtpassthrucanbus.dylib'), - ('canbus', 'libqtvirtualcanbus.dylib'), - ('canbus', 'libqtpeakcanbus.dylib'), ('bearer', 'libqgenericbearer.dylib'), - ('imageformats', 'libqgif.dylib'), - ('imageformats', 'libqwbmp.dylib'), - ('imageformats', 'libqwebp.dylib'), - ('imageformats', 'libqico.dylib'), - ('imageformats', 'libqmacheif.dylib'), - ('imageformats', 'libqjpeg.dylib'), - ('imageformats', 'libqtiff.dylib'), - ('imageformats', 'libqicns.dylib'), - ('imageformats', 'libqtga.dylib'), - ('imageformats', 'libqmacjp2.dylib'), - ('texttospeech', 'libqtexttospeech_speechosx.dylib'), - ('generic', 'libqtuiotouchplugin.dylib'), - ('renderplugins', 'libscene2d.dylib'), - ('gamepads', 'libdarwingamepad.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_thai.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_openwnn.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_hangul.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_pinyin.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_tcime.dylib')] + ('generic', 'libqtuiotouchplugin.dylib')] ``` ACKs for top commit: laanwj: ACK 1ac7b7f66b (purely Python code review and the fact that this passes travis, cannot run this on a mac) dongcarl: tested ACK 1ac7b7f66b Tree-SHA512: 5974eeaf7229bb5bde2b283c1331ec57ee87f624db146401f6b77dee4ee5502e0bd669958a46205f10398a371f8e6c91ddacb9f0e1943f9f7d042fb6de7957a8	2019-09-10 10:53:59 +10:00
fanquake	b5a8d0cff1	Merge #15450: gui: Create wallet menu option ... 613de61a04 Add Create Wallet menu action (Andrew Chow) 9b41cbb28f Expose wallet creation to the GUI via WalletController (Andrew Chow) 78863e2900 Add CreateWalletDialog to create wallets from the GUI (Andrew Chow) 60adb21c7a Optionally allow AskPassphraseDialog to output the passphrase (Andrew Chow) bc6d8a3662 gui: Refactor OpenWalletActivity (João Barbosa) Pull request description: This PR adds a menu option to create a new wallet. When clicked, a `CreateWalletDialog` will be created and prompt the user to name the wallet and choose whether to disable private keys, make a blank wallet, and encrypt the wallet. If the wallet is encrypted, the wallet will be born encrypted with the wallet first created blank, then encrypted, and then a new HD seed generated and set. To allow the newly created wallets to be encrypted, some changes to how encrypting a wallet works. Instead of encrypting and locking the wallet, the wallet will be encrypted and then unlocked. This is also an extra belt-and-suspenders check to make sure that encryption worked. ACKs for top commit: fanquake: ACK 613de61a04 - re-reviewed on macOS. I'm going to merge this now. It's had a stack of review, and as mentioned multiple times above, lets get this into `master` so it can get more testing pre `v0.19.0`. Tree-SHA512: 3f22cc20b13703ffc90d366ae9133114832fea77f4f319da7fd85eb454f2f0bd5d7e1e6e20284dea2f370d8574f83b45669dcbbe506b994410d32e8e7a6fa877	2019-09-07 14:45:58 +08:00
setpill	7fb7acfc20	Set init stop timeout to 10 min ... `bitcoind` can take a long time to flush its db cache to disk upon shutdown. Most init files send a `SIGKILL` after a timeout of 1 minute, causing unclean shutdowns and triggering a long "Rolling forward" at the next startup. Increasing this timeout to 10 minutes should reduce how often this occurs, especially during IBD. fixup! Set ProtectHome in systemd service file	2019-09-06 17:03:04 +02:00
Andrew Chow	78863e2900	Add CreateWalletDialog to create wallets from the GUI ... Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>	2019-09-05 20:36:57 -04:00
Carl Dong	0065ead5eb	contrib: guix: Remove ssp spec file hack ... This hack is no longer needed after fixing our cross-compilation search paths.	2019-09-05 14:50:56 -04:00
Carl Dong	0093a5869a	contrib: guix: More robust search paths, add checks ... - store_path() previously only worked for cross compilation packages, we remove this assumption here - Add CROSS_GCC_LIB variable which points to where gcc libs/headers are located - Add gcc libs/headers to our CROSS_*_PATH environment variables - Check that all directories in CROSS_*_PATH are sane	2019-09-05 14:50:44 -04:00
Ben Woosley	3d0a82cff8	devtools: Accomodate block-style copyright blocks ... Without this, `copyright_header.py report . verbose` reports: ------------------------------------------------------------------------------- 1 with unexpected copyright holder names ./build_msvc/libsecp256k1_config.h -------------------------------------------------------------------------------	2019-09-03 14:41:43 -04:00
Ben Woosley	b21680baf5	test/contrib: Fix invalid escapes in regex strings ... Flagged by flake8 v3.6.0, as W605, plus a few others identified incidentally, e.g. 59ffecf66cf4d08c4b431e457b083878d66a3fd6. Note that r"\n" matches to "\n" under re.match/search.	2019-09-03 14:38:38 -04:00
fanquake	fc5b756bae	Merge #16556: Fix systemd service file configuration directory setup ... f3b57f4a1c Unrecommend making config file owned by bitcoin (setpill) 870d4152df Set ProtectHome in systemd service file (setpill) 639a416e37 Chgrp config dir to bitcoin in systemd service (setpill) aded0528f0 Improve clarity of systemd service file comments (setpill) Pull request description: Rationale: ran into a bug with the systemd service file, fixed it locally and figured I might as well contribute my fix. Also fixed some unrelated confusing phrasing in the comments of the same file, after discussion in IRC. ACKs for top commit: sipsorcery: tACK f3b57f4a1c (nothing changed since previous tACK). ryanofsky: utACK f3b57f4a1c. Only change since last review is removing ConfigurationDirectoryMode churn in early commits Tree-SHA512: 2188345878925b9e8a5c2c3df8dfba443720e2252a164db54a8e1d8007846721497b2d98c56f1d9b60a9a9ed4fdb1156c7b02c699616b220a9b614671617d32a	2019-08-29 11:55:03 +08:00
setpill	870d4152df	Set ProtectHome in systemd service file ... Further hardening; the service should be run with as many restrictions as possible without breaking it.	2019-08-20 10:54:14 +02:00
setpill	639a416e37	Chgrp config dir to bitcoin in systemd service ... Rather than making the config dir world-readable, which potentially leaks RPC credentials, the group of the directory is changed to the one the service is executed as.	2019-08-20 10:54:14 +02:00
setpill	aded0528f0	Improve clarity of systemd service file comments ... The phrasing seemed to indicate that the options specified in ExecStart= could not be specified in the config file, necessitating their inclusion in the service file. However, the options in the config file simply get overridden by any specified in ExecStart=.	2019-08-20 10:54:14 +02:00
fanquake	3d50fe2c1f	scripts: move update-translations.py to maintainer-tools repo	2019-08-20 11:14:00 +08:00
fanquake	6c27fa0f09	scripts: remove github-merge.py ... This script has been moved to the bitcoin-core/bitcoin-maintainer-tools repository, after discussion in a core dev meeting. The rationale being that it is also useful to other projects, and thus should be moved to a more general repository. Meeting log: http://www.erisian.com.au/bitcoin-core-dev/log-2019-08-15.html See also: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/28	2019-08-19 19:16:57 +08:00
Wladimir J. van der Laan	390874c722	qt: Remove menu icons	2019-08-15 13:05:10 +02:00
Chuf	36f7697cf6	doc: Fix typos in COPYRIGHT ... Fixed a couple of typos	2019-08-14 17:28:26 +00:00
Aaron Clauson	9063911017	sipsorcery gitian key.	2019-08-10 05:39:47 +02:00
fanquake	1ac7b7f66b	scripts: filter more qt plugins we don't use in macdeployqtplus ... phonon is no longer a part of Qt as of version 5	2019-07-29 09:35:51 +08:00
fanquake	57cdd0697d	scripts: misc cleanups in macdeployqtplus	2019-07-29 08:28:41 +08:00
fanquake	51729a4dfa	scripts: use format() in macdeployqtplus	2019-07-29 08:28:41 +08:00
fanquake	1c37e81694	scripts: add type annotations to macdeployqtplus	2019-07-29 08:28:41 +08:00
Carl Dong	65f8da08df	symbol-check: Disallow libX11-*.so.* shared libraries ... They should no longer be needed as we build QT without libX11/XLib libraries now.	2019-07-17 17:09:48 -04:00
Carl Dong	751549b52a	contrib: guix: Additional clarifications re: substitutes	2019-07-12 12:31:55 -04:00
Carl Dong	cd3e947f50	contrib: guix: Various improvements. ... - Clearer and more accurate prose - Pin `guix pull' to commit rather than branch - Just use `use-module' instead of `define-module' - Use `bash-minimal' instead of `bash' - Remove unneeded `tcsh' from manifest - Explicitly use `python-3.7' - Add comments about how {native,cross}-toolchains are produced and why	2019-07-12 11:42:36 -04:00
Carl Dong	8dff3e48a9	contrib: guix: Clarify SOURCE_DATE_EPOCH.	2019-07-12 11:42:09 -04:00
Carl Dong	3e80ec3ea9	contrib: Add deterministic Guix builds.	2019-07-12 00:48:39 -04:00
fanquake	1088b90cba	Merge #16327: scripts and tools: Update ShellCheck linter ... 1ac454a384 Enable ShellCheck rules (Hennadii Stepanov) Pull request description: Enable some simple ShellCheck rules. Note for reviewers: `bash` and `shellcheck` on macOS are different from ones on Ubuntu. For local tests the latest `shellcheck` version 0.6.0 should be used (see #15166). ACKs for top commit: practicalswift: utACK 1ac454a384 dongcarl: utACK 1ac454a fanquake: ACK 1ac454a384 Tree-SHA512: 8d0a3a5c09fe1a0c22120178f5e6b80f81f746f8c3356b7701ff301c117acb2edea8fe08f08fb54ed73f94b1617515fb239fa28e7ab4121f74872e6494b6f20e	2019-07-05 09:19:23 +08:00
Hennadii Stepanov	1ac454a384	Enable ShellCheck rules ... Enabled ShellCheck rules: SC1087 SC2001 SC2004 SC2005 SC2006 SC2016 SC2028 SC2048 SC2066 (note that IFS already contains only a line feed) SC2116 SC2166 SC2181 SC2206 SC2207 SC2230 SC2236	2019-07-04 19:35:25 +03:00
fanquake	dfdcb3dfe5	Merge #16330: docs: Use placeholder instead of key expiration date ... 88fd556a96 Use placeholder instead of key expiration date (Hennadii Stepanov) Pull request description: Use a placeholder instead of the actual expiration date, so that the documentation doesn't require updating every time an expiry date changes. ACKs for top commit: fanquake: ACK 88fd556a96 Tree-SHA512: 391707833cc0e701cf560ec82fd91368468c90a95f85e4ce2a211b20d12463c85775142f28a3536b57c5f6950b9e6e0785632f6f071fa2180bc8aab53008603b	2019-07-04 11:03:52 +08:00
Hennadii Stepanov	88fd556a96	Use placeholder instead of key expiration date	2019-07-03 17:55:51 +03:00
Hennadii Stepanov	ca11606858	Fix: "Bitcoin Core" -> "The Bitcoin Core"	2019-06-29 18:58:52 +03:00
Hennadii Stepanov	621463d7df	Drop no-longer-relevant copyright holder name	2019-06-29 18:50:39 +03:00
Hennadii Stepanov	01fafe55a1	Include Objective-C source files ... The copyright_header.py script will process Objective-C source files (*.mm) as other ones.	2019-06-29 18:35:45 +03:00
MarcoFalke	e115a21f79	Merge #16223: devtools: Fetch and display ACKs at sign-off time in github-merge ... 0e01e4522e devtools: Fetch and display ACKs at sign-off time in github-merge (Wladimir J. van der Laan) Pull request description: - Fetch the ACKs only at sign-off time. This makes sure that any last-minute ACKs are included (fixes #16200) - Show a list of ACKs that will be included and their author before signing off, and warn if there are none   There's a slight change to the merge commit format—before it was ``` ACKs for commit 88884c: (list of ACKs, could be empty) ``` now it is ``` ACKs for top commit: jnewbery: ACK 5ebc6b0eb ... (list of ACKs cannot be empty) ``` or ``` Top commit has no ACKs. ``` I don't think there's a reason to have the abbreviated commit ID there, after all the full commit id is already in the beginning of the merge commit message, and at least the abbreviated one is in every single ACK message. ACKs for commit 0e01e4: fanquake: ACK 0e01e4522e Tree-SHA512: 8576de016137d71cfc101747e9bb6779c13e0953cf2babee7afc9972bf2bd46f6912be4982b54fa5abf4d91e98e8fdae6b4ca3eef7d6892b7a5f04a7017b6882	2019-06-24 15:09:24 -04:00
Wladimir J. van der Laan	0e01e4522e	devtools: Fetch and display ACKs at sign-off time in github-merge ... - Fetch the ACKs only at sign-off time. This makes sure that any last-minute ACKs are included (fixes #16200) - Show a list of ACKs and their author before signing off, and warn if there are none	2019-06-17 14:54:35 +02:00
fanquake	47d981e827	Merge #16186: doc/lint: Fix spelling errors identified by codespell 1.15.0 ... b748bf6f50 Fix spelling errors identified by codespell 1.15.0 (Ben Woosley) Pull request description: Note all changes are to comments / documentation. After this commit, the only remaining output is: ``` $ test/lint/lint-spelling.sh src/test/base32_tests.cpp:14: fo ==> of, for src/test/base64_tests.cpp:14: fo ==> of, for ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt ``` Note: * I ignore several valid alternative spellings ~, but changed homogenous to homogeneous as the latter is a more specific term according to the Google dictionary definitions I found~ * homogenous is present in tinyformat, hence should be addressed upstream * process' is correct only if there are plural processes ACKs for commit b748bf: practicalswift: ACK b748bf6f50 fanquake: ACK b748bf6f50 Tree-SHA512: 9add7044643ce015e0a44d8b27a3f300d72c485ffff550fb6491a17f14528085289ec5caddfe02f291ea9b2cded38a0dd3079652a054e2d7fe2ff4f7b53db5d7	2019-06-16 09:57:09 +08:00
fanquake	7524376a81	Merge #16201: devtools: Always use unabbreviated commit IDs in github-merge.py ... 067fba563 devtools: Always use unabbreviated commit IDs in github-merge.py (Wladimir J. van der Laan) Pull request description: Always put the unabbreviated commit IDs in the generated commit messages and other places. This prevents the developer's `core.abbrev` git setting from leaking through and is better against ambiguity too. ACKs for commit 067fba: MarcoFalke: ACK 067fba5631 (replaces `h` with `H`, didn't test) promag: ACK 067fba5631, from the documentation https://git-scm.com/docs/pretty-formats: fanquake: ACK 067fba5631. Tested by merging this PR into master, then merging a second PR ontop and checking that full commit hashes were being used. Also checked documentation linked to above. Did not check that this works when a different `core.abbrev` is set locally. Tree-SHA512: a851d10490cd8bcd8bca29094b08a6b9f883cfe1b0767ccda7ca789e4c8eff6260a4d82c33cb3d9bab01dd30ac8c9100cb7adbcb1911bb399d9385c1e1f15ecd	2019-06-14 13:38:52 +08:00
Wladimir J. van der Laan	067fba5631	devtools: Always use unabbreviated commit IDs in github-merge.py ... Always put the unabbreviated commit IDs in the generated commit messages and other places. This prevents the developer's `core.abbrev` git setting from leaking through and is better against ambiguity too.	2019-06-13 10:21:36 +02:00
MarcoFalke	473c6b7c5a	Merge #16184: scripted-diff: gitian: Use REFERENCE_DATETIME directly. ... 993aa414d3 scripted-diff: gitian: Use REFERENCE_DATETIME directly. (Carl Dong) Pull request description: Fixes regression introduced by #16141. ``` -BEGIN VERIFY SCRIPT- sed -i 's#\$REFERENCE_DATE\\\\\\ \$REFERENCE_TIME#\$REFERENCE_DATETIME#g' contrib/gitian-descriptors/* -END VERIFY SCRIPT- ``` ----- Note that this could have been fixed by escaping properly, but using `REFERENCE_DATETIME` directly is simpler. Future note: `REFERENCE_{DATE{,DATETIME},TIME}` is a bit ridiculous. At the very _least_ gitian should use epoch, as it is the most parse-able, and preferably set SOURCE_DATE_EPOCH. ACKs for commit 993aa4: Tree-SHA512: 8457e5fffde66e1d2b846547b6807416b884c171f63569f76dfefd498d2a58ad6f9eb93931eb6cfc7ff38c6b460b0c488ca87d1a68bc630c48f365a74b6ee163	2019-06-11 12:10:00 -04:00
Ben Woosley	b748bf6f50	Fix spelling errors identified by codespell 1.15.0 ... After this commit, the only remaining output is: $ test/lint/lint-spelling.sh src/test/base32_tests.cpp:14: fo ==> of, for src/test/base64_tests.cpp:14: fo ==> of, for ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt Note: * I ignore several valid alternative spellings * homogenous is present in tinyformat, hence should be addressed upstream * process' is correct only if there are plural processes	2019-06-11 17:18:16 +02:00
MarcoFalke	6899ef3f0e	Merge #16143: tests: Mark unit test blockfilter_index_initial_sync as non-deterministic ... c061be1e2f tests: Mark unit test blockfilter_index_initial_sync as non-deterministic (practicalswift) Pull request description: Mark unit test `blockfilter_index_tests/blockfilter_index_initial_sync` as non-deterministic. Before this PR: ``` $ contrib/devtools/test_deterministic_coverage.sh 500 [2019-06-04 09:58:57] Measuring coverage, run #1 of 500 [2019-06-04 10:00:33] Measuring coverage, run #2 of 500 [2019-06-04 10:02:19] Measuring coverage, run #3 of 500 The line coverage is non-deterministic between runs. Exiting. The test suite must be deterministic in the sense that the set of lines executed at least once must be identical between runs. This is a necessary condition for meaningful coverage measuring. --- gcovr.run-1.txt 2019-06-04 10:00:33.389059973 +0000 +++ gcovr.run-3.txt 2019-06-04 10:03:45.619491207 +0000 @@ -72,7 +72,7 @@ hash.h 54 33 61% 71,74-77,82,85-89,111,113,128,147-148,175,178-181 httprpc.cpp 120 3 2% 31,34-35,38-40,46,49,52,54,56,58,70,73-74,76,78-79,81,83-84,89,91,94-95,97,99-101,103,106-107,111-112,117-119,121-122,125,128,130,132,134-136,138-139,142,145,148,151-153,156-160,163-166,171,173-175,180-182,185,187,189-190,192,195,198-199,201,203-204,212,215,217,219-222,224,227-228,230,232,237,239-240,243-245,247-251,254,256,259,261-264,266-267 [* 205-206,208-209] httpserver.cpp 312 6 1% 46,49-50,53,55,80-81,90,92-93,96-98,101,104,106-109,111-112,114,118,120-122,126,128-129,153,155,157-158,164,166-178,180,182,184-188,192,194-196,198-199,201-202,204-205,207-208,213,216-221,225,228-232,236-239,243-244,247-254,256-258,264-267,270-271,274,279,281-282,286,288-290,292-293,297,299-300,303-307,309-310,312-317,322-328,330,332,335,339,341-342,346,352-353,355,358,360,364,368-369,375,378,381-384,388-391,393-394,398-400,402,404-406,409,411-412,414,416,426,428-431,433-434,438,440-441,443,445-446,449,451-455,457-459,463-464,466-469,471-473,475-477,479,482,484,487,490-493,496-497,499-500,502,504,506,508-509,511,513-514,517,519,521-522,527,529-533,535,538,540-543,550-555,558,560-562,570,572-574,577-582,585-590,594-597,600,602-604,606-609,611,614,616,619,621,625-626,628-629,631-632,634-635,640,642-643,646,648-651,653,655-656 -index/base.cpp 149 94 63% 20,22-25,28,66,98,102-103,117-118,140-141,145-146,155,163,175,177-178,181-182,184-185,200-201,203,212,214-215,219-221,228-229,234,236,240,243-244,247-249,258-260,262,270,292-294,308-309 [* 263] +index/base.cpp 149 97 65% 20,22-25,28,66,98,102-103,117-118,140-141,145-146,155,163,175,177-178,181-182,184-185,200-201,203,212,214-215,219-221,228-229,234,236,240,243-244,247-249,258-260,262,270,308-309 [* 263] index/base.h 3 2 66% 77 index/blockfilterindex.cpp 199 134 67% 70,79,81,84-88,91,122,139,142,179-181,184-185,188-189,193-194,201-202,207,233,258,262-263,265-266,268,271-272,274,277,279,284,286,288-289,294,301-302,304,322,329,332-333,350,371,373,438,440-441,444,446,449,455-456,459,461,464,466 [* 162-163] index/blockfilterindex.h 4 4 100% @@ -358,7 +358,7 @@ util/validation.cpp 5 1 20% 12,15-17 validation.cpp 2167 808 37% 291,293,297-300,302,330,332,340,348,355-357,359,362,364-365,368,371,380,382-383,385-386,388-389,396,398-402,406-413,415,417,419,422-425,439-440,442-443,446,449,455-458,461-464,467,469-470,472,474,476,492,494-495,502-503,505-507,511-513,515,517,523,526,528,533,535,540,542-544,550,552-556,558-560,564,574,578-583,586,590-591,594-596,601-602,607-608,611-612,616-617,619-621,635-636,638,640,647-648,651,657-658,660-662,665-667,673,675,677-678,682-683,690,693,700-701,703-705,709-710,713-714,716,719-720,724-727,733-735,737-739,741-743,747-748,751-752,754,757-764,771,773-774,776-779,785-788,793-794,796-800,815-816,818-822,825,827,830,835,838-839,841-843,846-848,850,853,859,864-867,875,877-879,884-885,887-891,895,899-900,904-906,908-909,911,930-931,933,936,942,944-950,952,959,962,965-968,972,978,982-984,990-991,994-996,999,1003-1004,1011,1013,1015-1019,1022-1023,1026-1032,1056,1065,1079,1091,1108,1112,1114-1118,1125,1127-1130,1133-1135,1138-1139,1147,1149,1151-1152,1155,1197,1199-1201,1206-1209,1211-1212,1226,1230,1232-1234,1236,1238-1241,1245-1246,1256,1258,1260-1262,1264-1266,1268,1278-1280,1282-1283,1286,1289,1291-1292,1294-1302,1305-1311,1319-1323,1330,1332-1333,1336-1339,1379,1383-1384,1395,1401,1405-1407,1411-1414,1423-1428,1438-1440,1451,1455,1458,1471,1480,1497,1503,1519,1525,1527-1530,1532-1533,1536,1538-1539,1549,1551,1553,1555,1559-1562,1571,1573,1578,1580,1582-1584,1588-1589,1594-1597,1601-1606,1613-1616,1619-1623,1630,1632,1635,1637,1639-1640,1642-1646,1658,1660,1675,1688,1711,1713-1715,1742,1755,1760,1765,1769,1811,1815,1817,1841-1845,1855,1942,1946-1947,1956,1984-1986,1991-1992,1994,1996-1999,2005-2007,2010-2012,2022-2023,2028-2031,2038-2039,2042,2044,2049,2058-2061,2064,2114-2115,2117-2118,2120-2124,2152-2153,2156,2159-2163,2165-2169,2171-2172,2176-2178,2187-2188,2191-2194,2199,2207-2211,2215-2220,2224,2227-2230,2235,2237-2238,2261-2263,2265,2274,2278,2286,2301,2303-2304,2306-2309,2311,2313-2318,2320,2322,2325,2327-2328,2330,2332-2334,2338,2340,2343-2344,2407-2410,2430,2445-2447,2507-2509,2511-2514,2518,2520-2521,2523-2524,2561,2564,2590,2592-2593,2595-2598,2603,2620,2626,2658,2719,2724,2773,2776-2777,2779,2781,2783,2785-2788,2791,2793-2795,2799,2801-2802,2805,2807-2809,2813,2816,2818-2821,2825-2826,2832-2834,2841-2845,2848,2854,2858-2859,2861,2865-2868,2872-2875,2880,2884-2885,2890-2891,2894-2895,2897,2900-2906,2908,2910,2912,2918-2922,2924,2928-2929,2940,3002-3005,3009-3010,3026-3028,3036-3037,3039-3040,3045,3053,3056,3077,3080,3090,3112,3118,3129,3133,3135-3136,3141-3142,3150,3190-3193,3259,3268,3273,3277,3282-3285,3303,3314,3321-3324,3338-3341,3345-3346,3348-3350,3360,3372,3392,3397,3403,3406,3408,3435-3441,3443,3468-3469,3485,3487-3488,3492-3493,3534-3536,3542,3547-3549,3552,3565-3566,3601-3602,3610,3628,3630,3632,3645,3647,3649-3651,3653,3657,3659,3661-3669,3675-3680,3686-3687,3691,3693-3697,3702,3704,3706-3708,3711-3718,3720,3724,3726-3729,3748,3750-3752,3754,3758-3759,3763,3765,3767,3772,3774,3777-3778,3780-3781,3783,3787-3788,3790,3792-3794,3798-3800,3823,3825,3828,3830,3832,3836-3838,3841-3843,3845,3848,3850,3854-3856,3858-3859,3861-3862,3864-3867,3870-3873,3875-3876,3879,3882-3883,3886-3893,3899,3901,3905-3909,3911-3915,3922-3924,3926-3928,3931,3933-3934,3940-3942,3945-3947,3952,3954-3955,3957,3960-3961,3964,3966,3968-3972,3975,3977,3980,3982,3985,3987-3988,3992-3996,3998-4006,4008-4009,4011-4012,4014,4016,4019,4021-4022,4024-4026,4028-4032,4037-4041,4043-4045,4047,4050,4053-4054,4057,4060-4064,4066-4067,4069-4075,4079-4080,4086,4089-4091,4094-4097,4101,4106,4108,4110,4112-4114,4116-4117,4119,4121,4123-4124,4126,4128-4130,4132-4134,4138-4142,4144-4147,4154,4158-4163,4166-4169,4172-4173,4177,4179-4180,4183,4185,4187-4189,4191-4193,4195,4197-4201,4207-4208,4212,4220-4223,4230,4232-4233,4237,4240,4243,4247,4249,4251,4253-4255,4265-4266,4277,4279,4282,4285-4287,4292-4293,4296,4298,4302,4305-4306,4310-4311,4315-4318,4360,4363-4367,4370,4377,4397,4412,4415-4416,4418,4421-4422,4424,4426-4429,4433-4437,4439-4441,4448-4452,4454-4456,4458,4460,4462-4467,4471-4475,4477,4480-4481,4486-4488,4493,4496-4503,4505,4507-4511,4513-4514,4517-4519,4529-4531,4546,4600,4638-4639,4647,4653,4662-4664,4696,4703-4704,4718,4720,4723,4725,4727,4730,4732-4733,4736,4738-4739,4742,4744-4745,4750,4752-4757,4761-4765,4769-4770,4774-4776,4779-4781,4783-4785,4787-4790,4793-4794,4800-4801,4803,4807,4809-4810,4812-4813,4815-4816,4823,4827,4829,4831-4832,4834-4835,4838-4840,4842,4845,4848-4849,4853,4855-4856,4858-4863,4866-4872,4877,4891,4907 [* 1085-1086,1140-1141,1513-1514,2201-2202,2428,3569-3570,4400-4401,4442,4453,4504,4522-4523,4526-4527,4818-4819,4873-4874] validation.h 19 5 26% 338,350-352,356-363,366,484 -validationinterface.cpp 81 50 61% 78-82,85-86,112-113,116,119-120,123-124,126-128,130,133-136,151-153,163-165,169-171 +validationinterface.cpp 83 60 72% 78-82,85-86,112-113,116,133-136,151-153,163-165,169-171 validationinterface.h 9 4 44% 94,105,112,118,135 versionbits.cpp 92 27 29% 33,35-36,38-39,48-50,52-54,56-57,61-62,67-71,73,75-76,80,82-83,91,98,100,102-103,105,109-110,113-118,121-122,124,127,129-130,134,137,141,149,151,153-155,159,177,179,184,194,196,199,201,204,206 [* 26] versionbits.h 1 1 100% @@ -400,5 +400,5 @@ zmq/zmqpublishnotifier.h 5 0 0% 12,31,37,43,49 zmq/zmqrpc.cpp 23 3 13% 16,18,20,23,33-35,37,40-47,51,62,64-65 ------------------------------------------------------------------------------ -TOTAL 52472 7784 14% +TOTAL 52474 7797 14% ------------------------------------------------------------------------------ $ ``` After this PR: ``` $ contrib/devtools/test_deterministic_coverage.sh 500 [2019-06-03 14:45:25] Measuring coverage, run #1 of 500 [2019-06-03 14:48:15] Measuring coverage, run #2 of 500 [2019-06-03 14:50:49] Measuring coverage, run #3 of 500 [2019-06-03 14:52:20] Measuring coverage, run #4 of 500 [2019-06-03 14:53:49] Measuring coverage, run #5 of 500 … [2019-06-04 09:04:58] Measuring coverage, run #496 of 500 [2019-06-04 09:07:42] Measuring coverage, run #497 of 500 [2019-06-04 09:10:32] Measuring coverage, run #498 of 500 [2019-06-04 09:13:26] Measuring coverage, run #499 of 500 [2019-06-04 09:16:32] Measuring coverage, run #500 of 500 Coverage test passed: Deterministic coverage across 500 runs. $ ``` ACKs for commit c061be: Tree-SHA512: 00cd55b4371290d8587ab667c64249bc31d26cc9dc3dd519677eb91ddb9dbc5333dfbdef5e90c7a0d74eecd24757113e7ec3eda836859ddc033b1de715df81b6	2019-06-11 07:37:03 -04:00
Carl Dong	993aa414d3	scripted-diff: gitian: Use REFERENCE_DATETIME directly. ... Fixes regression introduced by #16141 -BEGIN VERIFY SCRIPT- sed -i 's#\$REFERENCE_DATE\\\\\\ \$REFERENCE_TIME#\$REFERENCE_DATETIME#g' contrib/gitian-descriptors/* -END VERIFY SCRIPT-	2019-06-10 15:14:05 -04:00
Wladimir J. van der Laan	70d77fff3a	Merge #16162: scripts: add key for Michael Ford (fanquake) to trusted keys list ... 8081927c33 scripts: add key for fanquake to trusted keys list (fanquake) Pull request description: Adding my key to the [trusted keys list](https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/trusted-keys) to join the maintainer group. I'll gain merge access and will continue with all triage/repo management work. I'll be focusing primarily on build system development with some guidance from theuni. Some maintainer related discussion from the Core Dev meetup in Amsterdam is available [here](http://diyhpl.us/wiki/transcripts/bitcoin-core-dev-tech/2019-06-06-maintainers/). ACKs for commit 808192: MarcoFalke: ACK 8081927c33 laanwj: ACK, this matches the key I have 8081927c33: meshcollider: ACK, this matches the key I have from the CoreDev New York 2018 keysigning party 8081927c33 IlyasRidhuan: ACK. 8081927c33 matches the key I have. Tree-SHA512: 63c390f5ede316263def2f9a897a1046d4ae58e4ea758f379164c6c5afce4928e2c9463fbcac004742838fd4ac1e48679e7a2a0f9095fd134a900f9064584056	2019-06-08 16:45:06 +02:00
Wladimir J. van der Laan	af05f36b60	Merge #16141: build: remove GZIP export from gitian descriptors ... bc8863b819 depends: remove usage of TAR_OPTIONS (fanquake) 3ff1f2a319 build: remove export GZIP from gitian descriptors (fanquake) Pull request description: The `GZIP` environment variable is [deprecated](https://www.gnu.org/software/gzip/manual/gzip.html#Environment), and everywhere that we invoke `gzip` we are already passing `-9n` directly, i.e: ```base find bitcoin-* | sort | tar --no-recursion --mode='u+rw,go+r-w,a+X' --owner=0 --group=0 -c -T - | gzip -9n > ../$SOURCEDIST ``` ```bash GZIP="-9n" gzip -h gzip: warning: GZIP environment variable is deprecated; use an alias or script Usage: gzip [OPTION]... [FILE]... ``` ACKs for commit bc8863: Tree-SHA512: 2d5277f7bf096fd5bd0dda47dfaf2dc7a31cc5d91eb8cb42db9cbe060d07dff66bf8e1122a89a3a1b597a3b39dbf8d9a8da4f02e642f58e451ce9fb24cc59769	2019-06-07 14:45:34 +02:00
fanquake	8081927c33	scripts: add key for fanquake to trusted keys list	2019-06-07 09:48:12 +02:00
fanquake	bc8863b819	depends: remove usage of TAR_OPTIONS	2019-06-05 15:39:17 +02:00
practicalswift	c061be1e2f	tests: Mark unit test blockfilter_index_initial_sync as non-deterministic	2019-06-04 12:28:04 +02:00
fanquake	3ff1f2a319	build: remove export GZIP from gitian descriptors	2019-06-03 15:51:59 -04:00
Steven Roose	a352d2ae5f	Don't GPG sign intermediate commits with github-merge tool	2019-05-31 19:22:02 +01:00
Wladimir J. van der Laan	c7cfd20a77	Merge #16086: contrib: use newer config.guess & config.sub in install_db4.sh ... 00fade007c contrib: use newer config.guess & config.sub in install_db4.sh (fanquake) Pull request description: The `config.guess` and `config.sub` packaged with `db-4.8.30.NC.tar.gz` are fairly old (2009) and fail to identify some system types i.e `ppc64le`. Replace them with more modern versions before configuring `db4`. Fixes #16064. ACKs for commit 00fade: jamesob: tACK 00fade007c dongcarl: utACK 00fade007c laanwj: Tested ACK 00fade007c Tree-SHA512: 54f9f2b0fcf802e6a284214035fcb3833577aa5881beb293921b6036b71d0bcd0872f06d14ddc76a4f8c0eee7ba71461dcc99dc907e7ddb5ae403fc02b245538	2019-05-29 14:21:21 +02:00
fanquake	97dce72261	contrib: add curl as a required program in gitian-build.py	2019-05-28 12:51:53 -04:00
fanquake	00fade007c	contrib: use newer config.guess & config.sub in install_db4.sh	2019-05-24 15:48:34 -04:00
Hennadii Stepanov	e0eae1b4a4	Make --setup command independent ... A user can run 'gitian-build.py --setup' ignoring signer and version options. Get rid of warning about macOS build during setup for free.	2019-05-20 21:01:30 +03:00
MarcoFalke	f49b8d4783	Merge #13998: Scripts and tools: gitian-build.py improvements and corrections ... 0f22a0cf2f Fix gitian-build.py --verify option (Hennadii Stepanov) 4c56a798c0 Set/unset USE_LXC, USE_VBOX, USE_DOCKER explicitly (Hennadii Stepanov) cbbd98863b Fix Docker related issues for gitian-build.py (Hennadii Stepanov) Pull request description: 1. The Docker does not depend on `apt-cacher-ng` package. Ref: #14002. 2. Do not try to install the Docker if `docker.service` is detected on the system (e.g., the Docker was installed manually). Fix https://github.com/bitcoin/bitcoin/pull/13623#issuecomment-405684241 by **Sjors**. 3. Prevent the setting of more than one environment variable for the `gitian-builder` (an alternative to #13999). E.g., USE_LXC being set shadows USE_DOCKER; for details see [`gitian-builder/libexec/make-clean-vm`](93a62c7d7d/libexec/make-clean-vm (L7)): ```sh VMSW=KVM if [ -n "$USE_LXC" ]; then VMSW=LXC elif [ -n "$USE_VBOX" ]; then VMSW=VBOX elif [ -n "$USE_DOCKER" ]; then VMSW=DOCKER fi ``` 4. The [`gitian-builder/bin/gverify`](https://github.com/devrandom/gitian-builder/blob/master/bin/gverify) script returns the exit code 1 if a signature verification ends with 'BAD SIGNATURE' or 'MISMATCH' by design. This PR allows to see the verification results for all signatures without a premature fail of the `gitian-build.py` script. Ref: #14014. ACKs for commit 0f22a0: Tree-SHA512: 55f8a5cffa20d0c745f51a687f3199cea015fa616e56a0aee4c25b5ca0985036c61e8cf1922515338d8c6a85f873674ebe7a9a56a5069d65a187e383150f1a83	2019-05-20 13:01:37 -04:00
Wladimir J. van der Laan	149b3477ec	Merge #15840: Contrib scripts: Filter IPv6 by ASN ... 316b8b2339 Filter IPv6 by ASN (Emil) Pull request description: Improves IP diversity for hardcoded seednodes. ACKs for commit 316b8b: Tree-SHA512: ae90427efa317d59125457bf8bfd077fd115c0921e1cc13cebd855206498546a026ccc18f039d1963d64d9be9497c41f4a21214fb565d5d11a9635ad12836421	2019-05-20 17:54:05 +02:00
Hennadii Stepanov	0f22a0cf2f	Fix gitian-build.py --verify option ... The gitian-builder/bin/gverify script returns the exit code 1 if a signature verification ends with 'BAD SIGNATURE' or 'MISMATCH' by design. This commit allows to see the verification results for all signatures without a premature fail of the gitian-build.py script.	2019-05-18 19:35:02 +03:00
Hennadii Stepanov	4c56a798c0	Set/unset USE_LXC, USE_VBOX, USE_DOCKER explicitly ... This prevents the setting of more than one environment variable for the gitian-builder (e.g., USE_LXC being set shadows USE_DOCKER; for details see gitian-builder/libexec/make-clean-vm).	2019-05-18 19:34:31 +03:00
Hennadii Stepanov	cbbd98863b	Fix Docker related issues for gitian-build.py ... The Docker does not depend on apt-cacher-ng package. Do not try to install the Docker if docker.service is detected on the system (e.g., the Docker was installed manually). Also small style corrections were applied.	2019-05-18 19:34:04 +03:00
MarcoFalke	c89a63412e	Merge #15863: scripts and tools: Ensure repos are up-to-date in gitian-build.py ... feed98e189 Ensure repos are up-to-date (Hennadii Stepanov) Pull request description: These steps are provided by the [release process](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#setup-and-perform-gitian-builds). ACKs for commit feed98: Tree-SHA512: ad6876d211e524cf6b8dbe4f0f026b77792c8ae3b728e1419f17d5679766603d21c057a7866c183794c814b914a9e4584e16fc501bec77af7e3472a34bd4d913	2019-05-17 16:47:52 -04:00
MarcoFalke	87dbf89271	Merge #15239: scripts and tools: Move non-linux build source tarballs to "bitcoin-binaries/version" directory ... 5c04814b2d Move non-linux source tarball to bitcoin-binaries (Hennadii Stepanov) Pull request description: Currently, if a user makes a non-linux (`--os=w`, `--os=m` or `--os=wm`) gitian building with the `gitian-build.py` script, source tarballs are not moved to the `bitcoin-binaries/${VERSION}` directory. This PR fixes this bug. ~~In addition, the `src` subdirectory in the `gitian-builder/build/out` directory is no longer used as unnecessary.~~ ACKs for commit 5c0481: fanquake: utACK 5c04814 ken2812221: utACK 5c04814b2d Tree-SHA512: 8648b6cbf502c012b12642783870e37aea385bd5f4cba5cb577fee924c09685e9a117676be502e4d4783c7a8ab31a2bd495970eec42a42d78e86ac5d39323091	2019-05-10 07:59:02 -04:00
Wladimir J. van der Laan	79046d5749	Merge #15939: gitian: Remove Windows 32 bit build ... fa193dc8e6 doc: Remove win32 from the release process (MarcoFalke) faf666f814 Remove Windows 32 bit build (MarcoFalke) Pull request description: The Windows 32 bit build has been removed from https://bitcoincore.org/en/download/, so unless there are complaints, we don't need to build it even ACKs for commit fa193d: fanquake: utACK fa193dc8e6 Tree-SHA512: d6f2976a2e0c407698f720b00ac23ec4056626de4eff8621f4c5581120af0460afd1bdef72329cc0e7d92afca48d94ae5fce6777cb36bfabb60b8034ff08fd88	2019-05-09 21:22:24 +02:00
Wladimir J. van der Laan	a65fd92f7b	Merge #15766: scripts and tools: Upgrade gitian image before signing ... beda0dae95 Upgrade gitian image before signing (Hennadii Stepanov) Pull request description: The package upgrade in the Ubuntu repositories in the period between the building and the signing causes (particularly, using LXC) an error: ``` Creating package manifest Could not download some packages, please run gbuild --upgrade ``` For example, the [`busybox-initramfs`](https://packages.ubuntu.com/bionic/busybox-initramfs) package was [upgraded](http://changelogs.ubuntu.com/changelogs/pool/main/b/busybox/busybox_1.27.2-2ubuntu3.2/changelog) from `1:1.27.2-2ubuntu3.1` to `1:1.27.2-2ubuntu3.2` on 2019-03-06. This PR forces gitian image upgrade for the `--sign` command. Ref: [devrandom/gitian-builder/target-bin/grab-packages.sh](04ab7c1218/target-bin/grab-packages.sh) ``` #!/bin/sh # Get an installed package manifest set -e cd /var/cache/apt/archives # make sure all packages with installed versions are downloaded # (except for held packages, which may not be available for download) dpkg-query -W -f '${Status}\t${Package}=${Version}\n' | grep -v ^hold | cut -f2- | xargs -n 50 apt-get install -q --reinstall -y -d > /tmp/download.log grep "cannot be downloaded" /tmp/download.log && { echo Could not download some packages, please run gbuild --upgrade 1>&2 ; exit 1 ; } sha256sum *.deb | sort --key 2 ``` ACKs for commit beda0d: laanwj: utACK beda0dae95 fanquake: utACK beda0da Tree-SHA512: e2e3b3e3719e098d266ceec39bd69b950344a4eb2f43ae6ad3e696add70f743b363cc83676e339f7caa207d6478029869a8af01fe1f6d5690d2857003f7d8ce8	2019-05-09 17:29:44 +02:00
MarcoFalke	fa193dc8e6	doc: Remove win32 from the release process	2019-05-08 11:48:18 -04:00
MarcoFalke	faf666f814	Remove Windows 32 bit build	2019-05-03 13:41:27 -04:00
Hennadii Stepanov	feed98e189	Ensure repos are up-to-date ... These steps are provided by the release process.	2019-04-21 09:52:48 +03:00
nkostoulas	942ff2054b	contrib: gh-merge: Use pagination to fetch all review comments	2019-04-17 20:21:45 +01:00
Emil	316b8b2339	Filter IPv6 by ASN	2019-04-17 17:32:05 +00:00
Hennadii Stepanov	beda0dae95	Upgrade gitian image before signing	2019-04-07 16:16:05 +03:00
MarcoFalke	904129b35d	Merge #15255: [tests] Remove travis_wait from lint script ... 8b8d8eeae9 Remove travis_wait from lint script (Graham Krizek) Pull request description: Using the `travis_wait` command in conjunction with `set -o errexit` causes problems. The `travis_wait` command will correctly log the command's output if successful, but if the command fails the process exits before the `travis_wait` command can dump the logs. This will hide important debugging information like error messages and stack traces. We ran into this in #15196 and it was very hard to debug because output was being suppressed. `travis_wait` was being used because the `contrib/verify-commits/verify-commits.py` script can sometimes run for a long time without producing any output. If a script runs for 10 minutes without logging anything, the CI run times out. The `travis_wait` command will extend this timeout by logging a message for you, while sending stderr and stdout to a file. This PR removes the `travis_wait` command from our CI system and adds additional logging to the `verify-commits.py` script so it doesn't make Travis timeout. ACKs for commit 8b8d8e: MarcoFalke: utACK 8b8d8eeae9 Tree-SHA512: 175a8dd3f4d4e03ab272ddba94fa8bb06875c9027c3f3f81577feda4bc8918b5f0e003a19027f04f8cf2d0b56c68633716a6ab23f95b910121a8d1132428767d	2019-03-29 11:23:08 -04:00
Cory Fields	43ae1e96ed	release: Update the Windows Codesigning certificate	2019-03-28 00:07:38 -04:00
MarcoFalke	fa1c073154	contrib: gh-merge: Include review comments in merge commit	2019-03-22 12:03:04 -04:00
Douglas Roark	204c729457	Add Gitian key for droark ... I've signed 0.18.0rc1 and 0.18.0rc2, and I intend to sign every release moving forward.	2019-03-16 16:33:39 -07:00
Wladimir J. van der Laan	cede01b416	Merge #15609: scripts and tools: Set 'distro' explicitly ... b8705a0915 Set 'distro' explicitly (Hennadii Stepanov) Pull request description: The [gitian-builder](https://github.com/devrandom/gitian-builder) implicitly uses `ubuntu` as a default distro. [bin/gbuild#L237](81edd2fc8e/bin/gbuild (L237)): ```ruby distro = build_desc["distro"] || "ubuntu" ``` This PR sets a gitian building distro explicitly in description files. Tree-SHA512: d2a692047f3466a5c637433610854d1100fe68a78fb03b4a81c70911fa14b0228d9cf25bcf115930aab9cc8c5063dacaf79bcd151f1c3f6fee6419389aefcb8b	2019-03-16 13:26:48 +01:00
Hennadii Stepanov	b8705a0915	Set 'distro' explicitly	2019-03-16 07:40:50 +02:00
MarcoFalke	b83c6f7940	Merge #15444: [docs] Additional productivity tips ... ff7f31e07d [doc] productivity: more advanced git range-diff (Sjors Provoost) 3a21905a4e [doc] devtools: mention clang-format dependency (Sjors Provoost) bf12093191 [doc] productivity: fix broken link (Sjors Provoost) Pull request description: Fixes a broken link to `devtools/README.md`, points out the `clang-format` dependency and adds a `git range-diff` incantation that works even with rebases and squashes. Tree-SHA512: 36e46282f1e28d1bf3f48ada995fbac548f61b7747091eb032b60919cf76c7bdad0fa8aecb0c47adbdaa9ef986d3ec7752b0bb94c63191401856e2ddeec48f3e	2019-03-14 17:02:28 -04:00
Wladimir J. van der Laan	12408d33c6	Merge #15549: gitian: Improve error handling ... 32da92bdf6 gitian: Improve error handling (Wladimir J. van der Laan) Pull request description: Improve error handling in gitian builds: - Set fail-on-error and pipefail flag, this causes a command to fail when either of the pipe stages fails, not only when the last of the stages fails, so this improves error detection. - Also use `xargs` instead of `find -exec`, because `find` will not propagate errors in the executed command, but `xargs` will. This will avoid some issues like #15541 where non-determinism is silently introduced due to errors caused by environment conditions (such as lack of disk space in that case). Tree-SHA512: d5d3f22ce2d04a75e5c25e935744327c3adc704c2d303133f2918113573a564dff3d3243d5569a2b93ee7eb0e97f8e1b1ba81767e966af9015ea711a14091035	2019-03-09 06:45:19 +01:00
MarcoFalke	923d87497c	Merge #15528: contrib: Bump gitian descriptors for 0.19 ... fa58a2e335 contrib: Bump gitian descriptors for 0.19 (MarcoFalke) Pull request description: Bump the cache directory (as in 263b3777e7) Tree-SHA512: 2f9a4f8c14c3c6cef30bcdfed638486c6b957068b1e2380cbde1719c9bf8b53bcaff35833272a879af5b031e3ea0a32cc16f78cc7e4d7399037de89132311c5b	2019-03-08 09:12:03 -05:00
Wladimir J. van der Laan	32da92bdf6	gitian: Improve error handling	2019-03-07 17:21:46 +01:00
MarcoFalke	a74d588f21	Merge #14954: build: Require python 3.5 ... fa2797808e test: Remove python3.4 workaround in feature_dbcrash (MarcoFalke) dddd1d05d3 .python-version: Specify full version 3.5.6 (MarcoFalke) faa7cdf764 scripted-diff: Update copyright in ./test (MarcoFalke) fa0e65b772 scripted-diff: test: Remove brackets after assert (MarcoFalke) fab5a1e0f4 build: Require python 3.5 (MarcoFalke) fa6bf21f5e scripted-diff: test: Use py3.5 bytes::hex() method (MarcoFalke) Pull request description: Python 3.4 is EOL after March 2019, so switch to 3.5. See https://devguide.python.org/#status-of-python-branches This pull does the following in a bunch of commits: * scripted diff to use the `bytes::hex()` method in place of previous wrappers (`b2x`, `bytes_to_hex_str`, `hexlify`, ...) * Update the build system (gitian and travis) to remove python2.7 and replace it with python3.5 * Another scripted-diff to remove brackets after `assert`. This is unrelated to the python3.5 switch, but a stylistic commit, so probably not worth to split up. The motivation behind it is to avoid asserting on data structures (such as tuples of length one), which never fails: ```py >>> assert(False,) # with brackets >>> assert False, # without brackets SyntaxError: invalid syntax >>> assert False # proper assertion AssertionError ``` * And then a final scripted diff to update the copyright headers in the `test` subfolder, since I touched most of the files anyway and it wouldn't make sense to split this commit out into a separate pull. For reference (contributed by luke-jr): Ubuntu LTS (bionic): 3.6.5 Debian stable (stretch): 3.5.3 RHEL 8 (expected before v0.19): 3.6.x Gentoo stable: 3.6.5 Arch: 3.7.1 Tree-SHA512: 643c28cd2d5b9543ce4bf8ad2a8b282bc79b37dc5b25c9c8358e6ce201e2a67a546463e5f3430b16652eb2489d7c3ed4b0772cd2e2bf790fe68a5e3cc8a25029	2019-03-05 09:13:13 -05:00
MarcoFalke	fa58a2e335	contrib: Bump gitian descriptors for 0.19	2019-03-04 14:44:23 -05:00
MarcoFalke	45f434f44d	Merge #15288: Remove wallet -> node global function calls ... f7efd87c8f Change brace formatting (Russell Yanofsky) a1df1b48a8 Remove use of IsInitialBlockDownload in wallet code (Russell Yanofsky) 1106a6fde4 Remove use of uiInterface.LoadWallet in wallet code (Russell Yanofsky) 318f41fb2c circular-dependencies: Avoid treating some .h/.cpp files as a unit (Russell Yanofsky) d02b34c8a8 Remove use of AcceptToMemoryPool in wallet code (Russell Yanofsky) e2c8ba9f6e Remove uses of InitMessage/Warning/Error in wallet code (Russell Yanofsky) c5e59a96a8 Remove uses of GetAdjustedTime in wallet code (Russell Yanofsky) 6d6bcc77c0 Remove use of g_connman / PushInventory in wallet code (Russell Yanofsky) 00dfb2a440 Remove uses of g_connman in wallet code (Russell Yanofsky) cc3836e8f9 Remove uses of fPruneMode in wallet code (Russell Yanofsky) cc02c796d3 Remove uses of fee globals in wallet code (Russell Yanofsky) 1fb0a4a04e Remove use of CalculateMemPoolAncestors in wallet code (Russell Yanofsky) cd32160af0 Remove use of GetTransactionAncestry in wallet code (Russell Yanofsky) 291276f7f4 Remove use of GetCountWithDescendants in wallet code (Russell Yanofsky) bdc6628683 Remove use of IsRBFOptIn in wallet code (Russell Yanofsky) 80f52a2267 Remove uses of CheckFinalTx in wallet code (Russell Yanofsky) Pull request description: This change removes wallet calls to node functions that access global chain and mempool state. This is the next step in the larger #10973 refactoring change, which removes all other accesses to node global variables from wallet code. Doing this is useful to provide a better defined interface between the wallet and node, and necessary to allow wallet and node code to run in separate processes in #10102. Tree-SHA512: 40dbaf1f59fb22b32e70b054b30ba5638d638aa3240fa30e0f721d53c721cd6138a7ab4d423a24d7d2fda0b956e68d44c733abc2c9259c3d6c9fd6d4be89aa23	2019-03-04 13:13:36 -05:00
MarcoFalke	fab5a1e0f4	build: Require python 3.5	2019-03-02 10:40:23 -05:00
MarcoFalke	fa6bf21f5e	scripted-diff: test: Use py3.5 bytes::hex() method ... -BEGIN VERIFY SCRIPT- sed -i -e "s/def bytes_to_hex_str/def b_2_x/g" $(git grep -l bytes_to_hex_str) export RE_B_0="[^()]*" # match no bracket export RE_B_1="${RE_B_0}\(${RE_B_0}\)${RE_B_0}" # match exactly one () export RE_B_2="${RE_B_0}\(${RE_B_1}\)${RE_B_0}" # match wrapped (()) export RE_M="(b2x|bytes_to_hex_str)\(((${RE_B_0}|${RE_B_1}|${RE_B_2})*)\)" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l -E '(b2x|bytes_to_hex_str)') sed -i --regexp-extended -e "/ +bytes_to_hex_str( as b2x)?,/d" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/ +bytes_to_hex_str( as b2x)?,//g" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/, bytes_to_hex_str( as b2x)?//g" $(git grep -l bytes_to_hex_str) export RE_M="(binascii\.)?hexlify\(((${RE_B_0}|${RE_B_1}|${RE_B_2})*)\).decode\(${RE_B_0}\)" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "/from binascii import hexlify$/d" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "s/(from binascii import) .*hexlify/\1 unhexlify/g" $(git grep -l hexlify -- ':(exclude)share') sed -i -e 's/ignore-names "/ignore-names "b_2_x,/g' ./test/lint/lint-python-dead-code.sh -END VERIFY SCRIPT-	2019-03-02 10:40:12 -05:00
MarcoFalke	80112b17e7	Merge #15296: tests: Add script checking for deterministic line coverage in unit tests ... 43206239a8 tests: Add script checking for deterministic line coverage (practicalswift) Pull request description: Add script checking for deterministic line coverage in unit tests. Context: #14343 ("coverage reports non-deterministic") When the coverage is deterministic this script can be invoked from Travis to guard against regressions, but left inactive for now. Output in case of determinism: ``` $ contrib/test_deterministic_coverage.sh 2 [2019-01-30 20:08:46] Measuring coverage, run #1 of 2 [2019-01-30 20:10:45] Measuring coverage, run #2 of 2 Coverage test passed: Deterministic coverage across 2 runs. ``` Output in case of non-determinism: ``` $ contrib/test_deterministic_coverage.sh 2 [2019-01-30 20:08:46] Measuring coverage, run #1 of 2 [2019-01-30 20:10:45] Measuring coverage, run #2 of 2 The line coverage is non-deterministic between runs. The test suite must be deterministic in the sense that the set of lines executed at least once must be identical between runs. This is a neccessary condition for meaningful coverage measuring. --- gcovr.run-1.txt 2019-01-30 23:14:07.419418694 +0100 +++ gcovr.run-2.txt 2019-01-30 23:15:57.998811282 +0100 @@ -471,7 +471,7 @@ test/crypto_tests.cpp 270 270 100% test/cuckoocache_tests.cpp 142 142 100% test/dbwrapper_tests.cpp 148 148 100% -test/denialofservice_tests.cpp 225 225 100% +test/denialofservice_tests.cpp 225 224 99% 363 test/descriptor_tests.cpp 116 116 100% test/fs_tests.cpp 24 3 12% 14,16-17,19-20,23,25-26,29,31-32,35-36,39,41-42,45-46,49,51-52 test/getarg_tests.cpp 111 111 100% @@ -585,5 +585,5 @@ zmq/zmqpublishnotifier.h 5 0 0% 12,31,37,43,49 zmq/zmqrpc.cpp 21 0 0% 16,18,20,22,33-35,38-45,49,52,56,60,62-63 ------------------------------------------------------------------------------ -TOTAL 61561 27606 44% +TOTAL 61561 27605 44% ------------------------------------------------------------------------------ ``` In this case line 363 of `test/denialofservice_tests.cpp` was executed only in the second run. Non-determinism detected! Tree-SHA512: 03f45590e70a87146f89aa7838beeff0925d7fd303697ff03e0e69f8a5861694be5f0dd10cb0020e3e3d40c9cf662f71dfcd838f6affb31bd5212314e0a4e3a9	2019-03-02 09:46:25 -05:00
Russell Yanofsky	318f41fb2c	circular-dependencies: Avoid treating some .h/.cpp files as a unit ... This avoids a bogus circular dependency error in the next commit: interfaces/chain -> interfaces/wallet -> wallet/wallet -> interfaces/chain Which is incorrect, because interfaces/chain.cpp depends only on the interfaces/wallet.h file, not the interfaces/wallet.cpp file, and it is wrong to treat these as a unit. Inside the interfaces directory, .h files contain abstract class definitions and .cpp files contain implementations of those classes, so you don't need to link against .cpp files if you're only using the abstract class definition in the .h file. An alternative fix might be to rename all the cpp files in the interfaces directory like: chain.cpp->chain_impl.cpp, node.cpp->node_impl.cpp. But just getting the linter to treat these files as independent dependencies seemed like it would allow keeping code organization straightforward and avoiding the need to rename things.	2019-02-22 15:43:02 -04:00
Wladimir J. van der Laan	a094b54332	Merge #15273: docs: Slight tweak to the verify-commits script directions ... a786c3b306 Slight tweak to the verify-commits script directions (Douglas Roark) Pull request description: Clarify that GnuPG may be used on both Linux and macOS to obtain the keys required to verify the commits. Tree-SHA512: cec556370f03e00bbd6f585d26b360ca236cf55cb5c0996f6d950d8a98f77c92cc02f1719c8f9b9dc9eac6900eb341a13b50a012752832f39095b7e84046f2cd	2019-02-22 13:34:53 +01:00
Graham Krizek	8b8d8eeae9	Remove travis_wait from lint script ... Also adding progress logging to verify-commits.py script to prevent Travis from timing out	2019-02-21 11:11:02 -06:00
Sjors Provoost	3a21905a4e	[doc] devtools: mention clang-format dependency	2019-02-19 17:08:01 +01:00
practicalswift	43206239a8	tests: Add script checking for deterministic line coverage	2019-02-15 09:38:07 +01:00
MarcoFalke	d73918447f	Merge #15216: Scripts and tools: Replace script name with a special parameter ... 8c9b8a3668 Replace script name with special parameter (Hennadii Stepanov) Pull request description: This PR improves UX; all others shell scripts ~(excluding travis linters)~ in the bitcoin repo have this feature. Before:  After:  cc: @jamesob @laanwj Tree-SHA512: 7924e5658a2efe81fd5591390ca5af1ff0558bd9d5693363b9f8addedb1d6b90aa16f11c9b361c6fdfbd931a959255817473a240c175dee95aefc7d2d4a10a36	2019-02-12 16:39:39 -05:00
Hennadii Stepanov	8c9b8a3668	Replace script name with special parameter	2019-02-12 23:25:54 +02:00
MarcoFalke	1a6036978e	Merge #15354: doc: Add missing bitcoin-wallet tool manpages ... fa1e281547 doc: Add missing wallet-tool manpages (MarcoFalke) fa0fe3b8a4 contrib: Add missing wallet tool to gen-manpages.sh (MarcoFalke) Pull request description: Tree-SHA512: 8c5c7e98f634cb1c8b43ecc9a15f22df2f572f5d752fb20f09910fb0d31e74df8144c1833f54bb44ad53cb5ca166f7e896317951899d4b0aa05bd3262f66835c	2019-02-06 11:18:27 -05:00
MarcoFalke	fa0fe3b8a4	contrib: Add missing wallet tool to gen-manpages.sh	2019-02-06 10:03:12 -05:00
OverlordQ	7fdb92e53b	Update linearize-hashes.py ... Fix class case issue.	2019-02-05 19:54:44 -05:00
MarcoFalke	fc21bb4e35	Merge #15245: remove deprecated mentions of signrawtransaction from fundraw help ... 851380ce17 remove deprecated mentions of signrawtransaction from fundraw help (Gregory Sanders) Pull request description: RPC call has been removed as of 0.17.99. Tree-SHA512: a6a12a0e4572acd9b532c1719be85ed6f29d1c1a28f9ce691398528b8dde4fb4a3222b8f68632fcb1a8eddfe2d31e96d5efd5bc51c041af8e7cb99b61ca3a167	2019-02-05 10:48:36 -05:00
Wladimir J. van der Laan	76deb30550	Merge #12255: Update bitcoin.service to conform to init.md ... bad1716c6d init: Modify docs and add release note for 12255 (Carl Dong) b0c7b54d0c init: Use systemd automatic directory creation (Carl Dong) Pull request description: - `-datadir` option specified. - Ask systemd to create and set the right mode for PID directory, configuration directory, and data directory. - Tell systemd our group so it will set the right owner for aforementioned directories. More information: https://www.freedesktop.org/software/systemd/man/systemd.exec.html Tree-SHA512: a6fad1efa2be433c1fdd863df3ff232736ed709a9e281f51a003b40987d8c213dc64a52bc13a19c85bf85680e78f0be112ecaf32ac274b1ff93bac84a1208845	2019-02-04 19:51:28 +01:00
Gregory Sanders	851380ce17	remove deprecated mentions of signrawtransaction from fundraw help	2019-02-04 10:26:46 -05:00
Douglas Roark	a786c3b306	Slight tweak to the verify-commits script directions ... Clarify that GnuPG may be used on both Linux and macOS to obtain the keys required to verify the commits.	2019-01-31 10:15:52 -08:00
Hennadii Stepanov	a6cd50dec6	Add gitian PGP key for hebasto	2019-01-28 14:01:00 +02:00
Ben Woosley	ad5e5a105e	Scripts and tools: Drop no-longer-relevant copyright holder names ... Now that leveldb, secp256k1, etc. are reliably excluded, these names will not show up in the searched files.	2019-01-24 23:46:12 -08:00
Ben Woosley	2434ab5c2a	Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions ... This script compared paths relative to the report directory to test for exclusion, meaning the directory exclusions did not work properly, as they were relative to the project root. Fix this by creating absolute paths through the combination of: 'git ls-files --full-name' and 'git rev-parse --show-toplevel'	2019-01-24 23:46:06 -08:00
Jonas Schnelli	73a6bac9ff	Merge #15196: [test]: Update all subprocess.check_output functions to be Python 3.4 compatible ... fdf82ba18 Update all subprocess.check_output functions in CI scripts to be Python 3.4 compatible (Graham Krizek) Pull request description: CI is failing the `lint` stage on every Cron run (regular PR/Push runs still pass). The failure was introduced in 74ce326 and has been broken since. The Python version running in CI was downgraded to 3.4 from 3.6. There were a couple files that were using the `encoding` argument in the `subprocess.check_output` function. This was introduced in Python 3.6 and therefore broke the scripts that were using it. The `universal_newlines` argument was used as well, but in order to use it we must be able to set encoding because of issues on some BSD systems. To get CI to pass, I removed all `universal_newline` and `encoding` args to the `check_ouput` function. Then I decoded all `check_output` return values. This should keep the same behavior but be Python 3.4 compatible. Tree-SHA512: f5e5885e98cf4777be9cc254446a873eedb03bdccbd8e06772a964db95e9fcf46736aa9cdcab1d8f123ea9f4947ed6020679898d8b2f47ffb1d94c21a4b08209	2019-01-23 20:43:53 -10:00
Hennadii Stepanov	5c04814b2d	Move non-linux source tarball to bitcoin-binaries	2019-01-23 22:30:20 +02:00
Graham Krizek	fdf82ba181	Update all subprocess.check_output functions in CI scripts to be Python 3.4 compatible ... Removing the 'universal_newlines' and 'encoding' args from the subprocess.check_outputs fuction. 'universal_newlines' is supported in 3.4, but 'encoding' is not. Without specifying 'encoding' it will make a guess at encoding, which can break things on BSD systems. We must handle encoding/decoding ourselves until we can use Python 3.6	2019-01-18 09:36:39 -06:00
Ben Woosley	4e81438f65	build: Drop macports support ... It's untested / unmaintained, according to theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938	2019-01-16 12:13:59 -08:00
Wladimir J. van der Laan	bcdd31f265	Merge #15165: contrib: Allow use of github API authentication in github-merge ... f1bd219a5b contrib: Allow use of github API authentication in github-merge (Wladimir J. van der Laan) a4c5bbfcd3 contrib: Add support for http[s] URLs in github-merge (Wladimir J. van der Laan) 059a3cffdf contrib: Detailed reporting for http errors in github-merge (Wladimir J. van der Laan) Pull request description: Three commits I had locally for `github-merge.py`: - *Detailed reporting for http errors in github-merge*: Print detailed error, this makes it easier to diagnose github API issues. - *Add support for http[s] URLs in github-merge*: Sometimes it can be useful to use github-merge with read-only access (say, for reviewing and testing from untrusted VMs). - *Allow use of github API authentication in github-merge*: The API request limit for unauthenticated requests is quite low. I started running into rate limiting errors. The limit for authenticated requests is much higher. This patch adds an optional configuration setting `user.ghtoken` that, when set, is used to authenticate requests to the API. Tree-SHA512: ca8ae1874a787263e49d915d7cf31c0c0f50aba229c9440265bf1fda69f7e00641d1492512b93d76c17ff1766859283d640d37770acb120898736ad97efbd5c2	2019-01-16 12:12:14 +01:00
Wladimir J. van der Laan	f1bd219a5b	contrib: Allow use of github API authentication in github-merge ... The API request limit for unauthenticated requests is quite low. I started running into rate limiting errors. The limit for authenticated requests is much higher. This patch adds an optional configuration setting `user.ghtoken` that, when set, is used to authenticate requests to the API.	2019-01-14 16:48:23 +01:00
Wladimir J. van der Laan	a4c5bbfcd3	contrib: Add support for http[s] URLs in github-merge ... Sometimes it can be useful to use github-merge with read-only access (say, for reviewing and testing).	2019-01-14 16:33:13 +01:00
Wladimir J. van der Laan	059a3cffdf	contrib: Detailed reporting for http errors in github-merge ... Print detailed error, this makes it easier to diagnose github API issues.	2019-01-14 16:32:05 +01:00
TheCharlatan	03b8596dd6	Add checksum in gitian build scripts for ossl ... This adds a checksum in the gitian build script to make sure that ossl tool and theuni's patch matches what is expected. Also changes the url to use https and adds the same instructions to the release docs.	2019-01-09 23:49:01 +01:00
Carl Dong	b0c7b54d0c	init: Use systemd automatic directory creation ... Tell systemd to create, set, and ensure the right mode for the PID, configuration, and data directories. Only the exec bit is set for groups for the aforementioned directories. This is the least privilege perm that allows for the reading/writing/execing of files under the directory _if_ the files themselves give permission to its group to do so (e.g. when -sysperms is specified). Note that this does not allow for the listing of files under the directory.	2019-01-05 13:21:44 +08:00
MarcoFalke	e756eca9e8	Merge #15054: Update copyright headers to 2018 ... 1a49a0e310 Bump manpages (DrahtBot) 06ba77973e Update copyright headers to 2018 (DrahtBot) Pull request description: * `./contrib/devtools/copyright_header.py update ./` * `./contrib/devtools/gen-manpages.sh` Tree-SHA512: ca0dc5e97f4c33814d4ccd17769bbf2d23a99a71d62534fe1064fedfe47de3b5c30caf9b6deb0d70bf125e08c7ae6335ac4fcded918049d6b63b13b319d798e3	2018-12-31 12:24:27 +01:00
Emil Engler	ae5594d51b	[Trivial] Update license year range to 2019 ... Update year range	2018-12-31 04:27:59 +01:00
DrahtBot	06ba77973e	Update copyright headers to 2018	2018-12-29 10:15:01 +01:00
practicalswift	4de11a3682	Remove Python 2 import workarounds	2018-12-13 16:46:31 +01:00
Wladimir J. van der Laan	f17aca67b0	Merge #14903: tests: Handle ImportError explicitly, improve comparisons against None ... c9ba253f4f Add E711 to flake8 check (Daniel Ingram) 17b55202da Compare to None with is/is not (Daniel Ingram) 1b89074ae2 Change '== None' to 'is None' (Daniel Ingram) 16d2937723 Handle exception as ImportError (Daniel Ingram) Pull request description: Tree-SHA512: aa5875ea3d9ac47ac898545ff023b511042cd377ea0c4594074daae119f3d4f3fc295721aad94a732a907086ecb32bce19a8eed38adf479f12663c4e8944f721	2018-12-13 13:10:33 +01:00
MarcoFalke	d680ef9381	Merge #14883: add --retry 5 to curl opts in install_db4.sh ... 522b80b33f add `--retry 5` to curl opts in install_db4.sh (qubenix) Pull request description: I ran into some network issue that caused the clang patch to not download and the script exited. A retry would have solved it. The fallback choice, `wget`, has a default 20 retries. I chose 5 retries because `curl` backs of after each try, starting at one second and doubling each time. 5 retries means that worst case scenario would be a total of 31 seconds waiting between attempts. IMO that should be enough tries if internet is working, but not too much if internet is not working. Tree-SHA512: ff48e1f8a9d39b9c6fabc616223974f46fadc5a1b30793cdaaf5ea4ce79f7c76efd259bfa9e81a5a7a7cff60b7133d89448faa3f86cc2f9b0c5ac9adf8dd2a9b	2018-12-11 13:43:20 -05:00
Daniel Ingram	17b55202da	Compare to None with is/is not	2018-12-10 15:11:37 -05:00
MeshCollider	e946fc7eb1	Merge #14809: Tools: improve verify-commits.py script ... 45842c3d2 Improve documentation for running verify-commits.py script (Jameson Lopp) Pull request description: I ran into 3 different issues while trying to run the verify-commits script for the first time and I think documenting them would help save time for future developers. 1. I was trying to just run it with "python" and didn't realize I had multiple python versions installed and this script is only syntactically valid for python 3.x. 2. I needed to import the trusted keys 3. The script was hanging because it was triggering my yubikey for signature verification Tree-SHA512: dfc7a62972ca3de528fae3c9d420c7d2d6658767a555ebbf5f4a27c04748c35ccf8bf63bfc9f264358346de0db49bfbaf2d1540793a609d81c2d9b622ee8182c	2018-12-10 17:18:38 +13:00
Daniel Ingram	1b89074ae2	Change '== None' to 'is None'	2018-12-09 15:55:13 -05:00
Daniel Ingram	16d2937723	Handle exception as ImportError	2018-12-09 15:49:34 -05:00
Jameson Lopp	45842c3d26	Improve documentation for running verify-commits.py script	2018-12-06 10:41:08 -05:00
Wladimir J. van der Laan	01bc479d16	Merge #14869: scripts: Add trusted key for Samuel Dobson ... 1ca0502541 scripts: Add trusted key for Samuel Dobson (Wladimir J. van der Laan) Pull request description: Add trusted GPG key so that Samuel Dobson (MeshCollider), who is now wallet maintainer, can merge PRs. Tree-SHA512: 6b2ef8ac1c8965eaaf5fc677dbf3bb7109e1f9dd4b56072a3409bcd232d5f1241c4e3d5fe962fcabb32880a4dbc49e5d6fb5e087e535a53f8d5d954d4f10db1b	2018-12-06 15:56:52 +01:00
Wladimir J. van der Laan	0936e2596b	Merge #14831: Scripts and tools: Use #!/usr/bin/env bash instead of #!/bin/bash. ... 688f665a5e Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes. (vim88) Pull request description: As it was discussed in [#13510](https://github.com/bitcoin/bitcoin/pull/13510), it is better to use `#!/usr/bin/env bash` instead of `#!/bin/bash`. Tree-SHA512: 25f71eb9a6a0cdc91568b5c6863205c5fe095f77a69e633503a2ac7805bd9013af8538e538c0c666ce96a28e3f43ce7a8df5f08d4ff007723bb588d85674f2da	2018-12-06 15:47:44 +01:00
qubenix	522b80b33f	add --retry 5 to curl opts in install_db4.sh	2018-12-06 03:59:37 +00:00
Wladimir J. van der Laan	1ca0502541	scripts: Add trusted key for Samuel Dobson ... Add trusted GPG key so that Samuel Dobson (MeshCollider), who is now wallet maintainer, can merge PRs.	2018-12-04 13:51:53 +01:00
vim88	688f665a5e	Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes.	2018-12-02 16:14:21 +02:00
Craig Younkins	af1ed206f8	Fix broken Gmane URLs	2018-11-30 13:51:55 +00:00
MarcoFalke	a7dc03223e	Merge #14785: Scripts: Fix detection of copyright holders ... af9a9918b2 Fix detection of copyright holders (Cornelius Schumacher) Pull request description: Fix copyright holder detection so that `copyright_header.py report` creates a clean and accurate report: * Fix list of copyright holders in the code * Also detect copyrights which have a comma after the date * Exclude directories which are git subtrees Tree-SHA512: 7ab78618aa62c7d40b6688ddcde4a85c6fc5df8275271fa85518e146c1db90760bfafaa6036b9f6afbe887fd7e9274c913786101668573a3e289b3411aa6842f	2018-11-23 14:00:46 -05:00
Cornelius Schumacher	af9a9918b2	Fix detection of copyright holders ... * There is a copyright notice in `src/crypto/sha256_sse4.cpp` in the middle of the file which contains a comma before the copyright holder name. Correctly detect this so it's added to the report. * Add missing copyright holders so that `copyright_header.py report` doesn't show any unexpected copyright holder names anymore. * Exclude files from git subtrees because they are maintained at the original source.	2018-11-23 17:22:50 +01:00
MarcoFalke	fa7d36b8e7	test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan	2018-11-22 11:55:53 -05:00
MarcoFalke	66c70249f9	Merge #14611: docs: align items in contrib init ... 053b6f42d2 align items in contrib init (Harry Moreno) Pull request description: minor Tree-SHA512: 72bd01e174dafdb77db5e5e4551ff9a65a4a804a59da0ab7d2825f31dcd37fbe724d6c0da5cda69869cd14181c617e113946b46844379eb7747e1249b56f2d62	2018-11-07 11:05:40 -05:00
practicalswift	5c292dafcd	Add UBSan suppressions needed to pass test suite	2018-11-06 14:07:18 +01:00
practicalswift	9f49db7335	Enable functional tests in UBSAN job. Enable -fsanitize=integer (part of UBSAN). Merge UBSAN Travis job with no depends.	2018-11-05 20:04:02 +01:00
Wladimir J. van der Laan	dac2caa371	Merge #14060: ZMQ: add options to configure outbound message high water mark, aka SNDHWM ... a4edb168b6 ZMQ: add options to configure outbound message high water mark, aka SNDHWM (mruddy) Pull request description: ZMQ: add options to configure outbound message high water mark, aka SNDHWM This is my attempt at https://github.com/bitcoin/bitcoin/pull/13315 Tree-SHA512: a4cc3bcf179776899261a97c8c4f31f35d1d8950fd71a09a79c5c064879b38e600b26824c89c4091d941502ed5b0255390882f7d44baf9e6dc49d685a86e8edb	2018-11-05 13:45:41 +01:00
Harry Moreno	053b6f42d2	align items in contrib init	2018-10-30 14:27:37 -04:00
Jonas Schnelli	43719e0a34	[macOS] Remove DS_Store WindowBounds bytes object	2018-10-20 15:12:02 +02:00
mruddy	a4edb168b6	ZMQ: add options to configure outbound message high water mark, aka SNDHWM	2018-10-19 07:36:13 -04:00
Andrew Chow	d813266db1	[gitian] use versioned unsigned tarballs instead of generically named ones ... Instead of re-naming the tarballs used for the code signing step to the generically named tarball that is used, keep the versioned naming. Only copy them to the correct filename when they are needed at build time.	2018-09-25 22:07:33 -04:00
MarcoFalke	adf27b531a	Merge #13954: Warn (don't fail!) on spelling errors. Fix typos reported by codespell. ... f8a81f73ac lint: Add spell check linter (codespell) (practicalswift) ada356208e Fix typos reported by codespell (practicalswift) Pull request description: * Check for common misspellings using `codespell`. * Fix recently introduced typos reported by `codespell`. Tree-SHA512: 9974c0e640b411c7d0ebc5b45de253c19bac7fe3002cd98601ff8da8db584224c2fd7d331aee3df612c9f2cfef540d647a9b4c5a1a73fd208dc93ce4bf9e5e3e	2018-09-05 18:13:05 -04:00
practicalswift	ada356208e	Fix typos reported by codespell	2018-09-04 13:11:26 +02:00
Chun Kuan Lee	5d62dcf9cf	lint: Make sure we read the command line inputs using utf-8 decoding in python	2018-09-02 21:40:51 +08:00
Wladimir J. van der Laan	0c9bea5a00	Merge #14037: Add README.md to linux release tarballs ... 8550f1fb28 Add README.md to linux release tarballs (Hennadii Stepanov) Pull request description: fix #8160 Gitian building report for 0.17.0rc2: ``` 7d89d7dc3488915ec2380253a69fb3b8f8065592e24c5b2a99a91da30f2142cc bitcoin-0.17.0-aarch64-linux-gnu-debug.tar.gz fcb292fd2c4fca88e5cc5a97ee7fa3390d3c7221aada166fe7822d64a2ee9dfa bitcoin-0.17.0-aarch64-linux-gnu.tar.gz 0ec6f979a823a6b6084d2e80605dffd3ccdda359e8459cebec25092c1087348f bitcoin-0.17.0-arm-linux-gnueabihf-debug.tar.gz 45af8757a2315125afe2f4d4f276d9b9cf616b8ab814284ce2f82b9a345971d8 bitcoin-0.17.0-arm-linux-gnueabihf.tar.gz b37b6d9bda864af968dfab6eebb245e75ecc56eb18b139b946270933381ea288 bitcoin-0.17.0-i686-pc-linux-gnu-debug.tar.gz 20c96a5509eeb3e8ec505f18914ef9231beef1fec5e9e1c4b33ec6c6b613d146 bitcoin-0.17.0-i686-pc-linux-gnu.tar.gz d505888594a04dab2b34ccd6863b8f25eb97d9cb76650e39d93f4d6c09d4c55a bitcoin-0.17.0-x86_64-linux-gnu-debug.tar.gz f55b16716c3295e309c816e170911380a5a26e9be3a336b213f2f412f0b159b3 bitcoin-0.17.0-x86_64-linux-gnu.tar.gz 01c6b5ce15b9f3fcdcce96baae14eb04ab2605f2294d333e96b66e004594eea6 src/bitcoin-0.17.0.tar.gz ``` Release tarball content: ``` $ tar -tf bitcoin-binaries/0.17.0rc2/bitcoin-0.17.0-x86_64-linux-gnu.tar.gz bitcoin-0.17.0/ bitcoin-0.17.0/bin/ bitcoin-0.17.0/bin/bitcoin-cli bitcoin-0.17.0/bin/bitcoind bitcoin-0.17.0/bin/bitcoin-qt bitcoin-0.17.0/bin/bitcoin-tx bitcoin-0.17.0/bin/test_bitcoin bitcoin-0.17.0/include/ bitcoin-0.17.0/include/bitcoinconsensus.h bitcoin-0.17.0/lib/ bitcoin-0.17.0/lib/libbitcoinconsensus.so bitcoin-0.17.0/lib/libbitcoinconsensus.so.0 bitcoin-0.17.0/lib/libbitcoinconsensus.so.0.0.0 bitcoin-0.17.0/README.md bitcoin-0.17.0/share/ bitcoin-0.17.0/share/man/ bitcoin-0.17.0/share/man/man1/ bitcoin-0.17.0/share/man/man1/bitcoin-cli.1 bitcoin-0.17.0/share/man/man1/bitcoind.1 bitcoin-0.17.0/share/man/man1/bitcoin-qt.1 bitcoin-0.17.0/share/man/man1/bitcoin-tx.1 ``` Tree-SHA512: 2a0c069d6533502a95a83eaba57b9828bddd03ab4a4fc47027b0068c9f04837f107abc448d82c929aa1f45441d2459cf6f2ad74b97a4d953f66dc81031bd521a	2018-08-31 13:05:15 +02:00
Wladimir J. van der Laan	48ed386fa6	Merge #13724: [contrib] Support ARM and RISC-V symbol check ... c516c3a770 [contrib] Support ARM and RISC-V symbol check (Chun Kuan Lee) Pull request description: Solve the TODO in the gitian-descripter Tree-SHA512: 8115e2958af3dde43d9d9d05f0b1b1b93b1c2aa513e771a3e4e1342a5d78af2b0e40c0bbb7e9a0d15954897317e6f5a0d80996239af3b376d5ddd527f73428ae	2018-08-31 12:58:29 +02:00
Hennadii Stepanov	8550f1fb28	Add README.md to linux release tarballs ... fix #8160	2018-08-28 00:33:37 +03:00
Akio Nakamura	a9910d82c3	contrib: Adjust output to current test format ... Ajust the outputs of gen_base58_test_vectors.py to current test format. 1. Add bech32 vector generation. 2. Add Script-fragments to hexrepr in the format expected by the test. 3. Modify the metadata. 1) Change 'isTestnet' to 'chain' (main/test/regtest) 2) Remove 'addrType' 3) Add 'tryCaseFlip' (True/False on bech32)	2018-08-27 20:14:47 +09:00
Chun Kuan Lee	c516c3a770	[contrib] Support ARM and RISC-V symbol check	2018-08-25 21:08:16 +08:00
Wladimir J. van der Laan	a5fc1aa04d	Merge #13765: contrib: add gitian build support for github pull request ... 46f8345370 contrib: Support github pull request gitian-build (Chun Kuan Lee) Pull request description: - Add `-p` or `--pull` to specify the version is github pull request number - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling. Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c	2018-08-22 11:47:11 +02:00
Wladimir J. van der Laan	3c8d1ae153	Merge #13665: [build] Add risc-v support to gitian ... c4aecd1d80 Add risc-v 64-bit to gitian (Chun Kuan Lee) 96dda8b058 [depends] Add riscv qt depends support for cross compiling bitcoin-qt (Chun Kuan Lee) Pull request description: Based on ~#13660~ #13710 , add gitian tarball for RISC-V Tree-SHA512: 8db73545a2ea7fe03fa156598479335ea3c79aa3fb9c5cc44b8563094b1deb7c94d29c1dab47fac129dbfa2e3e774301b526474beeeb59c9b0087d3ea087dbd6	2018-08-16 20:33:50 +02:00
fanquake	263b3777e7	gitian: bump descriptors for (0.)18	2018-08-13 21:44:22 +08:00
MarcoFalke	176aa5aa1d	contrib: fix GetDesirableServiceFlags typo in seeds/README.md	2018-08-13 15:11:24 +02:00
Wladimir J. van der Laan	825fb02ef1	net: Update hardcoded seeds ... Pre-0.17 branch hardcoded seeds update.	2018-08-13 13:57:15 +02:00
Wladimir J. van der Laan	61c0d3b9aa	contrib: in makeseeds, add 0.16.x to PATTERN_AGENT, remove 0.13.x	2018-08-13 13:51:06 +02:00
Chun Kuan Lee	c4aecd1d80	Add risc-v 64-bit to gitian	2018-08-09 03:35:51 +08:00
Wladimir J. van der Laan	78dae8cacc	Merge #13780: 0.17: Pre-branch maintenance ... 3fc20632a3 qt: Set BLOCK_CHAIN_SIZE = 220 (DrahtBot) 2b6a2f4a28 Regenerate manpages (DrahtBot) eb7daf4d60 Update copyright headers to 2018 (DrahtBot) Pull request description: Some trivial maintenance to avoid having to do it again after the 0.17 branch off. (The scripts to do this are in `./contrib/`) Tree-SHA512: 16b2af45e0351b1c691c5311d48025dc6828079e98c2aa2e600dc5910ee8aa01858ca6c356538150dc46fe14c8819ed8ec8e4ec9a0f682b9950dd41bc50518fa	2018-08-08 13:55:27 +02:00
Chun Kuan Lee	46f8345370	contrib: Support github pull request gitian-build	2018-08-01 01:10:51 +08:00
MarcoFalke	77168f766f	Merge #13809: contrib: Remove debian and rpm subfolder ... fa0e1e2f63 contrib: Remove debian and rpm subfolders (MarcoFalke) Pull request description: The folders are now located here: * https://github.com/bitcoin-core/packaging/tree/master/debian * https://github.com/bitcoin-core/packaging/tree/master/rpm Note that I kept the copyright file, so that it can be updated for our purposes in the commit that adds new files. Tree-SHA512: 4c919e8e04cdcc56f2c4c16e83c68d5ec74b7e4438ca54222a37f85cf604b77880393d1a0004f16f270ab04ee00b2060129c5c2e0b34815679940f1c3b5754f3	2018-07-31 11:56:09 -04:00
MarcoFalke	fa0e1e2f63	contrib: Remove debian and rpm subfolders	2018-07-30 14:00:56 -04:00
MarcoFalke	8284f1dc40	Merge #13782: Fix osslsigncode compile issue in gitian-build ... 284f424d5a Fix osslsigncode compile issue in gitian-build (Chun Kuan Lee) Pull request description: Install libssl1.0-dev that is compatible with osslsigncode. Fixes #13762 Verifed that this gitian descriptor file can sign 0.16.2rc2. Tree-SHA512: 3029b86e77567a4e033b5ad95826e60df12a0486ac3c4afcac48218f5c76ba49e7f1c1307ce93ffc465ca2f24e12c401e4542929263688e4bd6521aeca3ff73b	2018-07-30 13:10:56 -04:00
Chun Kuan Lee	284f424d5a	Fix osslsigncode compile issue in gitian-build	2018-07-30 22:43:24 +08:00
Wladimir J. van der Laan	f8685f461b	Merge #13764: contrib: Fix test-security-check fail in Ubuntu 18.04 ... 1e60713a68 contrib: Fix test-security-check fail in Ubuntu 18.04 (Chun Kuan Lee) Pull request description: - Fix test-security-check fail in Ubuntu 18.04. Those flags are enabled by default, so we must specify `-no` to make the executable does 'not' have those attributes. - Drop HIGH_ENTROPY_VA. After update our gitian system to Bionic, the compiler should support HIGH_ENTROPY_VA Tree-SHA512: 78c1f2aae1253ddd52faa1af569b7151a503a217c7ccbe21b8004d8910c45d8a27ff04695eacbdadd7192d2c91c0d59941ca20c651dd2d5052b9999163a11ae4	2018-07-30 16:11:59 +02:00
MarcoFalke	e8ffec69f7	Merge #13732: Depends: Fix Qt's rcc determinism ... 6b5506a286 Fix Qt's rcc determinism for depends/gitian (Fuzzbawls) Pull request description: With the update to Qt 5.9 having been merged, Qt's `rcc` tool now embeds a file's last modified time in it's output. Since the build system generates temporary files for all locale translations (`*.qm` files) at build time, the resulting `qrc_bitcoin_locale.cpp` file was always being generated in a non-deterministic way. This is a backport of https://bugreports.qt.io/browse/QTBUG-62511, which is included in Qt versions 5.11+, that allows for an environment variable (`QT_RCC_SOURCE_DATE_OVERRIDE`) to override the behavior described above. This environment variable is in turn set in the gitian descriptors, as that is where determinism is vital for release purposes. Prior to this, the `qt_libbitcoinqt_a-qrc_bitcoin_locale.o` object file (included into `libbitcoinqt.a`) was returning a different `sha256sum` for each and every build, regardless of file contents change, thus breaking determinism in the resulting binaries. This should fix #13731 Tree-SHA512: 174017e41f9afc3950ef54a9419de81577ec900db9aec3c78ccd3d879c6aecaaeb944fde0615b933f43e6ca9d7898a27ec071cdd0b91cb772755a3012de96725	2018-07-29 08:06:45 -04:00
DrahtBot	eb7daf4d60	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
Chun Kuan Lee	1e60713a68	contrib: Fix test-security-check fail in Ubuntu 18.04	2018-07-26 17:10:13 +08:00
Fuzzbawls	6b5506a286	Fix Qt's rcc determinism for depends/gitian ... Backport of https://bugreports.qt.io/browse/QTBUG-62511 to resolve locale determinism during the build process.	2018-07-25 13:53:53 -07:00
MarcoFalke	29b4ee6469	Merge #13714: contrib: Add lxc network setup for Bionic host ... 60c3c23a63 [contrib] Add automatic setup for Ubuntu Bionic (Chun Kuan Lee) Pull request description: Tree-SHA512: db7a67df34c143647098bd5cb499b5ebc8d6847bf5e20dc3b4d6093a1649dcf42007d02b40e95b1fa76c0aadecc1eb2374ca9ca247bdd6358a08a6c4358f4b9c	2018-07-25 09:57:08 -04:00
MarcoFalke	94dd89e6fa	Merge #13706: doc: Minor improvements to release-process.md ... 95464c7519 doc: Improve command to generate list of authors for release notes (Mitchell Cash) 1c22cc1af1 doc: Update broken links to now point to gitian-build.py (Mitchell Cash) Pull request description: - Update broken links - Improve command to generate list of authors for a release --- I also note that it asks to ping **wumpus** on IRC, to assist in generating a list of merged pulls and sort them into categories based on labels. I tried to turn this into a simple one-liner as well (something like ``git log --merges --format="- \`%h\` %s (%an)" v0.16.0..v0.16.1``), but it didn't seem to capture everything I needed. Would it be worthwhile **wumpus** open-sourcing his code into `contrib/devtools` so there is no single point of failure (even if it can manually be worked around). Tree-SHA512: 8e7f0880ff07ce8fe67b74de3f2c4b78dafe2c95eefb0617fa319ff196232967cb22ee75a183a39f93bfc6e0bf85547689160139312cee5956af2c069b8a3b6a	2018-07-25 07:13:22 -04:00
fanquake	26b15df99d	depends: set OSX_MIN_VERSION to 10.10	2018-07-25 07:30:27 +08:00
Chun Kuan Lee	60c3c23a63	[contrib] Add automatic setup for Ubuntu Bionic	2018-07-21 06:05:29 +08:00
Mitchell Cash	1c22cc1af1	doc: Update broken links to now point to gitian-build.py	2018-07-19 09:33:05 +10:00
Wladimir J. van der Laan	4c6d1b9973	Merge #13699: contrib: correct version check ... 066d2973a6 contrib: correct version check (Karl-Johan Alm) Pull request description: [ not(major >= 3 and minor >= 4) ] fails for '4.0': ```Python >>> major=4 >>> minor=0 >>> if not (major >= 3 and minor >= 5): ... print('This example only works with Python 3.5 and greater') ... This example only works with Python 3.5 and greater ``` Tree-SHA512: 41cb8c5dabe0061ead37b0d6447b699c5d5e1a5551a75dd279bb2ec6d6afa51f8b27a48e01195093db7ec37b28ff6445d59646a4a2b6dcee37776afb60eac8dc	2018-07-18 14:51:12 +02:00
Karl-Johan Alm	066d2973a6	contrib: correct version check ... [ not(major >= 3 and minor >= 4) ] fails for '4.0'	2018-07-18 16:46:19 +09:00
MarcoFalke	fa7f8a7769	contrib: Clone core repo in gitian-build	2018-07-17 15:44:08 -04:00
MarcoFalke	9cdb19fe67	Merge #13623: Migrate gitian-build.sh to python ... 78f06e4af7 Migrate gitian-build.sh to python (Chun Kuan Lee) Pull request description: Fixes #13620 - Rename Mac OSX to MacOS, rename option from 'x' to 'm' - Fix a bug from b641f60425/contrib/gitian-build.sh (L338-L342) Tree-SHA512: ff943055d5feca345bd17b64311374db3937d14d2f21493116fd7ab7b4cb7042480abd6a3d1d7640073b00bc0badb300e8dd32618bf73ba182df417c0633397a	2018-07-17 14:03:05 -04:00
Wladimir J. van der Laan	4027ec1d70	Merge #13647: Scripts and tools: Fix BIND_NOW check in security-check.py ... 37d363dd4a Tools: fix BIND_NOW check in security-check.py (Conrado Gouvea) Pull request description: Previously, the BIND_NOW check would work only if it was the first value in FLAGS. Tree-SHA512: 39cd83f673a6b521803be5585ada516f2db4eede718f0c5aea3377825ed1adcefed5bbb41dd9a5f24a26f7d27116cfc81bde7e26283232593b72768c5ae3d321	2018-07-17 17:14:15 +02:00
Chun Kuan Lee	78f06e4af7	Migrate gitian-build.sh to python	2018-07-16 13:01:09 +00:00
Chun Kuan Lee	c1afe3232f	Change gitian-descriptors to use bionic instead	2018-07-16 10:42:32 +00:00
MarcoFalke	c0f1569557	Merge #13368: Update gitian-build.sh for docker ... 86967b2e35 Add option to use docker for gitian-build.sh (Andrew Chow) Pull request description: Updates gitian-build.sh script for the docker virtualization method recently added to gitian-builder. Second commit depends on https://github.com/devrandom/gitian-builder/pull/185 Tree-SHA512: 0fa50b6c1be35a7a39f4a82816369637d3d0082922ac9876b80ae8156c795dec0ff34ad384b5348777042df8ddb6a72bbaeddd7002ef80557b10e2acf46632aa	2018-07-15 17:26:18 -04:00
Conrado Gouvea	37d363dd4a	Tools: fix BIND_NOW check in security-check.py ... Previously, the BIND_NOW check would work only if it was the first value in FLAGS.	2018-07-12 13:16:01 -03:00
Wladimir J. van der Laan	dcb154e5aa	Merge #13177: GCC-7 and glibc-2.27 back compat code ... 253f592909 Add stdin, stdout, stderr to ignored export list (Chun Kuan Lee) fc6a9f2ab1 Use IN6ADDR_ANY_INIT instead of in6addr_any (Cory Fields) 908c1d7745 GCC-7 and glibc-2.27 compat code (Chun Kuan Lee) Pull request description: The `__divmoddi4` code was modified from https://github.com/gcc-mirror/gcc/blob/master/libgcc/libgcc2.c . I manually find the older glibc version of log2f by objdump, use `.symver` to specify the certain version. Tree-SHA512: e8d875652003618c73e019ccc420e7a25d46f4eaff1c7a1a6bfc1770b3b46f074b368b2cb14df541b5ab124cca41dede4e28fe863a670589b834ef6b8713f9c4	2018-07-12 17:46:29 +02:00
Jeff Frontz	85644354c5	Corrected text to reflect new[er] process of specifying fingerprints instead of individual keys.	2018-07-09 13:45:51 -04:00
DesWurstes	000000035b	Obsolete #!/bin/bash shebang	2018-06-20 11:12:41 +03:00
Wladimir J. van der Laan	45c00f8416	Merge #13454: Make sure LC_ALL=C is set in all shell scripts ... 47776a958b Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C" (practicalswift) 3352da8da1 Add "export LC_ALL=C" to all shell scripts (practicalswift) Pull request description: ~~Make sure `LC_ALL=C` is set when using `grep` range expressions.~~ Make sure `LC_ALL=C` is set in all shell scripts. From the `grep(1)` documentation: > Within a bracket expression, a range expression consists of two characters separated by a hyphen. It matches any single character that sorts between the two characters, inclusive, using the locale's collating sequence and character set. For example, in the default C locale, `[a-d]` is equivalent to `[abcd]`. Many locales sort characters in dictionary order, and in these locales `[a-d]` is typically not equivalent to `[abcd]`; it might be equivalent to `[aBbCcDd]`, for example. To obtain the traditional interpretation of bracket expressions, you can use the C locale by setting the `LC_ALL` environment variable to the value C. Context: [Locale issue found when reviewing #13450](https://github.com/bitcoin/bitcoin/pull/13450/files#r194877736) Tree-SHA512: fd74d2612998f9b49ef9be24410e505d8c842716f84d085157fc7f9799d40e8a7b4969de783afcf99b7fae4f91bbb4559651f7dd6578a6a081a50bdea29f0909	2018-06-18 13:18:12 +02:00
Wladimir J. van der Laan	a90ca4087a	Merge #13448: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python ... c8176b3cc7 Add linter: Make sure we explicitly open all text files using UTF-8 or ASCII encoding in Python (practicalswift) 634bd97001 Explicitly specify encoding when opening text files in Python code (practicalswift) Pull request description: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python. As requested by @laanwj in #13440. Tree-SHA512: 1651c00fe220ceb273324abd6703aee504029b96c7ef0e3029145901762c733c9b9d24927da281394fd4681a5bff774336c04eed01fafea997bb32192c334c06	2018-06-16 15:23:14 +02:00
Loganaden Velvindron	9e2e5626da	Fix CVE-2018-12356 by hardening the regex.	2018-06-15 21:45:32 +04:00
practicalswift	3352da8da1	Add "export LC_ALL=C" to all shell scripts	2018-06-14 15:27:52 +02:00
practicalswift	634bd97001	Explicitly specify encoding when opening text files in Python code	2018-06-12 21:34:52 +02:00
Wladimir J. van der Laan	fa4b9065a8	Merge #13066: Migrate verify-commits script to python, run in travis ... e5b2cd8e75 Use python instead of slow shell script on verify-commits (Chun Kuan Lee) Pull request description: The cron job that runs every day would fail because of git checkout a single commit, not a branch. #12708 introduce a method to check whether merges are clean. However, there are four merges are not clean. So, I add a list of merges that are dirty and ignore them. Also, I modify the current shell script to python, it makes the script speed up a lot. The python code `tree_sha512sum` was copied from `github-merge.py` I've re-designed this. Now we verify all the things by default. - Add `--disable-tree-check` option, not to check SHA-512 tree - Add `--clean-merge NUMBER` option, only verify commits after &lt;NUMBER> days ago Travis running time: |option|time| |-|-| |verify-commits.py|[25m47.02s(1547.02s)](https://travis-ci.org/ken2812221/bitcoin/jobs/373321423)| |verify-commits.py --disable-tree-check|[19m10.08s(1150.08s)](https://travis-ci.org/ken2812221/bitcoin/jobs/373321423)| |verify-commits.py --clean-merge 30|[9m18.18s(558.18s)](https://travis-ci.org/ken2812221/bitcoin/jobs/373321423)| |verify-commits.py --disable-tree-check --clean-merge 30|[1m16.51s(76.51s)](https://travis-ci.org/ken2812221/bitcoin/jobs/373321423)| Since the cron job always fail, I've created a respository to verify this daily. [](https://travis-ci.org/ken2812221/bitcoin-verify-commits) Tree-SHA512: 476bcf707d92ed3d431ca5642e013036df1506120d3dd2aa718f74240063ce856abd78f4c948336c2a6230dfe5c60c6f2d52d19bdb52d647a1c5f838eaa02e3b	2018-06-12 17:25:25 +02:00
Chun Kuan Lee	e5b2cd8e75	Use python instead of slow shell script on verify-commits	2018-06-12 14:48:02 +00:00
Wladimir J. van der Laan	56f69360dc	Merge #13374: utils and libraries: checking for bitcoin address in translations ... 85f0135eae utils: checking for bitcoin addresses in translations (Max Kaplan) Pull request description: Closes #13363 Tree-SHA512: 8509b4ab004139942c847b93d7b44096a13df8e429dd05459b430a1cf7eaef16c4906ab9dc854f4e635312e1ebb064cfab1bad97fec914c7e926c83ad45cc99b	2018-06-08 16:53:53 +02:00
Max Kaplan	85f0135eae	utils: checking for bitcoin addresses in translations ... Checking for and removing any bitcoin addresses in translations	2018-06-05 07:49:21 -04:00
Giulio Lombardo	989c8990bb	Rename “OS X” to the newer “macOS” convention	2018-06-04 13:04:04 +02:00
Chun Kuan Lee	253f592909	Add stdin, stdout, stderr to ignored export list	2018-06-02 19:44:33 +00:00
Andrew Chow	86967b2e35	Add option to use docker for gitian-build.sh	2018-06-01 14:04:41 -04:00
Wladimir J. van der Laan	3a8e3f4806	Merge #13340: doc: remove leftover check-doc documentation ... 93843f6891 doc: remove leftover check-doc documentation (fanquake) Pull request description: Remove leftover check-doc.py documentation. Mentioned [here](https://github.com/bitcoin/bitcoin/pull/13281#issuecomment-392010168), it's now [here](https://github.com/bitcoin/bitcoin/tree/master/test/lint#check-docpy). Tree-SHA512: 95a0ac221ffae109c1d4baf18a9220cf993fc07c005920a0bd09abdf52e8fb298e3b5df31fa18887719c5080d8531d18b84b7bd9c7c664ee2501ccd9e0975eb6	2018-05-29 16:03:35 +02:00
Wladimir J. van der Laan	e08c130c25	Merge #13320: Ensure gitian-build.sh uses bash ... f44a0ebfff Ensure gitian-build.sh uses bash (Jeff Frontz) Tree-SHA512: 88544d09015fde2c80e20c560d1e899df5dec108d89014d3f7ff182b56d7af4c29cb0a7297080bdca1cb01de69e26f31c820a47e6217f6846b0ae6e666d84fc2	2018-05-29 15:57:47 +02:00
Jeff Frontz	f44a0ebfff	Ensure gitian-build.sh uses bash ... If the user has some other login shell (e.g., ksh), the bashisms in gitian-build.sh don't work so well.	2018-05-29 15:55:24 +02:00
fanquake	93843f6891	doc: remove leftover check-doc documentation	2018-05-29 21:49:34 +08:00
Wladimir J. van der Laan	2ac6315f44	Merge #13281: test: Move linters to test/lint, add readme ... fa3c910bfe test: Move linters to test/lint, add readme (MarcoFalke) Pull request description: This moves the checks and linters from `devtools` to a subfolder in `test`. (Motivated by my opinion that the dev tools are mostly for generating code and updating the repo whereas the linters are read-only checks.) Also, adds a readme to clarify that checks and linters are only meant to prevent bugs and user facing issues, not merely stylistic preference or inconsistencies. (This is motivated by the diversity in developers and work flows as well as existing code styles. It would be too disruptive to change all existing code to a single style or too burdensome to force all developers to adhere to a single style. Also note that our style guide is changing, so locking in at the wrong style "too early" would only waste resources.) Tree-SHA512: 9b10e89f2aeaf0c8a9ae248aa891d74e0abf0569f8e5dfd266446efa8bfaf19f0ea0980abf0b0b22f0d8416ee90d7435d21a9f9285b66df43f370b7979173406	2018-05-29 15:45:48 +02:00
MarcoFalke	fa3c910bfe	test: Move linters to test/lint, add readme	2018-05-24 12:02:15 -04:00
MarcoFalke	d792e47421	Merge #13228: Add script to detect circular dependencies between source modules ... a7b295e91e Add circular dependencies script (Pieter Wuille) Pull request description: This script finds dependencies between source code modules, treating the `.cpp` and `.h` file as one unit (so it will detect `A.cpp` depending on `B.h` where `B.cpp` depends on `A.h`). This can be used to find out which modules cannot be used independently from each other. It is very simplistic at this point, and assumes that a `.cpp` file's corresponding header has the exact same name, with `.cpp` replaced by `.h`. Furthermore, it assumes all `#include`s are relative to the `src/` directory. This is not a linter, and is not enforced through Travis or otherwise. This is the current output: ``` $ ../contrib/devtools/circular-dependencies.py {*,*/*,*/*/*}.{h,cpp} Circular dependency: chain -> pow -> chain Circular dependency: chainparamsbase -> util -> chainparamsbase Circular dependency: checkpoints -> validation -> checkpoints Circular dependency: init -> index/txindex -> init Circular dependency: init -> validation -> init Circular dependency: init -> net_processing -> init Circular dependency: init -> rpc/server -> init Circular dependency: init -> txdb -> init Circular dependency: init -> validationinterface -> init Circular dependency: random -> util -> random Circular dependency: sync -> util -> sync Circular dependency: txmempool -> validation -> txmempool Circular dependency: txmempool -> policy/fees -> txmempool Circular dependency: validation -> index/txindex -> validation Circular dependency: validation -> policy/policy -> validation Circular dependency: validation -> validationinterface -> validation Circular dependency: qt/addresstablemodel -> qt/walletmodel -> qt/addresstablemodel Circular dependency: qt/bantablemodel -> qt/clientmodel -> qt/bantablemodel Circular dependency: qt/bitcoingui -> qt/walletview -> qt/bitcoingui Circular dependency: qt/bitcoingui -> qt/walletframe -> qt/bitcoingui Circular dependency: qt/bitcoingui -> qt/utilitydialog -> qt/bitcoingui Circular dependency: qt/clientmodel -> qt/peertablemodel -> qt/clientmodel Circular dependency: qt/paymentserver -> qt/walletmodel -> qt/paymentserver Circular dependency: qt/recentrequeststablemodel -> qt/walletmodel -> qt/recentrequeststablemodel Circular dependency: qt/sendcoinsdialog -> qt/walletmodel -> qt/sendcoinsdialog Circular dependency: qt/transactiontablemodel -> qt/walletmodel -> qt/transactiontablemodel Circular dependency: qt/walletmodel -> qt/walletmodeltransaction -> qt/walletmodel Circular dependency: rpc/rawtransaction -> wallet/rpcwallet -> rpc/rawtransaction Circular dependency: wallet/coincontrol -> wallet/wallet -> wallet/coincontrol Circular dependency: wallet/fees -> wallet/wallet -> wallet/fees Circular dependency: wallet/rpcwallet -> wallet/wallet -> wallet/rpcwallet Circular dependency: wallet/walletdb -> wallet/wallet -> wallet/walletdb Circular dependency: txmempool -> validation -> policy/rbf -> txmempool Circular dependency: txmempool -> validation -> validationinterface -> txmempool Circular dependency: qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/addressbookpage Circular dependency: qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/guiutil Circular dependency: qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/signverifymessagedialog -> qt/addressbookpage Circular dependency: qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/receivecoinsdialog -> qt/addressbookpage Circular dependency: qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/intro -> qt/guiutil Circular dependency: qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/sendcoinsdialog -> qt/sendcoinsentry -> qt/addressbookpage ``` Tree-SHA512: 29bc985b7a41699f4666b0aaa785ca63c2145e84c37458536f4dcf8e3de8f1312cf0323fe09cb8f348a9d363583f76eac2d5bee574bc6a9f9cc97a9b0aad406f	2018-05-18 12:52:20 -04:00
Pieter Wuille	a7b295e91e	Add circular dependencies script	2018-05-16 16:55:47 -07:00
Cristian Mircea Messel	73cd5b25b9	[gui] Add proxy icon in statusbar	2018-05-15 23:23:56 +03:00
practicalswift	506c5785fb	Enable Travis checking for two Python linting rules we are currently not violating	2018-05-11 09:18:19 +02:00
John Bampton	0d31ef4762	Enable W191 and W291 flake8 checks. ... Remove trailing whitespace from Python files. Convert tabs to spaces.	2018-05-11 07:59:05 +10:00
Andrew Chow	4d4185a4f0	Make gArgs aware of the arguments ... gArgs knows what the available arguments are and their help. Getting the help message is moved to gArgs and HelpMessage() is removed	2018-05-09 12:21:05 -04:00
Wladimir J. van der Laan	bf9b03ddcc	Merge #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results ... ab3f4dd tests: Add test for 64-bit PE, modify 32-bit test results (Chun Kuan Lee) Pull request description: 9a75d29b6f change the error result from `PIE` to `DYNAMIC_BASE`. And there are no test for 64-bit, so I made one Tree-SHA512: 9d5643dadf4d9fc34ea32d94655bfb98eec2f7bc2820b4b0f525d5acf1cd22f3acf38bf8904dda4f50fd9ca5a5e56d566a392e6f804eea6e50e03cba40048621	2018-05-07 15:14:43 +02:00
MarcoFalke	4b75dcf0ec	devtools: Make linter check LogPrint calls	2018-05-02 15:14:37 +02:00
Wladimir J. van der Laan	1408d6cf76	Revert #12769: Add systemd service to bitcoind in debian package ... After discussion with Matt on IRC, this is not ready for prime time until 2019 and shouldn't have been ACKed and merged. - Revert "Add systemd service for bitcoind" This reverts commit 2a87b1b07c. - Revert "Sync contrib/debian from Matt Corallo's PPA" This reverts commit 9085532d35. Tree-SHA512: 439f4ccc3e196011af448b220adf26b0e653ac589bf4cfbbc276c1500c9d08f209c9d6101e4d232857779d9f25164cfb222ed30e3d63de116f9121e6ebde31c3	2018-05-01 17:05:06 +02:00
Wladimir J. van der Laan	35eb9d6c88	Merge #12769: Add systemd service to bitcoind in debian package ... 2a87b1b Add systemd service for bitcoind (ctp-tsteenholdt) 9085532 Sync contrib/debian from Matt Corallo's PPA (ctp-tsteenholdt) Pull request description: On suggestion from @TheBlueMatt I have updated `contrib/debian` files to include a systemd service in the `bitcoind` build. Tested and working on Ubuntu 16.04 and 17.10. This fixes Issue #12758 Tree-SHA512: b6137fafee940c7410df1242c8716a87f47c5bc60eb8df3ad0184a50c2d67ef3f2728761c742670a0ad546ab6e7ad60472a721350cd6280b3bcbdc582e50ee07	2018-05-01 16:52:57 +02:00
MarcoFalke	fa85de9ff5	Remove script to clean up datadirs ... This reverts commit 33c055c4f1. (#2295)	2018-04-29 18:33:25 -04:00
Chun Kuan Lee	ab3f4dd27f	tests: Add test for 64-bit PE, modify 32-bit test results ... 9a75d29b6f change the error result from `PIE` to `DYNAMIC_BASE`. And there are no test for 64-bit, so I made one	2018-04-27 01:34:05 +08:00
ctp-tsteenholdt	2a87b1b07c	Add systemd service for bitcoind ... Adding systemd service for bitcoind, to provide for a simpler out-of-the-box experience. Configuration file is /etc/bitcoin/bitcoin.conf. This file is a copy of the sample configuration file. The service user 'bitcoin' is added during install. Its homedir is in '/var/lib/bitcoin'. bitcoind.service is disabled by default to allow the user to configure it, before starting it the first time. On package purge, the 'bitcoin' user as well as its homedir is left intact, to not accidentally remove a wallet or something of equal importance. Instead the user is presented with information on how to perform the cleanup manually, after making sure all important data has been backed up.	2018-04-20 08:34:12 -02:00
ctp-tsteenholdt	9085532d35	Sync contrib/debian from Matt Corallo's PPA	2018-04-20 08:31:58 -02:00
MarcoFalke	07825088f9	Merge #12972: Add python3 script shebang lint ... 2bff472992 [contrib] convert test-security-check to python3 (John Newbery) 958bf40489 add lint tool to check python3 shebang (practicalswift) Pull request description: base58.py can executed by python3 Tree-SHA512: 30511204feefd4ccd5b4bf698fb88e516633e692dc95d31fe957b1c0c4879de25906355b28a5a0522171887315c8464a611e601ff00540db172d5bd463ee13d9	2018-04-16 16:03:22 -04:00
practicalswift	643aad17fa	Enable additional flake8 rules	2018-04-16 17:25:11 +02:00
practicalswift	f020aca297	Minor Python cleanups to make flake8 pass with the new rules enabled	2018-04-16 17:25:11 +02:00
John Newbery	2bff472992	[contrib] convert test-security-check to python3	2018-04-14 02:13:42 +08:00
practicalswift	958bf40489	add lint tool to check python3 shebang	2018-04-14 02:13:24 +08:00
MarcoFalke	3cf76c23fb	Merge #12933: doc: Refine header include policy ... fad0fc3c9a Refine travis check for duplicate includes (MarcoFalke) Pull request description: Since there is no harm in having "duplicate" includes and it makes it obvious what are the dependencies of each file, without having to do static analysis or jumping between files, I'd suggest to revert the travis check for duplicate includes. Generally, I think that enforcing minor style preferences should not be done via travis. The cost of maintaining and the burden on other developers is too high. C.f discussion in https://github.com/bitcoin/bitcoin/pull/10973#discussion_r180142594 Tree-SHA512: 97ab0e769d457ccfb873fff6c99613f8b944cd7ef95bfdccb0e1bbe8f5df1f16548c658fa03af42516f806546e75646d338a061e7b057619490235d311ca21f1	2018-04-11 10:45:47 -04:00
practicalswift	1499fdc350	Add shell script linting: Check for shellcheck warnings in shell scripts	2018-04-11 15:41:18 +02:00
MarcoFalke	fad0fc3c9a	Refine travis check for duplicate includes ... This partially reverts commit c36b720d00.	2018-04-10 15:12:42 -04:00
Wladimir J. van der Laan	5ca1509d6a	Merge #12854: Add P2P, Network, and Qt categories to the desktop icon ... b63f23c Add P2P, Network, and Qt categories to the desktop icon (Luke Dashjr) Pull request description: Tree-SHA512: 10526bfb4b559ce43b28c6c82fa615cd167162e5c487025ade51fb6b67389a65d8b43138228ced49d6d6cdc8ac87654a7b76673e92e7b43b5a09c81642d59145	2018-04-10 15:33:57 +02:00
Wladimir J. van der Laan	ebd786b72a	Merge #12852: [doc] devtools: Setup ots git integration ... fa385c3 [doc] devtools: Setup ots git integration (MarcoFalke) Pull request description: Document the simple steps on how to set up ots git integration. Tree-SHA512: 1b9f99bfaa6cd9dc581243d3a3584301645e95450acc3b5898dcdb53849569de16bb8ef2676b18f6b8dd402de10aee80119e15c1b28cef36f17ad121cbba2ba3	2018-04-10 15:29:10 +02:00
MarcoFalke	fa385c3a8b	[doc] devtools: Setup ots git integration	2018-04-09 08:23:24 -04:00
practicalswift	c36b720d00	Add Travis check for duplicate includes ... This enforces parts of the project header include guidelines (added by @sipa in #10575).	2018-04-09 09:18:49 +02:00
Wladimir J. van der Laan	3190785c11	Merge #12891: [logging] add lint-logs.sh to check for newline termination. ... d207207 [logging] add lint-logs.sh to check for newline termination. (John Newbery) 5c21e6c [logging] Comment all continuing logs. (John Newbery) Pull request description: Check that all calls to LogPrintf() are terminated by a newline, except those that are explicitly marked as 'continued' logs. Tree-SHA512: fe5162b2b2df1e8a4c807da87584fa9af97a6b8377e4090fe0caa136d90bf29a487a123cde94569bdce7101fee3478196d99aa13f1212e24bfe5f41c773604fc	2018-04-08 11:04:49 +02:00
Wladimir J. van der Laan	d6f10b248a	Merge #12895: tests: Add note about test suite name uniqueness requirement to developer notes ... d1b622b tests: Add check for test suite name uniqueness in lint-tests.sh (practicalswift) dc8067b tests: Add note about uniqueness requirement for test suite names (practicalswift) 3ebfb2d tests: Avoid test suite name collision in wallet crypto_tests (MarcoFalke) Pull request description: * Add documentation: Add note about test suite name uniqueness requirement in developer notes * Add regression test: Update `lint-tests.sh` to make it check also for test suite name uniqueness Context: #12894 (`tests: Avoid test suite name collision in wallet crypto_tests`) Tree-SHA512: 3c8502db069ef3d753f534976a86a997b12bac539e808a7285193bf81c9dd8c1b06821c3dd1bdf870ab87722b02c8aa9574c62ace70c2a1b8091785cb8c9aace	2018-04-08 10:47:35 +02:00
Wladimir J. van der Laan	b2e5fe8b55	Merge #12708: Make verify-commits.sh test that merges are clean ... 577f111 Make verify-commits.sh test that merges are clean (Pieter Wuille) Pull request description: Unsure if we want this. This modifies verify-commits.sh to redo all merges along the leftmost commit branch (which includes all PR merges), and verify whether they match the merge commit's trees. The benefit is that it will detect a case where one of the maintainers merges a PR, but makes an unrelated change inside the merge commit. This on itself is not very strong, as unrelated changes can also be included in the merged branch itself - but perhaps the merge commit is not something that people are otherwise likely to look at. Fixes #8089 Tree-SHA512: 2c020f5ac3f771ac775aa726832916bb8e03a311b2745d7a9825047239bd0660d838f086f3456f2bb05cea14c1529f74436b8cdd74cc94b70e40b4617309f62c	2018-04-07 18:48:27 +02:00
John Newbery	d207207fd3	[logging] add lint-logs.sh to check for newline termination. ... Check that all calls to LogPrintf() are terminated by a newline, except those that are explicitly marked as 'continued' logs.	2018-04-07 12:29:52 -04:00
practicalswift	d1b622b5a2	tests: Add check for test suite name uniqueness in lint-tests.sh	2018-04-06 16:29:14 +02:00
Luke Dashjr	b63f23c175	Add P2P, Network, and Qt categories to the desktop icon	2018-04-02 02:43:53 +00:00
MarcoFalke	0c5f67b8e5	Merge #12757: Clarify include guard naming convention ... 3bcc0059b8 Add lint-include-guards.sh which checks include guard consistency (practicalswift) 8fd6af89a0 Fix missing or inconsistent include guards (practicalswift) 8af65d96f4 Document include guard convention (practicalswift) Pull request description: * **Documentation**: Document include guard convention * **Fix**: Fix missing or inconsistent include guards * **Regression test**: Add `lint-include-guards.sh` which checks include guard consistency Tree-SHA512: 8171878f60fd08ccbea943a11e835195750592abb9d7ab74eaa4265ae7fac523b1da9d31ca13d6ab73dd596e49986bfb7593c696e5f39567c93e610165bc2acc	2018-04-01 18:30:21 -04:00
MarcoFalke	9beded5860	Merge #12719: tests: Add note about test suite naming convention in developer-notes.md ... db983beba6 tests: Add lint-tests.sh which checks the test suite naming convention (practicalswift) 5fd864fe8a tests: Rename test suits not following the test suite naming convention (practicalswift) 7b4a296a71 tests: Add note about test suite naming convention (practicalswift) Pull request description: Changes: * Add note about test suite naming convention * Fix exceptions * Add regression test Rationale: * Consistent naming of test suites makes programmatic test running of specific tests/subsets of tests easier * Explicit is better than implicit Before this commit: ``` $ contrib/devtools/lint-tests.sh The test suite in file src/test/foo_tests.cpp should be named "foo_tests". Please make sure the following test suites follow that convention: src/test/blockchain_tests.cpp:BOOST_FIXTURE_TEST_SUITE(blockchain_difficulty_tests, BasicTestingSetup) src/test/prevector_tests.cpp:BOOST_FIXTURE_TEST_SUITE(PrevectorTests, TestingSetup) src/wallet/test/coinselector_tests.cpp:BOOST_FIXTURE_TEST_SUITE(coin_selection_tests, WalletTestingSetup) src/wallet/test/crypto_tests.cpp:BOOST_FIXTURE_TEST_SUITE(wallet_crypto, BasicTestingSetup) $ ``` After this commit: ``` $ contrib/devtools/lint-tests.sh $ ``` Tree-SHA512: 7258ab9a6b9b8fc1939efadc619e2f2f02cfce8034c7f2e5dc5ecc769aa12e17f6fb8e363817feaf15c026c5b958b2574525b8d2d3f6be69658679bf8ceea9e9	2018-04-01 18:28:22 -04:00
MarcoFalke	fa5825d610	Merge #12284: Remove assigned but never used local variables. Enable Travis checking for unused local variables. ... ea04bf7862 Enable flake8 warning F841 ("local variable 'foo' is assigned to but never used") (practicalswift) 169f3e8637 Remove assigned but never used local variables (practicalswift) Pull request description: Remove assigned but never used local variables. Enable Travis checking for unused local variables. Tree-SHA512: d6052ec9044c5d1f03d874ea3c8addd5a156779213ef9200f89d3ae53230f2fd1691aff405c3dae14178e5ef09912c4432e92f606ef4a5220ed9daa140cdee81	2018-04-01 18:24:30 -04:00