test: Replace inline-comments with logs, pep8 formatting

This commit is contained in:
MarcoFalke 2020-05-19 10:43:12 -04:00
parent fa83b39ff3
commit fa12a37b27
No known key found for this signature in database
GPG Key ID: CE2B75697E69A548

View File

@ -20,6 +20,7 @@ import string
import configparser import configparser
import sys import sys
def call_with_auth(node, user, password): def call_with_auth(node, user, password):
url = urllib.parse.urlparse(node.url) url = urllib.parse.urlparse(node.url)
headers = {"Authorization": "Basic " + str_to_b64str('{}:{}'.format(user, password))} headers = {"Authorization": "Basic " + str_to_b64str('{}:{}'.format(user, password))}
@ -85,10 +86,7 @@ class HTTPBasicsTest(BitcoinTestFramework):
assert_equal(401, call_with_auth(node, user + 'wrong', password + 'wrong').status) assert_equal(401, call_with_auth(node, user + 'wrong', password + 'wrong').status)
def run_test(self): def run_test(self):
self.log.info('Check correctness of the rpcauth config option')
##################################################
# Check correctness of the rpcauth config option #
##################################################
url = urllib.parse.urlparse(self.nodes[0].url) url = urllib.parse.urlparse(self.nodes[0].url)
self.test_auth(self.nodes[0], url.username, url.password) self.test_auth(self.nodes[0], url.username, url.password)
@ -96,9 +94,7 @@ class HTTPBasicsTest(BitcoinTestFramework):
self.test_auth(self.nodes[0], 'rt2', self.rt2password) self.test_auth(self.nodes[0], 'rt2', self.rt2password)
self.test_auth(self.nodes[0], self.user, self.password) self.test_auth(self.nodes[0], self.user, self.password)
############################################################### self.log.info('Check correctness of the rpcuser/rpcpassword config options')
# Check correctness of the rpcuser/rpcpassword config options #
###############################################################
url = urllib.parse.urlparse(self.nodes[1].url) url = urllib.parse.urlparse(self.nodes[1].url)
self.test_auth(self.nodes[1], self.rpcuser, self.rpcpassword) self.test_auth(self.nodes[1], self.rpcuser, self.rpcpassword)