Retropex/bitcoin
1
0
Fork 0
mirror of https://github.com/Retropex/bitcoin.git synced 2025-05-13 03:30:42 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

lint/circular-dependencies: Only check for real circular dependencies

Browse Source
This commit is contained in:
Luke Dashjr 2018-12-14 15:27:26 +00:00
parent 3248ebd754
commit f1c9717c7e
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
contrib/devtools/circular-dependencies.py
View File

@ -25,6 +25,7 @@ def module_name(path):
return path return path
if path.endswith(".h"): if path.endswith(".h"):
return path[:-2] return path[:-2]
return path
if path.endswith(".c"): if path.endswith(".c"):
return path[:-2] return path[:-2]
if path.endswith(".cpp"): if path.endswith(".cpp"):

2
test/lint/lint-circular-dependencies.py
View File

@ -25,6 +25,7 @@ EXPECTED_CIRCULAR_DEPENDENCIES = (
# Temporary, removed in followup https://github.com/bitcoin/bitcoin/pull/24230 # Temporary, removed in followup https://github.com/bitcoin/bitcoin/pull/24230
"index/base -> node/context -> net_processing -> index/blockfilterindex -> index/base", "index/base -> node/context -> net_processing -> index/blockfilterindex -> index/base",
) )
EXPECTED_CIRCULAR_DEPENDENCIES = ()
CODE_DIR = "src" CODE_DIR = "src"
@ -47,6 +48,7 @@ def main():
) )
for dependency_str in dependencies_output.stdout.rstrip().split("\n"): for dependency_str in dependencies_output.stdout.rstrip().split("\n"):
if dependency_str == '': continue
circular_dependencies.append( circular_dependencies.append(
re.sub("^Circular dependency: ", "", dependency_str) re.sub("^Circular dependency: ", "", dependency_str)
) )