Retropex/bitcoin
1
0
Fork 0
mirror of https://github.com/Retropex/bitcoin.git synced 2025-08-05 22:44:50 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bugfix: RPC/blockchain: Hold cs_main for CBlockIndex access as needed to avoid races in getblocklocations

Browse Source
This commit is contained in:
Luke Dashjr 2022-05-17 08:13:17 +00:00
parent 2ee1991c7d
commit e5f9e58ac3
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/rpc/blockchain.cpp
View File

@ -2910,11 +2910,19 @@ static RPCHelpMan getblocklocations()
UniValue result(UniValue::VARR);
do {
int64_t file_num;
uint64_t data_pos, undo_pos;
{
LOCK(::cs_main);
file_num = pblockindex->nFile;
data_pos = pblockindex->nDataPos;
undo_pos = pblockindex->nUndoPos;
}
UniValue location(UniValue::VOBJ);
location.pushKV("file", (uint64_t)pblockindex->nFile);
location.pushKV("data", (uint64_t)pblockindex->nDataPos);
if (pblockindex->nUndoPos) {
location.pushKV("undo", (uint64_t)pblockindex->nUndoPos);
location.pushKV("file", file_num);
location.pushKV("data", data_pos);
if (undo_pos) {
location.pushKV("undo", undo_pos);
}
if (pblockindex->pprev) {
location.pushKV("prev", pblockindex->pprev->GetBlockHash().GetHex());