From bf209ac7a732394c3a54d6d1e3fb43f180ac1bb8 Mon Sep 17 00:00:00 2001 From: Ben Woosley Date: Tue, 24 May 2022 09:47:22 -0500 Subject: [PATCH 1/2] doc: Fix spelling errors identified by codespell in coments From the output here: src/qt/test/addressbooktests.cpp:185: wilcard ==> wildcard src/qt/test/addressbooktests.cpp:191: wilcard ==> wildcard src/test/miniscript_tests.cpp:227: nd ==> and, 2nd src/test/versionbits_tests.cpp:260: everytime ==> every time src/util/time.h:89: precicion ==> precision src/util/time.h:90: precicion ==> precision ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt https://cirrus-ci.com/task/5275612980969472?logs=lint#L849 I added 'nd' to the spelling.ignored-words.txt, as it's valid miniscript. --- src/qt/test/addressbooktests.cpp | 4 ++-- src/test/versionbits_tests.cpp | 2 +- src/util/time.h | 4 ++-- test/lint/spelling.ignore-words.txt | 1 + 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/qt/test/addressbooktests.cpp b/src/qt/test/addressbooktests.cpp index ededde4da9..3b7a40438b 100644 --- a/src/qt/test/addressbooktests.cpp +++ b/src/qt/test/addressbooktests.cpp @@ -182,13 +182,13 @@ void TestAddAddressesToSendBook(interfaces::Node& node) search_line->setText("io"); QCOMPARE(table_view->model()->rowCount(), 2); - // Check wilcard "?". + // Check wildcard "?". search_line->setText("io?new"); QCOMPARE(table_view->model()->rowCount(), 0); search_line->setText("io???new"); QCOMPARE(table_view->model()->rowCount(), 2); - // Check wilcard "*". + // Check wildcard "*". search_line->setText("io*new"); QCOMPARE(table_view->model()->rowCount(), 2); search_line->setText("*"); diff --git a/src/test/versionbits_tests.cpp b/src/test/versionbits_tests.cpp index 129976ec15..9aedcf46a7 100644 --- a/src/test/versionbits_tests.cpp +++ b/src/test/versionbits_tests.cpp @@ -257,7 +257,7 @@ BOOST_AUTO_TEST_CASE(versionbits_test) /** Check that ComputeBlockVersion will set the appropriate bit correctly */ static void check_computeblockversion(VersionBitsCache& versionbitscache, const Consensus::Params& params, Consensus::DeploymentPos dep) { - // Clear the cache everytime + // Clear the cache every time versionbitscache.Clear(); int64_t bit = params.vDeployments[dep].bit; diff --git a/src/util/time.h b/src/util/time.h index 14df3fe53a..ad91a72860 100644 --- a/src/util/time.h +++ b/src/util/time.h @@ -86,8 +86,8 @@ void SetMockTime(std::chrono::seconds mock_time_in); std::chrono::seconds GetMockTime(); /** - * Return the current time point cast to the given precicion. Only use this - * when an exact precicion is needed, otherwise use T::clock::now() directly. + * Return the current time point cast to the given precision. Only use this + * when an exact precision is needed, otherwise use T::clock::now() directly. */ template T Now() diff --git a/test/lint/spelling.ignore-words.txt b/test/lint/spelling.ignore-words.txt index afdb0692d8..c931a0aae1 100644 --- a/test/lint/spelling.ignore-words.txt +++ b/test/lint/spelling.ignore-words.txt @@ -11,6 +11,7 @@ inout invokable keypair mor +nd nin ser unparseable From f565b2836d5efeb6f7c16d0fac813b06fa4d41e4 Mon Sep 17 00:00:00 2001 From: Ben Woosley Date: Wed, 25 May 2022 00:22:54 -0500 Subject: [PATCH 2/2] Fixup option name in bench message --- src/bench/bench.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bench/bench.cpp b/src/bench/bench.cpp index d26b52410c..26975bb59d 100644 --- a/src/bench/bench.cpp +++ b/src/bench/bench.cpp @@ -58,7 +58,7 @@ void benchmark::BenchRunner::RunAll(const Args& args) std::smatch baseMatch; if (args.sanity_check) { - std::cout << "Running with --sanity check option, benchmark results will be useless." << std::endl; + std::cout << "Running with --sanity-check option, benchmark results will be useless." << std::endl; } std::vector benchmarkResults;