Retropex/bitcoin
1
0
Fork 0
mirror of https://github.com/Retropex/bitcoin.git synced 2025-05-29 13:32:33 +02:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

QA: rpc_getblockfrompeer: Test that fetch-without-header actually works

Browse Source
This commit is contained in:
Luke Dashjr 2023-07-09 00:05:09 +00:00
parent 397e882e34
commit 78ff49027f
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/functional/rpc_getblockfrompeer.py
View File

@ -8,6 +8,7 @@ from test_framework.authproxy import JSONRPCException
from test_framework.messages import ( from test_framework.messages import (
CBlock, CBlock,
from_hex, from_hex,
msg_block,
msg_headers, msg_headers,
NODE_WITNESS, NODE_WITNESS,
) )
@ -103,7 +104,7 @@ class GetBlockFromPeerTest(BitcoinTestFramework):
self.log.info("Non-existent peer generates error, even if we already have the block") self.log.info("Non-existent peer generates error, even if we already have the block")
assert_raises_rpc_error(-1, "Block already downloaded", self.nodes[0].getblockfrompeer, short_tip, peer_0_peer_1_id + 1) assert_raises_rpc_error(-1, "Block already downloaded", self.nodes[0].getblockfrompeer, short_tip, peer_0_peer_1_id + 1)
self.log.info("Do fetch blocks even if the node has not synced past it yet") self.log.info("Do fetch blocks even if the node has not seen the header yet")
# For this test we need node 1 in prune mode and as a side effect this also disconnects # For this test we need node 1 in prune mode and as a side effect this also disconnects
# the nodes which is also necessary for the rest of the test. # the nodes which is also necessary for the rest of the test.
self.restart_node(1, ["-prune=550"]) self.restart_node(1, ["-prune=550"])
@ -113,6 +114,27 @@ class GetBlockFromPeerTest(BitcoinTestFramework):
block_hex = self.nodes[0].getblock(blockhash=blockhash, verbosity=0) block_hex = self.nodes[0].getblock(blockhash=blockhash, verbosity=0)
block = from_hex(CBlock(), block_hex) block = from_hex(CBlock(), block_hex)
# Connect a P2PInterface to the pruning node
p2p_i = P2PInterface()
node1_interface = self.nodes[1].add_p2p_connection(p2p_i)
node1_peers = self.nodes[1].getpeerinfo()
assert_equal(len(node1_peers), 1)
node1_interface_id = node1_peers[0]["id"]
assert_equal(self.nodes[1].getblockfrompeer(blockhash, node1_interface_id), {})
block.calc_sha256()
p2p_i.wait_for_getdata([block.sha256])
p2p_i.send_and_ping(msg_block(block))
assert_equal(block_hex, self.nodes[1].getblock(blockhash, 0))
self.nodes[1].disconnectnode(nodeid=node1_interface_id)
self.log.info("Do fetch blocks even if the node has not synced past it yet")
# Generate a block on the disconnected node that the pruning node is not connected to
blockhash = self.generate(self.nodes[0], 1, sync_fun=self.no_op)[0]
block_hex = self.nodes[0].getblock(blockhash=blockhash, verbosity=0)
block = from_hex(CBlock(), block_hex)
# Connect a P2PInterface to the pruning node and have it submit only the header of the # Connect a P2PInterface to the pruning node and have it submit only the header of the
# block that the pruning node has not seen # block that the pruning node has not seen
node1_interface = self.nodes[1].add_p2p_connection(P2PInterface()) node1_interface = self.nodes[1].add_p2p_connection(P2PInterface())