Retropex/bitcoin
1
0
Fork 0
mirror of https://github.com/Retropex/bitcoin.git synced 2025-05-22 10:02:34 +02:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

net: remove now unused Sock::Release()

Browse Source
This commit is contained in:
Vasil Dimov 2021-04-29 17:39:02 +02:00
parent 8e7eeb5971
commit 175fb2670a
No known key found for this signature in database
GPG Key ID: 54DF06F64B55CBBF
3 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/sock_tests.cpp
View File

@ -69,16 +69,6 @@ BOOST_AUTO_TEST_CASE(move_assignment)
BOOST_CHECK(SocketIsClosed(s)); BOOST_CHECK(SocketIsClosed(s));
} }
BOOST_AUTO_TEST_CASE(release)
{
SOCKET s = CreateSocket();
Sock* sock = new Sock(s);
BOOST_CHECK_EQUAL(sock->Release(), s);
delete sock;
BOOST_CHECK(!SocketIsClosed(s));
BOOST_REQUIRE(CloseSocket(s));
}
BOOST_AUTO_TEST_CASE(reset) BOOST_AUTO_TEST_CASE(reset)
{ {
const SOCKET s = CreateSocket(); const SOCKET s = CreateSocket();

7
src/util/sock.cpp
View File

@ -51,13 +51,6 @@ Sock& Sock::operator=(Sock&& other)
SOCKET Sock::Get() const { return m_socket; } SOCKET Sock::Get() const { return m_socket; }
SOCKET Sock::Release()
{
const SOCKET s = m_socket;
m_socket = INVALID_SOCKET;
return s;
}
void Sock::Reset() { CloseSocket(m_socket); } void Sock::Reset() { CloseSocket(m_socket); }
ssize_t Sock::Send(const void* data, size_t len, int flags) const ssize_t Sock::Send(const void* data, size_t len, int flags) const

7
src/util/sock.h
View File

@ -68,13 +68,6 @@ public:
*/ */
[[nodiscard]] virtual SOCKET Get() const; [[nodiscard]] virtual SOCKET Get() const;
/**
* Get the value of the contained socket and drop ownership. It will not be closed by the
* destructor after this call.
* @return socket or INVALID_SOCKET if empty
*/
virtual SOCKET Release();
/** /**
* Close if non-empty. * Close if non-empty.
*/ */