Retropex/bitcoin
1
0
Fork 0
mirror of https://github.com/Retropex/bitcoin.git synced 2025-05-28 13:02:38 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#25888: refactor: use strprintf for creating unknown-service-flag string

Browse Source 
706c8e0969 refactor: use `strprintf` for creating unknown-service-flag string (Sebastian Falbesoner)

Pull request description:

  No need to use a stringstream here. The trivial change can be verified by running the functional test `rpc_net.py`:
  c73c8d53fe/test/functional/rpc_net.py (L181-L184)
  As far as I could tell, this is the only instace left where we used `std::ostringstream` for the creation of simple strings (in `FormatSubVersion` using a stream makes sense since the number of placeholders is not constant).

ACKs for top commit:
  kristapsk:
    ACK 706c8e0969

Tree-SHA512: 069cea29aef03996ae16a0dc3ed87b1b2cf2ab0bf5987c225b10da12d0f4b62b7c3faf3a169c0b912eb2ad60c6ea0a09a622be7eaadad78cee0463ef4ffc0e19
This commit is contained in:
MacroFake 2022-08-22 08:26:11 +02:00
commit 027b6729bc
No known key found for this signature in database
GPG Key ID: CE2B75697E69A548
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/protocol.cpp
View File

@ -199,12 +199,7 @@ static std::string serviceFlagToStr(size_t bit)
// Not using default, so we get warned when a case is missing
}
std::ostringstream stream;
stream.imbue(std::locale::classic());
stream << "UNKNOWN[";
stream << "2^" << bit;
stream << "]";
return stream.str();
return strprintf("UNKNOWN[2^%u]", bit);
}
std::vector<std::string> serviceFlagsToStr(uint64_t flags)